Comments (2)
Good spot. I still need to add destroy to nearly all of the new makeup modules. Here's the pattern I like to follow:
https://github.com/eBay/mindpatterns/blob/gh-pages/_js/tabs.es6.js#L114
from makeup-expander.
cancelAsync
was added in 0.7.0 to help with the Marko issue. In future I think we should rename this to something less cryptic, like disable
(as it disables all listeners). We could even add an enable
method then that picks it up from where it was before being disabled. Anyhow, I still see a need for a destroy method too, so I'll leave this ticket open for me to do.
from makeup-expander.
Related Issues (7)
- autoCollapse conflicts with click behavior HOT 7
- expander default state HOT 2
- .babelrc could get picked up by bundlers HOT 1
- Uncaught TypeError: exitEmitter.add is not a function HOT 1
- Add `hostContainerClass` and `simulateSpacebarClick` options to readme HOT 4
- Replace `expand()`, `collapse()` and `isExpanded()` with getter/setter pattern
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from makeup-expander.