Question: Why doesn't Close() close the stream? about go-libp2p-core HOT 4 CLOSED

So, Close currently closes the write half. To close the read half, you need to read the EOF off the stream.

This is clearly not a very nice API and was a terrible mistake. I planned to address this once we merged the go-libp2p-core refractor and now we have.

from go-libp2p-core.

This is clearly not a very nice API and was a terrible mistake. I planned to address this once we merged the go-libp2p-core refractor and now we have.

I don't think this is a mistake. By the way, this exactly how things work for QUIC streams as well. And for TCP connections, if I remember correctly.

from go-libp2p-core.

The issue is at the API layer, not the protocol layer. That is, users expect Close() to close in both directions and free resources. This is what tcpconn.Close() does. It's also what a close(sock) does in C.

We need to support closing for reading/writing, but we should do the thing users expect by default.

from go-libp2p-core.

@raulk I see you're the author on the latest version of the PR for this #155. What's the latest state?

from go-libp2p-core.