extend `peer.Set` with the Remove method about go-libp2p-core HOT 4 CLOSED

Actually, I'd be in favor of removing the peer.Set altogether. The only consumer I can find is kad-dht (here and here) and the peerstore, where the peerstore isn't even using it in an efficient way.

Therefore, this code should probably live (unexported) inside kad.

from go-libp2p-core.

Hi @marten-seemann. Thanks for the explanation. Is it possible to temporary add this functionality(I can open a PR) as it's pretty logic that if there is a possibility to add a peer, then it might have possibility to delete a peer or could suggest what can I use instead of peer.Set(with add/remove peer functionality) if it will be deleted at all? I want to avoid copy pasting in my code

from go-libp2p-core.

This seems to be a trivial piece of code, so I'd argue that copy-pasting the parts that you need would actually be the right thing to do.

Also note that the API here is kind of confusing: You can set a size, but that size is not enforced by Add (only by TryAdd).

from go-libp2p-core.

ok, thank you.

from go-libp2p-core.