use a mock clock in bandwidth counter tests about go-libp2p-core HOT 4 CLOSED

Sounds good, working on this.

from go-libp2p-core.

@marten-seemann I suspect I'm missing some context here (I'm new in libp2p and the term 'bandwidth counter' doesn't mean anything to me) and will need this laid out in a bit more detail:

These tests are currently flaky

Which tests?

Injecting a mock clock

Where?

from go-libp2p-core.

Which tests?

The bandwidth tests.

Where?

Into the metrics/BandwidthCounter. It’s using the flow metrics repo, so probably we need to do it there too. Basically, the goal is that we don’t use any calls to time.Now() any more, but only to a clock.Now(). When run in production, clock.Now() use time.Now(), but in tests we can use a mock clock.

from go-libp2p-core.

Upstream work in libp2p/go-flow-metrics#18. After that lands will proceed with applying the mock clock here.

from go-libp2p-core.