jyssh / pin-unpin-tab Goto Github PK
View Code? Open in Web Editor NEWFirefox add-on to pin or unpin current tab in more efficient ways.
Home Page: https://addons.mozilla.org/en-US/firefox/addon/pinunpin-tab/
Firefox add-on to pin or unpin current tab in more efficient ways.
Home Page: https://addons.mozilla.org/en-US/firefox/addon/pinunpin-tab/
Steps to reproduce:
Reproducible: Always
This behaviour is consistent. Examples:
Custom dropdown not made out of select
elements don't have this problem. For example, dropdowns in Google Sheets.
It seems that mouseup
is not triggered after a select
element is clicked. I need to inspect further.
Click on the name of one of the spreadsheets on the homepage of Google Sheets. Long click triggers.
Would be nice to have a smaller/finer icon. On dark theme it's really "chunky" - stands out against all the other smaller elegant icons, and kinda distracting. :)
Great otherwise.
Would be nice to have config options (enable / disable) for:
For example, I like using the icon. So those other features get in the way - I'd like to disable them.
Hi,
I notice that long-click pinning doesn't work on the mastodon main interface:
https://mastodon.social/web/getting-started
(Probably on other instances of mastodon too)
The scrollbar is obstensibly counted within the page UI, thus capturing the long click event on it. Find a workaround for this.
Love the extension. One killer thing though: I usually drag-and-drop text really often. If I do this, the tabs change from pinned to unpinned all the time, cause I seem to drag too slowly. I also don't want to increase the click wait time, cause that is annoying.
STEPS TO REPRODUCE:
WHAT HAPPENS:
WHAT SHOULD HAPPEN:
Does that sound sensible?
As of v3.1, the add-on ignores mouse movement entirely. However, quite often, finger may not stay steady on a touchpad during long tap. In this situation, the add-on won't respond even when the user intends to pin/unpin the tab. So, the add-on should detect marginal mouse movement and trigger the long click action.
so that the user becomes aware of the feature, and the add-on that provides this feature.
I am using the latest version of the addon with Firefox Beta (59b8). The on-page click detection is overzealous when used from any pointing device with buttons I have available: Regardless of the interval setting on the preferences page, the pin/unpin action gets always triggered when clicking or tapping on a page, however long or short the click is.
I've ruled out the touchpad-driver specific setting ClickTime
which configures the length of the click (time between ButtonPress and ButtonRelease X11 events), which is set to 100ms and should be short enough NOT to trigger the feature -- doesn't matter. Likewise, physical clicks from touchpad or mouse report the correct time between ButtonPress and ButtonRelease events when monitored outside of Firefox.
So I assume there's something awry going on in Firefox or the extension, probably related to button event timing, or timestamp resolution? Let me know what information or tests I should provide/perform.
about:support data.
Hi!
Had to go through a little bit of search to find your repo, I think people on the Firefox community would love to see that this addon is open source.
In any case, thanks a lot, this must be the addon I use the most.
Cheers
How to reproduce:
That's what happens to me personally.
It also happens on sites that are gallery-like, where there's a button to go to next image like in a slideshow and if you were to hold that button for long enough the site would pin / unpin itself.
This also causes another extension (https://github.com/dessant/search-by-image) to automatically pin all ShutterStock pages that it opens (not sure if it's the same issue as the one causing this but there's definitely something up with that too)
Note: this is pretty annoying and took me months to figure out what's causing it.
Hi,
Thank you for this nice add-on.
It would be nice if a pinned tab would not become unpinned when refreshed.
And also when the click is to the same page. For example you pin the tab of a ticket in some bug tracker, add a comment to the ticket, and alas the tab is now unpinned :-/.
Ideally this might be configurable in the addon preferences ;-).
Thanks in advance and eager to make tests if you agree with this feature.
phep
Problem: Long click works, Alt+P shortcut - doesn't. If I start FF without GDK_BACKEND=wayland flag, everything works as expected.
I have no idea why but this addon keeps pinning tabs without my intention.
Hello:
Perform auto pin or unpin based on url or regex
A declarative, efficient, and flexible JavaScript library for building user interfaces.
๐ Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
An Open Source Machine Learning Framework for Everyone
The Web framework for perfectionists with deadlines.
A PHP framework for web artisans
Bring data to life with SVG, Canvas and HTML. ๐๐๐
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
Some thing interesting about web. New door for the world.
A server is a program made to process requests and deliver data to clients.
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
Some thing interesting about visualization, use data art
Some thing interesting about game, make everyone happy.
We are working to build community through open source technology. NB: members must have two-factor auth.
Open source projects and samples from Microsoft.
Google โค๏ธ Open Source for everyone.
Alibaba Open Source for everyone
Data-Driven Documents codes.
China tencent open source team.