Giter Club home page Giter Club logo

Comments (8)

jyssh avatar jyssh commented on June 25, 2024

Click & Hold the scrollbar without moving it...The tab will pin / unpin itself depending on the current state

First things first: Long click (i.e., holding a left mouse click for a configurable amount of milliseconds) on non-interactive portions of a webpage to pin/unpin its tab is an add-on feature. You can disable it in the add-on preferences.

If you know that already, and your problem is only the long-click on a non-moving scrollbar, then read further.

Detecting a click on a scrollbar is not foolproof. Edge cases break it all the time. However, detecting a moving scrollbar is easy.

So, a long-click on a static scrollbar would trigger the pinning, but if the scrollbar is moved, then the trigger is cancelled.

Generally, scrollbar is clicked on in order to move it. So, I found it acceptable to not implement a buggy scrollbar detection, but instead treat a static scrollbar as one of the long-clickable areas of the webpage.

from pin-unpin-tab.

jyssh avatar jyssh commented on June 25, 2024

Note: this is pretty annoying and took me months to figure out what's causing it.

This is a valid concern. Perhaps, the whole problem wouldn't have bothered you much if there had been a "pinning/unpinning" indicator of sorts that appears on a long click.

May be animating the add-on icon close to the cursor to indicate the trigger could suffice. I will look into the feasibility.

from pin-unpin-tab.

jyssh avatar jyssh commented on June 25, 2024

That's what happens to me personally.
It also happens on sites that are gallery-like, where there's a button to go to next image like in a slideshow and if you were to hold that button for long enough the site would pin / unpin itself.

Long clicking on buttons should not trigger the add-on. Could you tell me the website on which this happened?

from pin-unpin-tab.

phoriah avatar phoriah commented on June 25, 2024

Any page that has a scrollbar, even this one.
Video example below (note: all extensions but yours are disabled)
https://github.com/jyssh/pin-unpin-tab/assets/95628489/ff164306-9139-400d-aead-5d14cd22911f

from pin-unpin-tab.

jyssh avatar jyssh commented on June 25, 2024

Any page that has a scrollbar, even this one. Video example below (note: all extensions but yours are disabled) https://github.com/jyssh/pin-unpin-tab/assets/95628489/ff164306-9139-400d-aead-5d14cd22911f

Could you please read all of my above responses first? The first response tries to address what you demonstrated in the above linked video.

from pin-unpin-tab.

phoriah avatar phoriah commented on June 25, 2024

Any page that has a scrollbar, even this one. Video example below (note: all extensions but yours are disabled) https://github.com/jyssh/pin-unpin-tab/assets/95628489/ff164306-9139-400d-aead-5d14cd22911f

Could you please read all of my above responses first? The first response tries to address what you demonstrated in the above linked video.

I did read them, albeit I couldn't make much sense of it (sorry). Nor do I see how that would solve the problem, I'm pointing out a possible bug and the only logical solution to it I could imagine is it being removed / fixed, I don't see how an animation would fit anywhere here as it doesn't solve the issue. I hope you see where I'm coming from.

from pin-unpin-tab.

jyssh avatar jyssh commented on June 25, 2024

Go to the add-on's preferences.

If you untick the checkbox as shown in the screenshot below, then your problem should go away.

Screenshot 2023-07-27 at 8 48 07 PM

from pin-unpin-tab.

phoriah avatar phoriah commented on June 25, 2024

Go to the add-on's preferences.

If you untick the checkbox as shown in the screenshot below, then your problem should go away.
Screenshot 2023-07-27 at 8 48 07 PM

Omg, sorry for being blind. This does indeed solve my issue.

from pin-unpin-tab.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.