jyssh / pin-unpin-tab Goto Github PK

How to reproduce:

1. Go to any big pages (big enough for scrollbar to appear), even some css files in this repository work as example
2. Click & Hold the scrollbar without moving it
3. The tab will pin / unpin itself depending on the current state

That's what happens to me personally.
It also happens on sites that are gallery-like, where there's a button to go to next image like in a slideshow and if you were to hold that button for long enough the site would pin / unpin itself.

This also causes another extension (https://github.com/dessant/search-by-image) to automatically pin all ShutterStock pages that it opens (not sure if it's the same issue as the one causing this but there's definitely something up with that too)

Note: this is pretty annoying and took me months to figure out what's causing it.

Perform auto pin or unpin based on url or regex

so that the user becomes aware of the feature, and the add-on that provides this feature.

The scrollbar is obstensibly counted within the page UI, thus capturing the long click event on it. Find a workaround for this.

Click on the name of one of the spreadsheets on the homepage of Google Sheets. Long click triggers.

Hi,

I notice that long-click pinning doesn't work on the mastodon main interface:
https://mastodon.social/web/getting-started

(Probably on other instances of mastodon too)

Love the extension. One killer thing though: I usually drag-and-drop text really often. If I do this, the tabs change from pinned to unpinned all the time, cause I seem to drag too slowly. I also don't want to increase the click wait time, cause that is annoying.

STEPS TO REPRODUCE:

• click-drag text slowly

WHAT HAPPENS:

• tab changes from pinned to unpinned or vice versa

WHAT SHOULD HAPPEN:

• extension should detect considerable mouse movement, and NOT change pinned status. that should only happen when the mouse is not moved.

Does that sound sensible?

I have no idea why but this addon keeps pinning tabs without my intention.

Hi!

Had to go through a little bit of search to find your repo, I think people on the Firefox community would love to see that this addon is open source.

In any case, thanks a lot, this must be the addon I use the most.

Cheers

Would be nice to have a smaller/finer icon. On dark theme it's really "chunky" - stands out against all the other smaller elegant icons, and kinda distracting. :)

Great otherwise.

Hello:

1. I dont have a pin icon as shown after installing the addon.
2. I have tried what I thought was my left mouse click, long hold.. (on my trackpad) and nothing happened. I am on a mac, sierra OSX. Thankyou
   Any chance, we could have the Tab to automatically PIN on open. So the default position is pinned?

As of v3.1, the add-on ignores mouse movement entirely. However, quite often, finger may not stay steady on a touchpad during long tap. In this situation, the add-on won't respond even when the user intends to pin/unpin the tab. So, the add-on should detect marginal mouse movement and trigger the long click action.

When you click Alt + P on a Windows computer in Polish, a menu will open.
This is because the letter P mean Plik, which means File

My env:

1. Windows:
   

2. Firefox:
   

Would be nice to have config options (enable / disable) for:

• long-click feature
• shortcut

For example, I like using the icon. So those other features get in the way - I'd like to disable them.

Hi,
Thank you for this nice add-on.
It would be nice if a pinned tab would not become unpinned when refreshed.
And also when the click is to the same page. For example you pin the tab of a ticket in some bug tracker, add a comment to the ticket, and alas the tab is now unpinned :-/.
Ideally this might be configurable in the addon preferences ;-).
Thanks in advance and eager to make tests if you agree with this feature.
phep

Not natively supported by Firefox to my knowledge -- pinned tabs must be first "unpinned". Would complement the existing shortcut:

This behaviour is consistent. Examples:

• any of the dropdown on https://input.djr.com/preview/
• language dropdown at the bottom of https://developer.mozilla.org/en-US/docs/Learn

Custom dropdown not made out of select elements don't have this problem. For example, dropdowns in Google Sheets.

It seems that mouseup is not triggered after a select element is clicked. I need to inspect further.

Steps to reproduce:

1. Pin tab
2. Open page with a dropdown (HTML Select)
3. Click on it: The tab gets unpinned
4. Close the dropdown.
5. Click on it: The tab gets pinned again

Reproducible: Always

In previous versions of Firefox, it could be pinned to the address bar through the right-click menu of the Pin Tab menu in the Page Actions menu. This feature has removed so I am using the Pin Unpin Tab extension, but I prefer the address bar button rather than the toolbar button.

• OS: Antergos Sway
• Browser: FF Nightly 68.0a1 + "GDK_BACKEND=wayland" flag

Problem: Long click works, Alt+P shortcut - doesn't. If I start FF without GDK_BACKEND=wayland flag, everything works as expected.

I am using the latest version of the addon with Firefox Beta (59b8). The on-page click detection is overzealous when used from any pointing device with buttons I have available: Regardless of the interval setting on the preferences page, the pin/unpin action gets always triggered when clicking or tapping on a page, however long or short the click is.

I've ruled out the touchpad-driver specific setting ClickTime which configures the length of the click (time between ButtonPress and ButtonRelease X11 events), which is set to 100ms and should be short enough NOT to trigger the feature -- doesn't matter. Likewise, physical clicks from touchpad or mouse report the correct time between ButtonPress and ButtonRelease events when monitored outside of Firefox.

So I assume there's something awry going on in Firefox or the extension, probably related to button event timing, or timestamp resolution? Let me know what information or tests I should provide/perform.

about:support data.