Improvements to be made to the GUI about cyclesmineways HOT 16 OPEN

He's not dead guys!

from cyclesmineways.

Gosh darn the stupid "close and comment" button why do I always press you instead of just "comment"…

from cyclesmineways.

I would like to also suggest having images or a "video" file such as a gif on the wiki page on GitHub showing what the differences in the settings look like and link the corresponding page to the explanation of the setting on the GUI (I thought about having the images in the proposed GUI itself, but I don't know if its even possible). For some settings, like WATER_SHADER_TYPE, it would be nice to see the differences in the types before you run the script.

from cyclesmineways.

I've made a page on the wiki for water shaders
https://github.com/JMY1000/CyclesMineways/wiki/Water-Shader-Types
Maybe there could be a button in blender that opens that wiki page for reference?

Feel free to contribute to the wiki, if you want to.

from cyclesmineways.

Apologies for not being more active, I've been busy for the last three weeks working on a different project (different GitHub account for non-personal work.) I'll be working on maintaining this project better hopefully up until late August.

from cyclesmineways.

"Feel free to contribute to the wiki, if you want to."

Ahh, I have a bit to add, but I am unable to edit the wiki at all. How might I go about contributing to it?

from cyclesmineways.

@Masonrf You should now have the ability to edit all code, including the wiki.

from cyclesmineways.

@Masonrf There should be two buttons on the top-right of the scene saying "edit" and "new page". If there isn't, blame @JMY1000 :)

from cyclesmineways.

@ThomasLynn Only contributors have the ability to edit the wiki, so I made him a contributor.

from cyclesmineways.

^^

from cyclesmineways.

@JMY1000 do you want the GUI added to upcoming features?

from cyclesmineways.

@Masonrf GUI is already in upcomingfeatures.txt

from cyclesmineways.

The more I look at what's been written for the GUI, the less I think it should be included with the next upcoming release. As useful as it is from the standpoint of a tech demo (seeing that we can implement these technologies into our code), in it's current form, it's simply not very useful from an end user standpoint and doesn't fit with how the script currently is setup to be used: set up options then execute, rather than execute each individual piece. While the second option in by no means invalid, and in fact could be quite useful often, the GUI clashes regardless.

In any case, I believe that the best course of action is to exclude what's been written from the next release. I think we should revert most changes made in @c531072 for the main development branch and instead create a branch off of developer dedicated to working on the GUI. This will allow us to continue to push and release smaller changes without impacting our ability to work on the GUI. I think we should also take a similar approach to restructuring the water shader.

I haven't made these changes yet because I wanted to consult with the rest of the team regarding this.

from cyclesmineways.

I agree with you that it clashes. In its current state it's quite hard to find, and crashes a lot (I think it's a memory error due to me having a small rendered view port when I run the script). If we just remove it, push the script to master, then re-add it, that'll be fine.

I suggest you don't just quickly revert all the stuff done in c531072. We "could" leave the code in there, but comment out the part where it is assigned to Blender's GUI.
Changing def register and def unregister to pass, should work.
c531072#diff-eff090f38cbba489099d81d2fb2808a6R987
I haven't tested this, yet.

If we just comment out these lines, the code should work, but there will be junk code, which might confuse someone if they try to read the code.

from cyclesmineways.

I was already under the impression the GUI wasn't going to be this release. That's more of a "2.0" kind of version honestly. I agree with making a "Bleeding edge" branch, but two branches might be unnecessary.

I'd say it should be fine to just comment it out and add a comment above each commented block about something along the lines of "This feature is a work in progress and will be released in a later version of the script."

from cyclesmineways.

That should be sufficient, yes. I'll go an comment stuff out now.

from cyclesmineways.