Mapping Hyper Images to 1d / 2d about pyautolens HOT 3 CLOSED

This problem is more general throughout the code. For example, when simulating an image, we have to manually create its coordinate grid in 2D, flatten it to 1D to pass it through the galaxy / profiles modules, and then revert its intensities / deflections to 2d for the simulation. Its a similar problem in the visualization of an analysis, where we constantly revert images to 2D for plotting.

In my opinion, we need a decorator / wrapper that we can put on profile functions that says, basically, if the function is passed a 2D NumPy array / grid (or ScaledArray / Mask / Grid2D class), to map it to 1D before passing the data, get the result on this 1D grid and map it back to 2D. This (probably unmasked) 2D grid could either be stored in masked_image or generated on-the-fly using Mask.unmasked.

The ray-tracing module could then be passed a 2D grid collection (probably only using a sub grid) to generate unmasked 2D model images. Finally, we would need to change the behaviour of ProfileFitter as it performs convolution using 1D arrays (e.g. using an image and blurring-image). We could either overwrite it with a ProfileFitter2D or make another fancy decorator.

We don't need to do anything with PixelizationFitter, as the the solution is defined by the mask and we would never want to generate results outside the mask.

from pyautolens.

I am in the process of implementing the solution above and have the following notes:

• Mapping functionality is now built into GridMapper classes, which are extensions of the ImageGrid / SubGrid classes but also have functionality to map their 1D results to 2D. These are setup using the usual Mask functions, however instead of using a circular / annulus mask they are completely unmasked (except for the blurring region edges)

• I extended the transform_grid wrapper in profiles such that if the grid that is passed in is an instance of a GridMapper, the result that is returned (e.g. intensitites) is mapped to 2D. If the result is deflection angles, a list of 2D arrays is returned correspond to the x / y values.

• In MaskedImage, I setup a second GridCollection which is a collection of these GridMappers (image, sub and blurring). This ensures we can seamlessly pass our mapper-grids into ray-tracing like we do normal grids.

from pyautolens.

Implemented

from pyautolens.