Giter Club home page Giter Club logo

Comments (4)

Jammy2211 avatar Jammy2211 commented on June 24, 2024 1

We implemented the positive-only solver ~6 months ago, but I never did thorough tests on the interferometer implementation.

This could imply theres a bug in the code and I need to correctly swap-out the code for the positive-only solution. I'll do some checks this afternoon.

Most our interferometer analysis has been performed on a positive-negative solver, and we trust the results, so I think these results are reliable. I have for a while been wondering if the positive only solver would make any difference to interferometry...so it'll be nice to find out.

from pyautolens.

AstroAaron avatar AstroAaron commented on June 24, 2024

Hey,
Any updates on this?

I have for a while been wondering if the positive only solver would make any difference to interferometry...so it'll be nice to find out.

So, by default is it not even applied in the interferometric analysis? Testing the run time for use_positive_only_solver true and false, I found no net increase (or decrease) in run time. The time it takes for the figure_of_merit with use_positive_only_solver=false is shorter by ~30s but the fit_time increased by ~30s compared to leaving it on.

Having negative pixels in the source reconstruction doesn't seem physical at all. Especially, since the input is continuum data.

from pyautolens.

Jammy2211 avatar Jammy2211 commented on June 24, 2024

Not had time to check, but its on my to do list.

Having negative pixels in the source reconstruction doesn't seem physical at all. Especially, since the input is continuum data.

I agree, albeit I would note that every single lensing paper analysing interferometer data ever has used a positive-negative solver, so its pretty much the norm!

I'll try check asap, I've got a big source code refactor on the go which I need to get stable first lol.

from pyautolens.

AstroAaron avatar AstroAaron commented on June 24, 2024

Not had time to check, but its on my to do list.

Alright, just checking if it fell through the cracks. Thanks for working on it.

I agree, albeit I would note that every single lensing paper analysing interferometer data ever has used a positive-negative solver, so its pretty much the norm!

I expected as much, though I was wondering whether this was normal behavior for PyAutoLens. After all, it does have that feature but it could also have been something wrong with my code/input.

I'll try check asap, I've got a big source code refactor on the go which I need to get stable first lol.

No worries and good luck ;)

from pyautolens.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.