Giter Club home page Giter Club logo

Comments (9)

qiuhan96 avatar qiuhan96 commented on July 23, 2024

Just out of curiosity on the Step 1's pixelization_neighbors: For a given set of points, should the neighbors defined in the Voronoi term (polygons sharing edges) be the same as the neighbors defined in the Delaunay term (triangles sharing edges)?

For Delaunay, I currently compute the neighbors using this built-in function:

https://docs.scipy.org/doc/scipy/reference/generated/scipy.spatial.Delaunay.vertex_neighbor_vertices.html#scipy.spatial.Delaunay.vertex_neighbor_vertices

It returns a maximum number of neighbors of 9, which is the same as the maximum number of neighbors of a Voronoi tessellation.

from pyautolens.

Jammy2211 avatar Jammy2211 commented on July 23, 2024

I would have expected the maximum neighbors of a Delaunay triangulation to be 3, corresponding to the 3 triangle edges of each pixel.

Do you know what the 9 corresponds too? And if its related to the Vornoi grid does it vary depending on the source pixelization (as I would guess Voronoi cells can have more / less than 9).

from pyautolens.

qiuhan96 avatar qiuhan96 commented on July 23, 2024

Selection_553

from pyautolens.

qiuhan96 avatar qiuhan96 commented on July 23, 2024

This is an example of Delaunay tessellation. The black points are the traced pixelization grids and the white points are the circumcentres of the triangles. In Delaunay tessellation, a black point (traced pixel grid) is not associated with only one triangle, instead, it can be a vertice of many triangles. In that sense, it should have more than three neighbors. For example, the black point in the center has 7 neighbors since it connects to 7 other black points.

from pyautolens.

qiuhan96 avatar qiuhan96 commented on July 23, 2024

image (from https://gwlucastrig.github.io/TinfourDocs/NaturalNeighborTinfourAlgorithm/index.html)

Or this image shows it better. Seems Voronoi neighbors are the same things as the Delaunay neighbors.

from pyautolens.

Jammy2211 avatar Jammy2211 commented on July 23, 2024

Does a image-pixel source-pixel pairing every have more than 3 interpolations?

Clearly, I had no idea how a Delaunay tesslation actually works lol.

from pyautolens.

qiuhan96 avatar qiuhan96 commented on July 23, 2024

No. An image-pixel source-pixel pairing only has 3 interpolations.

from pyautolens.

Jammy2211 avatar Jammy2211 commented on July 23, 2024

Okay, great. That plays a signifcant role in the run times of the linear algebra (especially for w-tilde) so is a relief.

It sounds like your pixel neighbors array is correct, and can be used for regularization using the standard function we have.

It may be worth checking whether Vegetti regularize in this way.

from pyautolens.

qiuhan96 avatar qiuhan96 commented on July 23, 2024

I will check it

from pyautolens.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.