Giter Club home page Giter Club logo

Comments (2)

ffurrer avatar ffurrer commented on July 16, 2024

That's a fair point, feel free to open a PR for this.

from hand_eye_calibration.

NikolausDemmel avatar NikolausDemmel commented on July 16, 2024

Hi Fadri (and others). Thanks for providing this tool!

I am also interested in the Base-World transform and in aligned trajectories. I had a look in the code to check how this is computed for visualization / evaluation, and looking at

aligned_dq_W_E = align_paths_at_index(dq_W_E_vec)
aligned_dq_B_H = align_paths_at_index(dq_B_H_vec)
(poses_B_H, poses_W_H) = get_aligned_poses(aligned_dq_B_H,
aligned_dq_W_E,
best_estimated_dq_H_E)
(rmse_position_all,
rmse_orientation_all,
inlier_flags) = evaluate_alignment(poses_B_H, poses_W_H, config, config.visualize)
every_nth_element = config.visualize_plot_every_nth_pose
plot_poses([poses_B_H[:: every_nth_element],
poses_W_H[:: every_nth_element]],
True, title="3D Poses After Alignment")
it seems that you "simply" re-reference each trajectory with respect to the first pose, which boils to down to aligning the two trajectories by aligning their first pose.

Wouldn't it make more sense, in particular for evaluating the alignment error, but also for visualization, to do some least-squares trajectory alignment based on all poses (Horn algorithm)? Something like implemented in the RGBD benchmark tools (https://github.com/jbriales/rgbd_benchmark_tools/blob/80723c9c9530481ec7dc92d3c3f77575f6a25bec/src/rgbd_benchmark_tools/evaluate_ate.py#L47-L79)? I wounder if there is a specific reason you didn't do that and instead just align world and base frame based on the first pose? Or did I maybe miss something?

In case someone is working on this, the additions I'd love to see are:

  • (optionally) compute W_B using Horn
  • output the final W_B in a second calibration file
  • output the aligned B_H trajectory to a file, i.e. W_E computed from the input B_H, plus final estimates for H_E and W_B
  • all this would be useful both after the initial handeye-calibration and the batch-refinement step

from hand_eye_calibration.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.