Feedback on the 3.1.0rc1 release candidate about octoprint-eeprom-marlin HOT 4 CLOSED

Everything looks good, Charlie, except that when first opened after an OP reload, the info list is alphabetical, but when you "load", it scrambles the order.

from octoprint-eeprom-marlin.

Just looked into this, it is two different methods of getting the same thing as well, the initial load is provided by the API, but then when you hit the 'load' button the data is sent via the websocket. The 'scrambled' order is actually the order it comes out of the printer, this is on the socket. For some reason the Flask API sorts everything. Maybe historical, since dict order was not guaranteed on Python 2 (or up to 3.6) so maybe it does it's own sorting. So, nothing I can do about that one unless I implement my own sorting on the frontend to standardise it.

There is one issue, I can no longer upload backups. I didn't touch the backup code, but maybe something it relied on got deleted 🤔.

from octoprint-eeprom-marlin.

The 'scrambled' order is actually the order it comes out of the printer, this is on the socket

I kinda figured that was probably the "native" order, although I didn't compare it to an M503

So, nothing I can do about that one unless I implement my own sorting on the frontend to standardise it.

OK, it's merely cosmetic anyway.

There is one issue, I can no longer upload backups. I didn't touch the backup code, but maybe something it relied on got deleted 🤔.

Interesting. It seems to work for me, although I haven't dug into it. I do, however, have to click the restore button twice most of the time. I'll do some more checking when I have time.

from octoprint-eeprom-marlin.

RC2 out now, fixing a few issues observed in testing. New feedback ticket, #46. Hoping that it is good enough for release from that ticket.

The backup uploading has been switched from jQueryUI File Upload, to a native JS solution. The old one was a bit of a hack anyway and didn't seem to work reliably, at least in my tests. New version does seem to work every time, but of course now needs a test 😄.

from octoprint-eeprom-marlin.