Giter Club home page Giter Club logo

Comments (5)

jschwe avatar jschwe commented on June 16, 2024 1

I'm a bit skeptical that this is related to corrosion. Corrosion / CMake does all its work at configure time. At build time the Generator (in your case ninja) invokes the build rules (e.g. cargo rustc ..... There are multiple build rules, and Ninja will also spend some time evaluating Generator expressions and checking if a file was actually generated by the command. However, ninja is widely used and I doubt there is something there that could take a noticable amount of time. You could of course check if the issue also occurs when using Unix Makefiles as the Generator.

sccache is invoked by cargo (assuming you are using RUSTC_WRAPPER=sccache or something similar), so if the hang is related to sccache, then the issue is either on sccache or cargos side, since CMake / Ninja knows nothing about sccache.

from corrosion.

jschwe avatar jschwe commented on June 16, 2024

CMake sometimes hangs indefinitely after Cargo finishes building a crate.

Are your sure it is actually CMake that hangs? I've recently been experimenting on integrating a workaround for #413 into corrosion until it is fixed upstream, and have noticed hangs for the following dead simple program (only tested on mac):

// use std::ffi::OsString;
use std::process::Command;

fn main() {
 // let args = std::env::args_os()
 //     .chain([OsString::from("--target=abcdefg")]);
    let mut handle = Command::new("echo")
        // .args(args)
        .spawn()
        .expect("Failed to spawn");
    handle.wait().expect("Command wasn't running");
}

I get the following output:

❯ time $HOME/.rustup/toolchains/stable-aarch64-apple-darwin/bin/cargo run --release
    Finished release [optimized] target(s) in 0.00s
     Running `target/release/wrapper`
target/release/wrapper --target=abcdefg
$HOME/.rustup/toolchains/stable-aarch64-apple-darwin/bin/cargo run --release  0.01s user 0.01s system 0% cpu 3.081 total

The hang happens between "Running" which is printed immediately and the output of "echo" which can take seconds to appear, even though compilation has already finished!.
When cargo is removed from the picture I have not seen any hangs yet.

from corrosion.

ahayzen-kdab avatar ahayzen-kdab commented on June 16, 2024

Note that I used to have hangs as well when using vscode + CMake, but since disabling sccache i haven't observed them again. So I think it is somehow related to having sccache enabled.

from corrosion.

Be-ing avatar Be-ing commented on June 16, 2024

I think you are right that this only shows up with sccache. When the build hangs, neither rustc nor cargo processes are running. I don't know if Corrosion, CMake, or sccache are the problem; my guess is the bug is in sccache.

from corrosion.

Be-ing avatar Be-ing commented on June 16, 2024

Potentially related:
mozilla/sccache#1011
mozilla/sccache#756

I have never encountered this using sccache with Cargo alone (not using CMake + Corrosion).

from corrosion.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.