[Bug]: Macos build with -F rather than -L about corrosion HOT 4 OPEN

Note: I edited your description slightly to hide the log in a spoiler comment.

Does cxx-qt use corrosion_link_libraries() to tell corrosion to link with QTCore? If that is the case, then patching corrosion_link_libraries() to check if the FRAMEWORK target property is set, and passing -framework instead sounds like it might solve your problem.

from corrosion.

Not: I edited your description slightly to hide the log in a spoiler comment.

Does cxx-qt use corrosion_link_libraries() to tell corrosion to link with QTCore? If that is the case, then patching corrosion_link_libraries() to check if the FRAMEWORK target property is set, and passing -framework instead sounds like it might solve your problem.

Thanks for replying .
I had tried this function and you can see it in this photo.

And I don't think this function is useful because it only add -L flag ,but -L is wrong .

function(corrosion_link_libraries target_name)
    if(TARGET "${target_name}-static" AND NOT TARGET "${target_name}-shared")
        message(WARNING "The target ${target_name} builds a static library."
            "The linker is never invoked for a static libraries to link has effect "
            " aside from establishing a build dependency."
            )
    endif()
    add_dependencies(_cargo-build_${target_name} ${ARGN})
    foreach(library ${ARGN})
        set_property(
            TARGET _cargo-build_${target_name}
            APPEND
            PROPERTY CARGO_DEPS_LINKER_LANGUAGES
            $<TARGET_PROPERTY:${library},LINKER_LANGUAGE>
        )

        corrosion_add_target_local_rustflags(${target_name} "-L$<TARGET_LINKER_FILE_DIR:${library}>")
        corrosion_add_target_local_rustflags(${target_name} "-l$<TARGET_LINKER_FILE_BASE_NAME:${library}>")
    endforeach()
endfunction(corrosion_link_libraries)

And I had modified -L to -F , It not work too.

from corrosion.

And I don't think this function is useful because it only add -L flag ,but -L is wrong .

What i was trying to say, is that if the -L flag in question comes from corrosion_link_libraries, then patching corrosion_link_libraries to emit -F for frameworks might fix your issue. But it seems you are saying the problematic -L is not added by corrosion_link_libraries, but from somewhere else instead (presumably cxx-qt` code). Thus your specific problem likely needs to be fixed upstream in cxx-qt and not here.

I'm still leaving this issue open, since making corrosion_link_libraries check if a library is a framework or not is probably the correct thing to do, regardless of it is related to your specific issue or not.

from corrosion.

And I don't think this function is useful because it only add -L flag ,but -L is wrong .

What i was trying to say, is that if the -L flag in question comes from corrosion_link_libraries, then patching corrosion_link_libraries to emit -F for frameworks might fix your issue. But it seems you are saying the problematic -L is not added by corrosion_link_libraries, but from somewhere else instead (presumably cxx-qt` code). Thus your specific problem likely needs to be fixed upstream in cxx-qt and not here.

I'm still leaving this issue open, since making corrosion_link_libraries check if a library is a framework or not is probably the correct thing to do, regardless of it is related to your specific issue or not.

Thank you for replying! You are right ! It only works when I modify build.rs in cxx-qt .
I think there are still two questions :
1 How can I send -F flag to cxx-qt .
2 Do I need to check the framework or library in corrosion? And even if corrosion is checked, what can it do?

from corrosion.