Comments (5)
bconn98
commented on August 21, 2024
1
Cool, I can throw it together at some point this week. Do you know when the cmake install rules for the tool were added? I can add backwards compatibility support through that point. I know my use case is on v0.4.5 but I can take it back farther.
from corrosion.
jschwe
commented on August 21, 2024
I'm not familiar with vcpkg and currently don't have much free capacity. Corrosion is also available via homebrew, which is maintained by the community and not by me or any of the other maintainers directly. If someone contributed vcpkg support, I would gladly add it to corrosions documentation.
from corrosion.
jschwe
commented on August 21, 2024
The install rules have been there from the beginning - at the very least starting from Corrosion 0.2.
It probably doesn't make much sense to add anything before v0.4 though, since I think v0.3 and before will not work properly on windows with the most recent Rust versions. Corrosion also follows semver, so I'm not sure sure if there is much value adding v0.4 versions before the latest version (v0.4.7) since there shouldn't be any breaking changes.
from corrosion.
jschwe
commented on August 21, 2024
The upstream vcpkg PR has apparently been rejected, so I'll be closing this issue.
Just to be clear, from my side I don't object adding corrosion to vcpkg, but I don't see any point in keeping this issue when upstream has rejected the proposal.
from corrosion.
bconn98
commented on August 21, 2024
Agreed, the PR we applied a few weeks ago covers ensures compatibility with Vcpkg so I should be all set.
from corrosion.
Related Issues (20)
- [Bug]: Regression caused by passing AR? commit b72c8ceb52f5d0235ce0fc268cfeff20ce56e8d8? HOT 1
- Upstream Rust language support
- [Bug]:cross compile failed HOT 1
- [Bug]: cross compilation from linux to windows with build tools fails. HOT 4
- [Bug]: "multiple rules generate" with Ninja Multiconfig in CROSS_CONFIG mode HOT 10
- [Bug]: Macos build with -F rather than -L HOT 4
- unused crates in a workspace not included in package, but still expected HOT 3
- corrosion_import_crate: issue with PROFILE argument in combination with CRATES
- [Bug]: corrosion_link_libraries does not include transitive dependencies HOT 2
- Breaking change to target names containing dashes with Rust 1.79 HOT 3
- corrosion_experimental_cbindgen always triggers rebuilds of files that include the generated header HOT 3
- corrosion_link_libraries behavior vs. expectation HOT 1
- [Bug]: undefined symbols during link-time on Windows with LLVM HOT 8
- corrosion_set_features did not work HOT 8
- [Bug]: On error, FindRust puts `Rust_FOUND` in wrong scope HOT 1
- Detect and issue a warning if a different corrosion version is already included.
- [Bug]: strip=true and missing pdb files on Windows HOT 3
- Docs: C++ program linking stdlib statically HOT 2
- Fetch dependencies during configuration for offline build HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from corrosion.