banterle / hdr_toolbox Goto Github PK

There is a typo at line 52 of KrawczykTMO.m (epislon -> epsilon)
But `epsilon' is not in the scope. Which value should it have?

Hi Sir,

In the description of the KrawczyTMO.m , I supposed that the name of the paper is written wrong. I check from your book named "Advanced High Dynamic Range Imagıng" in the page 82 and Section 3.5.2 you referenced to the paper [204]"Lightness Perception in Tone Reproduction for High Dynamic Range Images".

However ın the description of the KrawczykTMO.m you cite the paper :

% The paper describing this technique is:
% "A Model of Visual Adaptation for Realistic Image Synthesis"
% by Grzegorz Krawczyk, Karol Myszkowski, Hans-Peter Seidel
% in Proceedings of EUROGRAPHICS 2005

Some examples from e.g. https://github.com/openexr/openexr-images cannot be loaded by HDR Toolbox due to lack of support in older tinyexr 0.9.0

First of all, thank you for sharing this comprehensive toolbox. While examining the code I realized a bug in RandomSpatialSampling function. In this:

Do you think if it is suitable to add exposure fusion to compare with HDR?
Some works like this Mertens, Tom, Jan Kautz, and Frank Van Reeth. "Exposure fusion." Computer Graphics and Applications, 2007. PG'07. 15th Pacific Conference on. IEEE, 2007.
Provide an alternative choice to produce better LDR from different exposure time image

After tone mapping, I wrote an image by imwrite in Matlab.
Then read the image, I found the pixel values are different.

Before write the image, the pixel values of imgOut are decimal in (0,1):

After write and read the image, the pixel values of imgg are (0,255):

Thanks for the help!!!

YPWardGlobalTMO.m: line 34-40

if(~exist('Ld_max', 'var'))
    Ld_max = 100;
end

if(~exist('maxLayers', 'var'))
    Ld_max = 32;
end

I think it should be

if(~exist('Ld_max', 'var'))
    Ld_max = 100;
end

if(~exist('maxLayers', 'var'))
    maxLayers = 32;
end

ReinhardDevlinTMO.m line 101-109

if(bNormalization)
    L = lum(imgOut);
    Lmax = max(L(:));
    Lmin = min(L(:));
    delta = Lmax - LMin;
    if(delta > 0.0)
        imgOut = ClampImg((imgOut - Lmin) / delta, 0, 1);
    end
end

I think it should be

if(bNormalization)
    L = lum(imgOut);
    Lmax = max(L(:));
    Lmin = min(L(:));
    delta = Lmax - Lmin;
    if(delta > 0.0)
        imgOut = ClampImg((imgOut - Lmin) / delta, 0, 1);
    end
end

Hi,I am a student from china ! I know less in matlab so I want make it to the python. can I ?

The tone mapping PattanaikVisualAdaptationStaticTMO uses the function ColorCorrectionSigmoid however that function is missing in the ColorCorrection folder.

I have traced the source code of MitsunagaNayarCRF.m
seems the implementation only do 1 iteration
doesn't realize iterative method include in Mitsunaga and Nayar 's paper

I am trying to make an HDR video using TMOs in the toolbox. The outputs are in exr format. I want to convert these exr frames to HDR video viewable on an HDR capable TV. How is that possible.

Thanks for useful toolbox.

I am trying to use demo_build_hdr.m file for stack images present here (original image sequence for memorial church): http://www.pauldebevec.com/Research/HDR/.
Unfortunately it reports an error as:

`Reference to non-existent field 'DigitalCamera'.

Error in ReadLDRStackInfo (line 68)
if(~isfield(img_info.DigitalCamera, 'ISOSpeedRatings'))

Error in demo_build_hdr (line 23)
stack_exposure = ReadLDRStackInfo(name_folder, format);`

I have installed dcraw too but still this error persists.
What am I missing ?

Hi,

in the function BanterleExpandMap is a little typo in lines 165 and 172:

Cannot find an exact (case-sensitive) match for 'bilateralfilter'

The closest match is: bilateralFilter

Error in BanterleExpandMap (line 165)
            expand_map(:,:,i) = bilateralfilter(expand_map_de(:,:,i),img(:,:,i));

Error in BanterleEO (line 71)
expand_map = BanterleExpandMap(img, bColorRec, bclampingThreshold, 0.95, 'gaussian', 0);

Error in demo4 (line 22)
[imgOut,expand_map] = BanterleEO(img, @InverseReinhard, [2000.0,1000.0], 5, 0.95, 2.2);

Changing the function calls to bilateralFilter fixes the issue.

Dear All,

Its seems there are the few (very minor) issues with the installHDRTookbox.m file which is mostly based due to the comments made in the file. I will just copy paste the errors for you to kindly fix :)

installHDRToolbox
Error: File: installHDRToolbox.m Line: 86 Column: 44
Unexpected MATLAB expression.

installHDRToolbox
Error: File: installHDRToolbox.m Line: 86 Column: 44
Unexpected MATLAB expression.

installHDRToolbox
Error: File: installHDRToolbox.m Line: 86 Column: 44
Unexpected MATLAB expression.

installHDRToolbox
Error: File: installHDRToolbox.m Line: 91 Column: 1
Unexpected MATLAB operator.

installHDRToolbox
Error: File: installHDRToolbox.m Line: 98 Column: 1
Unexpected MATLAB operator.

installHDRToolbox
Error: File: installHDRToolbox.m Line: 106 Column: 1
Unexpected MATLAB operator.

Again thanks for your contribution :)

hello, this HDR tool box is so helpful for HDR learning. Now I try to convert HDR10 to SDR but get strange color for converted SDR，the color seems no difference between converted SDR and HDR but the bitdepth is changed to 8bit. Here is my conversion steps:

1. HDR non-linear RGB to linear RGB (with PQ EOTF transfer function)
2. hable tone mapping (HDR-tools function rewrited by python)
3. color space conversion (with rec2020 to rec709 matrix in ITU.2047)
4. SDR linear RGB to non_linear RGB (with gamma 2.4)

I don not know where make mistakes, and cannot get the same conversion as ffmpeg. It will be appreciated if you tell me the reason for the mis-tranform.

Hello, I find a bug related Reinhard Tonemapping
in HDR_Toolbox/source_code/Tmo/util/logMean.m

Lav = exp(mean(img_delta(:)));
should be
Lav = mean(exp(img_delta(:)));

According to the paper

Hello , if I want to calculate the mPSNR between two pfm files then I should load thease images , but it dosen't work

](url)

as title

When I try to use demo_build_radiance_map to generate HDR image for the dataset stack
included in the toolbox, cannot have fine result with it

I find there are few kinds color correction method in the source code
But I find that for ColorCorrectionMantiuk.m and ColorCorrection.m(It's schlick's method, right?), the implementation are odd, it should need HDR and LDR(tonemapped HDR) image as input, but seems it only take LDR and have manipulation for it.

I ran the installHDRToolbox. After few minutes the installation stopped and here are the problems it proposed"read_exr.cpp and write_exr.cpp were not compiled, bilateralFilterS.cpp was not compiled". What's wrong?

Could you please provide example pictures from the book High Dynamic Range Imaging(the secong edition)? I'm currently studying this book！

Thank you for your code and papers.
I am studying about HDR especially expansion operator.
On your book chapter 4.6(first edition) or 6.6(second edition) Expand Map Model, you have explained expand map model research.(Banterle expand map, Rempel map etc.) For detail of this implementation, I have searched EO folder, but there is no exist BanteleExpandMap.m, banterleEO.m, RempelExpandMap.m ...

Is there a licence problem?

Thank you again for your explain and contribution.