About color correction about hdr_toolbox HOT 6 CLOSED

What do you mean with odd?

They work with both LDR and HDR images. Can you clarify this please?

from hdr_toolbox.

I mean, for color correction, it should compare the result of tonemapped (that is,LDR) with HDR, right?
But the I/O of this two function only need 1 input image, different from that for ColorCorrectionPouli

from hdr_toolbox.

This is because those two techniques do not require to use the input HDR luminance.

ColorCorrectionPouli needs the original HDR for doing the correction.

from hdr_toolbox.

No, I don't think so.
I check the paper
They correct the tonemapped image by using the ratio of before tonemapping
In Mantiuk's paper, he specific said they equal the ratio before and after tonemapping
And he mentioned the method of schlick, too

from hdr_toolbox.

In the current toolbox implementation, there is only the linear chroma manipulation. This can be applied
as the Schlick's adjustment WITHOUT the input HDR image because it modifies only the color information without modifying luminance.

What you describe is the full technique which requires the TMO as well that has to be global.

I will rephrase the documentation in a better way to avoid misunderstandings.

from hdr_toolbox.

I improved the documentation and changed the name of the technique in order to avoid misunderstanding (dev branch). The full technique is in the to-do list. The issue is now close.

from hdr_toolbox.