Giter Club home page Giter Club logo

Comments (4)

joansola avatar joansola commented on May 13, 2024

Hello extr15 -- whatever your name is!

Yes you are right. What happens is that this factor is so trivial that it works anyway. But indeed one should be using the derivative of log() which is Jr^{-1}. I will double check it and change it if necessary when I have a minute.

As a side note, your suggested code however could make use of the Jacobian facility of manif, by doing

poses[0].log().rjacinv(Jac);
J.block<DoF, DoF>(row, col) = Jac;

Joan

from manif.

joansola avatar joansola commented on May 13, 2024

Hello. I had a look at this. In principle, you need Jr as indicated above. However, this Jacobian is very close to the Identity at the point of evaluation, which is the origin, so the math in the code is reasonably fine, and at the convergence point it is exact.

I am evaluating if the example code should be made clearer, and will fix this.

Thanks again

from manif.

joansola avatar joansola commented on May 13, 2024

Fixed. Waiting for PR acceptance.

from manif.

extr15 avatar extr15 commented on May 13, 2024

Thanks for your reply and work!

from manif.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.