alexflint / go-filemutex Goto Github PK

Hi,

We're looking at using this library to provide cross-platform file-locking in a CNI Plugin (see containernetworking/plugins#77).

I see several methods panic on error rather than returning the error to the caller.

Effective Go recommends

real library functions should avoid panic

[reference]

Would you be open to a PR that changes the signatures of the functions to return errors?

The library opens a filehandle but does not provide a method to close it. We're using this library in a CNI plugin that attempts to close which we obviously cant implement as anything but a noop util we have a close on this library. See containernetworking/plugins#77

I see the license file is empty. Would you be open to licensing this code under one of the standard OSS licenses? Apache or MIT would be great!

Thank you!