"Two of a kind": inventory items are not passed between characters properly about ags HOT 7 CLOSED

This is broken with original engine too, starting with 2.70. The verb interface is unusable on >= 2.70 but you can bring up an alternate inventory with the TAB key to reproduce the bug.

from ags.

When a character passes an inventory object the game first adds the inventory item to the new character. This is not done with a function call but with directly writing to game.chars[x].inv[y]. This works fine, but the new engine also has an option to sort the inventory window which is handled in the charextras struct. Apparently the old game.chars.inv indicates whether a character has an item but charextras handles whether the item is shown in the inventory. Because it is never updated in this game, it doesn't show the new item.

I don't know how to fix this in a general way. Due to the way this game is written a call to update_invorder() in Character_LoseInventory() seems to help here but in general this doesn't work.

from ags.

@jjsat

This is not done with a function call but with directly writing to game.chars[x].inv[y]

After I rewrote script interpreter there's now a way to catch direct reads/writes to object members from script and remap them, or even call a function instead. We may experiment with this and see if this will help here.

from ags.

The general idea is this. You override ReadInt16 and WriteInt16 virtual functions in CCCharacter class ("CharacterInfo::inv" array is type short), and put there something like:

void CCCharacter::WriteInt16(const char *address, intptr_t offset, int16_t val)
{
     if (offset >= A && offset < B )
     {
         SetInventoryItemCount ( (CharacterInfo*)address, (offset - A) >> 1 /* item id */, val /* new quantity*/  );
     }
     else
     {
         *(int16_t*)(address + offset) = val;
     }
 }

from ags.

Wow, very nice! This works for me. Calling Character_SetInventoryItemCount() does not update the inventory display and UpdateInventory() has to be called too.

    void WriteInt16(const char *address, intptr_t offset, int16_t val)
    {
        *(int16_t*)(address + offset) = val;

        const int invoffset = 112;//offsetof(CharacterInfo, inv);
        if (offset >= invoffset && offset < (invoffset + MAX_INV * sizeof(short)))
        {
            update_invorder();
        }
    }

from ags.

Should be fixed in commit 3e16b55.

from ags.

This was fixed, alright, so - closing.

from ags.