Giter Club home page Giter Club logo

Comments (6)

AlanDrake avatar AlanDrake commented on August 30, 2024

I agree, it's a good convenience for several cases.

from ags.

ericoporto avatar ericoporto commented on August 30, 2024

It misses the actual flags, but I believe the gist of the changes would be something like this

ericoporto@de5d29c

Not sure if there is a pretty way to get the trim in a single function.

from ags.

ericoporto avatar ericoporto commented on August 30, 2024

Uhm, I wonder if a string like " , , , ," is passed with both flags, what the result should be, would it be null or does an empty array exists in AGS script?

from ags.

ivan-mogilko avatar ivan-mogilko commented on August 30, 2024

The trim implementation from above commit looks fine, similar to what I've imagined.
(I'd only use camelcase function names similar to all names around, according to our code style)

Uhm, I wonder if a string like " , , , ," is passed with both flags, what the result should be, would it be null or does an empty array exists in AGS script?

AGS does not currently allow creating a zero-length dynamic array in script (with the new operator). But if this is a matter of convenience, we may investigate if it's possible to support such array, and return one. In fact, maybe it's already technically possible.

from ags.

ericoporto avatar ericoporto commented on August 30, 2024

I put a PR in #2461, please test it!

from ags.

ivan-mogilko avatar ivan-mogilko commented on August 30, 2024

Resolved by #2461

from ags.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.