Support rasterizing the Room viewport to a dynamic sprite about ags HOT 5 OPEN

Btw, if one could just pass a sprite to the save function, they could just pass a pre-made asset to the save function instead for that specific game area. In theory one could even pass the room background but I don't think it is accessible currently as a sprite directly - one needs to get it as a drawing surface and then draw it in another drawing surface of a dynamic sprite to be able to then get that sprite.

from ags.

Btw, if one could just pass a sprite to the save function,

Hm, that's actually a very good idea, might be done on its own, regardless of the screenshot feature.

EDIT: so like

SaveGameSlot (int slot, const string description, DynamicSprite *image);

or

SaveGameSlot (int slot, const string description, int sprite);

The issue here will be to "lock" or copy this dynamic sprite into some temp storage, because save is done after function exits, and if sprite is a local variable, then it may get disposed.

from ags.

Ah things that sounds easy in my head and become hell to implement...

I may try the second approach, and use a sprite slot and some static bitmap object that holds a copy of whatever it was in the slot and frees it after writing.

But not sure how do deal with existing behavior, maybe it's better to give a new function name like SaveGameSlotWithGraphic?

The other approach is to have a global dynamic sprite that you set and then the SaveGameSlot uses it if it's set, and then holding the memory becomes part of this global holding this reference. Something like Game.SaveGameSlotSprite. I think this is uglier but just thought to mention.

from ags.

I do not think it's overly hard, there may be only 1 scheduled Save call in a function, but indeed the sprite has to be scheduled along somehow.

The function may remain same, the new argument will be optional and have a default value 0, in which case the screenshot is made if global settings tell to.

Well, that's the first thought, I might need to investigate this closer in order to find any potential problems.

from ags.

So, apparently, there are following changes involved here:

1. Creating a screenshot with only selected layers (with DynamicSprite.CreateFromScreenShot);
2. Passing an arbitrary sprite to SaveGameSlot.
3. Telling how to make a automatic screenshot for the save (same settings are in p1).

I suppose that being able to pass any sprite to SaveGameSlot is a more suitable for individual function parameter than a screenshot layer selection, which is better set as a game option once (i.e. using SetGameOption).

Screenshot layers may be a combination of flags. For starters these could be only "cursor", "gui layer" and "room layer". More may be added later if there will be a need to filter specific sublayers (like make a screenshot of room background without objects), but these seem less useful (?).

In regards to implementation, graphic renderers already support tagging batches with a "layer" constant, and then filtering them out when redrawing last frame. Currently this is done for the purpose of fade-in and out effects, where mouse cursor should not be present.
As seen here, for example:

from ags.