Giter Club home page Giter Club logo

Comments (3)

iGxnon avatar iGxnon commented on August 19, 2024

I additionally add a configuration option “ensure_network” to control whether to check network environment every OpenAI API inquire

from gptcommit.

zurawiki avatar zurawiki commented on August 19, 2024

Thanks for the proposal @iGxnon, I like how you add more configurability to the proxy settings. Ensuring network is an understandable need for users where access is not authorized.

I believe that the problem of access and network checking falls outside of this project and would best be implemented in its own crate to separate concerns.
gptcommit is happy to support proxy configurations as needed, but it should be on the user to ensure the network configuration is working as expected.

from gptcommit.

iGxnon avatar iGxnon commented on August 19, 2024

Thanks for the proposal @iGxnon, I like how you add more configurability to the proxy settings. Ensuring network is an understandable need for users where access is not authorized.

I believe that the problem of access and network checking falls outside of this project and would best be implemented in its own crate to separate concerns. gptcommit is happy to support proxy configurations as needed, but it should be on the user to ensure the network configuration is working as expected.

OK, I’ll close this issue.

from gptcommit.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.