zhuyaliang / user-admin Goto Github PK

View Code? Open in Web Editor NEW

27.0 27.0 16.0 1.68 MB

License: GNU General Public License v3.0

Meson 2.34% C 97.52% Shell 0.14%

user-admin's People

Contributors

Stargazers

Watchers

Forkers

yetist raveit65 loongson-zn xihels kyrios123 guimmp92 zhangdong111 atriwidada linlinger zhangwenlong8911 n0rbert sunweaver imciner2 thesquash poofigator

user-admin's Issues

Segfault because I couldn't get the permission

user-admin/src/main.c

Line 117 in 5477818

 ua->Permission = polkit_permission_new_sync (USER_ADMIN_PERMISSION, NULL, NULL, &error); 

$ pkg-config --modversion polkit-gobject-1 gtk+-3.0
0.116
3.24.11

Main window width

The main window size is much larger in French than in English. Not a big thing but it looks a little weird in French (left column with the user list is wider and there is a big empty space on the right of the window)

English

In French

Crash when creating 2 consecutive users

level:[Info]  message: mate-user-admin user 1
level:[Debug]  message: py user lang 
level:[Info]  message: mate-user-admin Current user name Pierre-Yves
level:[Debug]  message: py user lang 
level:[Debug]  message: nuLang = en_US.utf8
level:[Debug]  message: NewUserlang = en_US.utf8
level:[Debug]  message: username testuser realname Test User usertype 1 langname en_US.utf8 passwod 1
level:[Info]  message: mate-user-admin Current user name Pierre-Yves
level:[Debug]  message: py user lang 
level:[Info]  message: mate-user-admin Current user name Test User
level:[Debug]  message: testuser user lang en_US.utf8
level:[Info]  message: mate-user-admin Current user name Pierre-Yves
level:[Debug]  message: py user lang 
level:[Info]  message: mate-user-admin Current user name Test User
level:[Debug]  message: testuser user lang en_US.utf8
level:[Debug]  message: nuLang = en_US.utf8
level:[Debug]  message: NewUserlang = en_US.utf8
level:[Debug]  message: username testuser2 realname Test User II usertype 1 langname en_US.utf8 passwod 1

PS: Is it normal that I have to authenticate to create the user while I already authenticated a few seconds before to unlock the interface ?

Dark themes, some fonts color should become white instead of black

When using dark themes, some fonts should be white instead of black (i.e. the users that are not selected in the left area of the main screen)

error: double free or corruption (out)

I successfully built and install the newly tagged group-service 1.2.0 and user-admin 1.5.0 but when I launch the application it fails with the following error:

$ mate-user-admin 
double free or corruption (out)
Aborted

user-group.c:577: undefined reference to `gas_group_is_primary_group'

Sorry, this is not an issue but a question.
I'm trying to build from the latest commit, but I'm getting the following error. Any idea of what I missed ?

[4/13] Compiling C object 'src/25a6634@@mate-user-admin@exe/user-group.c.o'.
../src/user-group.c: In function ‘CreateRemoveModel’:
../src/user-group.c:577:13: warning: implicit declaration of function ‘gas_group_is_primary_group’; did you mean ‘gas_group_is_local_group’? [-Wimplicit-function-declaration]
         if(!gas_group_is_primary_group(group->gas) &&
             ^~~~~~~~~~~~~~~~~~~~~~~~~~
             gas_group_is_local_group
../src/user-group.c:577:13: warning: nested extern declaration of ‘gas_group_is_primary_group’ [-Wnested-externs]
[12/13] Linking target src/mate-user-admin.
FAILED: src/mate-user-admin 
x86_64-solus-linux-gcc  -o src/mate-user-admin 'src/25a6634@@mate-user-admin@exe/main.c.o' 'src/25a6634@@mate-user-admin@exe/user-admin.c.o' 'src/25a6634@@mate-user-admin@exe/user-base.c.o' 'src/25a6634@@mate-user-admin@exe/user-face.c.o' 'src/25a6634@@mate-user-admin@exe/user-info.c.o' 'src/25a6634@@mate-user-admin@exe/user-list.c.o' 'src/25a6634@@mate-user-admin@exe/user-password.c.o' 'src/25a6634@@mate-user-admin@exe/user-share.c.o' 'src/25a6634@@mate-user-admin@exe/user-crop.c.o' 'src/25a6634@@mate-user-admin@exe/user-group.c.o' 'src/25a6634@@mate-user-admin@exe/user-history.c.o' -Wl,--no-undefined -Wl,--as-needed -Wl,-z,relro -Wl,-z,now -mtune=generic -march=x86-64 -g2 -O2 -pipe -fPIC -Wformat -Wformat-security -D_FORTIFY_SOURCE=2 -fstack-protector-strong --param ssp-buffer-size=32 -fasynchronous-unwind-tables -ftree-vectorize -feliminate-unused-debug-types -Wall -Wno-error -Wp,-D_REENTRANT -Wl,--copy-dt-needed-entries -Wl,-O1 -Wl,-z,relro -Wl,-z,now -Wl,-z,max-page-size=0x1000 -Wl,-Bsymbolic-functions -Wl,--sort-common -Wl,--start-group /usr/lib64/libgtk-3.so /usr/lib64/libgdk-3.so /usr/lib64/libpangocairo-1.0.so /usr/lib64/libpango-1.0.so /usr/lib64/libatk-1.0.so /usr/lib64/libcairo-gobject.so /usr/lib64/libcairo.so /usr/lib64/libgdk_pixbuf-2.0.so /usr/lib64/libgio-2.0.so /usr/lib64/libgobject-2.0.so /usr/lib64/libglib-2.0.so /usr/lib64/libpwquality.so /usr/lib64/libaccountsservice.so /usr/lib64/libgroup-service.so -lcrypt /usr/lib64/libmate-desktop-2.so /usr/lib64/libstartup-notification-1.so /usr/lib64/libpolkit-gobject-1.so -Wl,--end-group  
/usr/bin/ld: src/25a6634@@mate-user-admin@exe/user-group.c.o: in function `CreateRemoveModel':
/home/build/YPKG/root/user-admin/build/user-admin.git/solusBuildDir/../src/user-group.c:577: undefined reference to `gas_group_is_primary_group'
collect2: error: ld returned 1 exit status
[13/13] Generating mate-user-admin.desktop_data_merge with a custom command.
ninja: build stopped: subcommand failed.

"user count is 0" on 22.04 based Live environment

Hello!
I've been testing mate-user-admin on a mate 22.04 based environment distro pulling the package source from debian, as that would resolve easily the dependency tree,

mate-user-admin-1.7.0-1
group-service-1.4.0-1

When building from source and testing on a "installed" system it works just fine, but when testing on a "LiveISO" system, I always get:

There are few logs,

id
uid=999(ubuntu-mate) gid=999(ubuntu-mate) groups=999(ubuntu-mate),4(adm),24(cdrom),27(sudo),30(dip),46(plugdev),121(lpadmin),136(lxd),137(sambashare)

--

/tmp/mate-user-admin-$number.log
level:[Info]  message: mate-user-admin Version:1.7.0
level:[Error]  message: mate-user-admin No available users

--

Nov 18 11:19:50 ubuntu-mate dbus-daemon[1393]: Unknown group "power" in message bus configuration file
Nov 18 11:19:57 ubuntu-mate mate-user-admin[9407]: The selected user does not exist #015
Nov 18 11:19:57 ubuntu-mate kernel: [ 1174.970074] mate-user-admin[9407]: segfault at 30 ip 000055c552d4c068 sp 00007ffc41175f30 error 4 in mate-user-admin[55c552d45000+13000] likely on CPU 1 (core 0, socket 1)
Nov 18 11:19:57 ubuntu-mate kernel: [ 1174.970092] Code: 89 ee 48 89 c7 e8 28 c6 ff ff 48 89 c5 e8 70 ff ff ff 48 89 ef 48 89 c6 49 89 c4 e8 92 b2 ff ff 48 8b 4b 38 4c 89 e6 48 89 ef <48> 8b 50 30 48 8b 12 48 89 51 08 e8 78 b2 ff ff 48 8b 4b 38 4c 89

Only after creating a new user is that mate-user-admin actually opens so maybe some service is not running?
Or maybe on 22.04 the live user has some specific settings that won't allow it to be recognized.

I've tried ubuntu-mate 23.10 ISO and it works out of the box, I would imagine the newer versions would get along better than backported packages.

Any suggestion?

Build error with 1.4.0

I got an build error with building RPM from 1.4.0 tarball.

[14/15] cc -Isrc/25a6634@@mate-user-admin@exe -Isrc -I../src -I. -I../ -I/usr/include/gtk-3.0 -I/usr/include/pango-1.0 -I/usr/include/glib-2.0 -I/usr/lib64/glib-2.0/include -I/usr/include/fribidi -I/usr/include/harfbuzz -I/usr/include/freetype2 -I/usr/include/libpng16 -I/usr/include/uuid -I/usr/include/cairo -I/usr/include/pixman-1 -I/usr/include/gdk-pixbuf-2.0 -I/usr/include/libmount -I/usr/include/blkid -I/usr/include/gio-unix-2.0 -I/usr/include/libdrm -I/usr/include/atk-1.0 -I/usr/include/at-spi2-atk/2.0 -I/usr/include/at-spi-2.0 -I/usr/include/dbus-1.0 -I/usr/lib64/dbus-1.0/include -I/usr/include/accountsservice-1.0 -I/usr/include/group-service-1.0 -I/usr/include/mate-desktop-2.0 -I/usr/include/startup-notification-1.0 -I/usr/include/dconf -I/usr/include/polkit-1 -I/builddir/build/BUILD/user-admin-1.4.0/x86_64-redhat-linux-gnu -fdiagnostics-color=always -pipe -D_FILE_OFFSET_BITS=64 -std=gnu11 -DHAVE_CONFIG_H -fstack-protector-strong -g -Waggregate-return -Warray-bounds -Wcast-align -Wclobbered -Wdeclaration-after-statement -Wempty-body -Wextra -Wformat=2 -Wformat-nonliteral -Wformat-security -Wformat-signedness -Wignored-qualifiers -Wimplicit-function-declaration -Winit-self -Winline -Wmissing-declarations -Wmissing-format-attribute -Wmissing-include-dirs -Wmissing-noreturn -Wmissing-parameter-type -Wmissing-prototypes -Wnested-externs -Wno-discarded-qualifiers -Wno-missing-field-initializers -Wno-strict-aliasing -Wno-suggest-attribute=format -Wno-unused-parameter -Wold-style-definition -Woverride-init -Wpacked -Wpointer-arith -Wredundant-decls -Wreturn-type -Wshadow -Wsign-compare -Wstrict-aliasing -Wstrict-prototypes -Wswitch-default -Wtype-limits -Wundef -Wuninitialized -Wunused-but-set-variable -Wwrite-strings -O2 -g -Wall -Werror=format-security -Wp,-D_FORTIFY_SOURCE=2 -Wp,-D_GLIBCXX_ASSERTIONS -fexceptions -fstack-protector-strong -grecord-gcc-switches -specs=/usr/lib/rpm/redhat/redhat-hardened-cc1 -specs=/usr/lib/rpm/redhat/redhat-annobin-cc1 -m64 -mtune=generic -fasynchronous-unwind-tables -fstack-clash-protection -fcf-protection -pthread  -MD -MQ 'src/25a6634@@mate-user-admin@exe/user-group.c.o' -MF 'src/25a6634@@mate-user-admin@exe/user-group.c.o.d' -o 'src/25a6634@@mate-user-admin@exe/user-group.c.o' -c ../src/user-group.c
../src/user-group.c: In function 'CreateRemoveModel':
../src/user-group.c:576:13: warning: implicit declaration of function 'gas_group_is_primary_group'; did you mean 'gas_group_is_local_group'? [-Wimplicit-function-declaration]
  576 |         if(!gas_group_is_primary_group(group->gas) &&
      |             ^~~~~~~~~~~~~~~~~~~~~~~~~~
      |             gas_group_is_local_group
../src/user-group.c:576:13: warning: nested extern declaration of 'gas_group_is_primary_group' [-Wnested-externs]
[15/15] cc  -o src/mate-user-admin 'src/25a6634@@mate-user-admin@exe/main.c.o' 'src/25a6634@@mate-user-admin@exe/user-admin.c.o' 'src/25a6634@@mate-user-admin@exe/user-base.c.o' 'src/25a6634@@mate-user-admin@exe/user-face.c.o' 'src/25a6634@@mate-user-admin@exe/user-info.c.o' 'src/25a6634@@mate-user-admin@exe/user-list.c.o' 'src/25a6634@@mate-user-admin@exe/user-password.c.o' 'src/25a6634@@mate-user-admin@exe/user-share.c.o' 'src/25a6634@@mate-user-admin@exe/user-crop.c.o' 'src/25a6634@@mate-user-admin@exe/user-group.c.o' 'src/25a6634@@mate-user-admin@exe/user-history.c.o' 'src/25a6634@@mate-user-admin@exe/user-language.c.o' -Wl,--no-undefined -Wl,--as-needed -Wl,-z,relro -Wl,-z,now -O2 -g -pipe -Wall -Werror=format-security -Wp,-D_FORTIFY_SOURCE=2 -Wp,-D_GLIBCXX_ASSERTIONS -fexceptions -fstack-protector-strong -grecord-gcc-switches -specs=/usr/lib/rpm/redhat/redhat-hardened-cc1 -specs=/usr/lib/rpm/redhat/redhat-annobin-cc1 -m64 -mtune=generic -fasynchronous-unwind-tables -fstack-clash-protection -fcf-protection -Wl,-z,relro -Wl,--as-needed -Wl,-z,now -specs=/usr/lib/rpm/redhat/redhat-hardened-ld -Wl,--start-group /usr/lib64/libgtk-3.so /usr/lib64/libgdk-3.so /usr/lib64/libpangocairo-1.0.so /usr/lib64/libpango-1.0.so /usr/lib64/libatk-1.0.so /usr/lib64/libcairo-gobject.so /usr/lib64/libcairo.so /usr/lib64/libgdk_pixbuf-2.0.so /usr/lib64/libgio-2.0.so /usr/lib64/libgobject-2.0.so /usr/lib64/libglib-2.0.so /usr/lib64/libpwquality.so /usr/lib64/libaccountsservice.so /usr/lib64/libgroup-service.so -lcrypt /usr/lib64/libmate-desktop-2.so /usr/lib64/libstartup-notification-1.so /usr/lib64/libpolkit-gobject-1.so /usr/lib64/libfontconfig.so /usr/lib64/libfreetype.so -Wl,--end-group  
FAILED: src/mate-user-admin 
cc  -o src/mate-user-admin 'src/25a6634@@mate-user-admin@exe/main.c.o' 'src/25a6634@@mate-user-admin@exe/user-admin.c.o' 'src/25a6634@@mate-user-admin@exe/user-base.c.o' 'src/25a6634@@mate-user-admin@exe/user-face.c.o' 'src/25a6634@@mate-user-admin@exe/user-info.c.o' 'src/25a6634@@mate-user-admin@exe/user-list.c.o' 'src/25a6634@@mate-user-admin@exe/user-password.c.o' 'src/25a6634@@mate-user-admin@exe/user-share.c.o' 'src/25a6634@@mate-user-admin@exe/user-crop.c.o' 'src/25a6634@@mate-user-admin@exe/user-group.c.o' 'src/25a6634@@mate-user-admin@exe/user-history.c.o' 'src/25a6634@@mate-user-admin@exe/user-language.c.o' -Wl,--no-undefined -Wl,--as-needed -Wl,-z,relro -Wl,-z,now -O2 -g -pipe -Wall -Werror=format-security -Wp,-D_FORTIFY_SOURCE=2 -Wp,-D_GLIBCXX_ASSERTIONS -fexceptions -fstack-protector-strong -grecord-gcc-switches -specs=/usr/lib/rpm/redhat/redhat-hardened-cc1 -specs=/usr/lib/rpm/redhat/redhat-annobin-cc1 -m64 -mtune=generic -fasynchronous-unwind-tables -fstack-clash-protection -fcf-protection -Wl,-z,relro -Wl,--as-needed -Wl,-z,now -specs=/usr/lib/rpm/redhat/redhat-hardened-ld -Wl,--start-group /usr/lib64/libgtk-3.so /usr/lib64/libgdk-3.so /usr/lib64/libpangocairo-1.0.so /usr/lib64/libpango-1.0.so /usr/lib64/libatk-1.0.so /usr/lib64/libcairo-gobject.so /usr/lib64/libcairo.so /usr/lib64/libgdk_pixbuf-2.0.so /usr/lib64/libgio-2.0.so /usr/lib64/libgobject-2.0.so /usr/lib64/libglib-2.0.so /usr/lib64/libpwquality.so /usr/lib64/libaccountsservice.so /usr/lib64/libgroup-service.so -lcrypt /usr/lib64/libmate-desktop-2.so /usr/lib64/libstartup-notification-1.so /usr/lib64/libpolkit-gobject-1.so /usr/lib64/libfontconfig.so /usr/lib64/libfreetype.so -Wl,--end-group  
/usr/bin/ld: src/25a6634@@mate-user-admin@exe/user-group.c.o: in function `CreateRemoveModel':
/builddir/build/BUILD/user-admin-1.4.0/x86_64-redhat-linux-gnu/../src/user-group.c:576: undefined reference to `gas_group_is_primary_group'
collect2: error: ld returned 1 exit status
ninja: build stopped: subcommand failed.

full log is here https://www.dropbox.com/s/6vld4ymavyfq2g4/user-admin-build-log?dl=0
I used group-service-1.0.0 tarball as dependency
I didn't notice the issue if i compiled and installed both packages by hand from git master.
Do i need an updated group-service tarball?

weird uninstall warnings

With latest changes i get those warnings in terminal:

[rave@mother user-admin-test]$ sudo ninja -C build uninstall
ninja: Entering directory `build'
[0/1] /usr/bin/python3 /usr/bin/meson --internal uninstall
Deleted: /usr/share/mate-user-admin/face/flower2.jpg
Could not delete /usr/share/mate-user-admin/face/flower2.jpg: [Errno 2] No such file or directory: '/usr/share/mate-user-admin/face/flower2.jpg'.
Deleted: /usr/share/mate-user-admin/face/surfer.jpg
Could not delete /usr/share/mate-user-admin/face/surfer.jpg: [Errno 2] No such file or directory: '/usr/share/mate-user-admin/face/surfer.jpg'.
Deleted: /usr/share/mate-user-admin/face/tree.jpg
Could not delete /usr/share/mate-user-admin/face/tree.jpg: [Errno 2] No such file or directory: '/usr/share/mate-user-admin/face/tree.jpg'.
Deleted: /usr/share/mate-user-admin/face/hummingbird.jpg
Could not delete /usr/share/mate-user-admin/face/hummingbird.jpg: [Errno 2] No such file or directory: '/usr/share/mate-user-admin/face/hummingbird.jpg'.
Deleted: /usr/share/mate-user-admin/face/gamepad.jpg
Could not delete /usr/share/mate-user-admin/face/gamepad.jpg: [Errno 2] No such file or directory: '/usr/share/mate-user-admin/face/gamepad.jpg'.
Deleted: /usr/share/mate-user-admin/face/tomatoes.jpg
Could not delete /usr/share/mate-user-admin/face/tomatoes.jpg: [Errno 2] No such file or directory: '/usr/share/mate-user-admin/face/tomatoes.jpg'.
Deleted: /usr/share/mate-user-admin/face/bicycle.jpg
Could not delete /usr/share/mate-user-admin/face/bicycle.jpg: [Errno 2] No such file or directory: '/usr/share/mate-user-admin/face/bicycle.jpg'.
Deleted: /usr/share/mate-user-admin/face/guitar2.jpg
Could not delete /usr/share/mate-user-admin/face/guitar2.jpg: [Errno 2] No such file or directory: '/usr/share/mate-user-admin/face/guitar2.jpg'.
Deleted: /usr/share/mate-user-admin/face/coffee2.jpg
Could not delete /usr/share/mate-user-admin/face/coffee2.jpg: [Errno 2] No such file or directory: '/usr/share/mate-user-admin/face/coffee2.jpg'.
Deleted: /usr/share/mate-user-admin/face/calculator.jpg
Could not delete /usr/share/mate-user-admin/face/calculator.jpg: [Errno 2] No such file or directory: '/usr/share/mate-user-admin/face/calculator.jpg'.
Deleted: /usr/share/mate-user-admin/face/cat.jpg
Could not delete /usr/share/mate-user-admin/face/cat.jpg: [Errno 2] No such file or directory: '/usr/share/mate-user-admin/face/cat.jpg'.
Deleted: /usr/share/mate-user-admin/face/ic.jpg
Could not delete /usr/share/mate-user-admin/face/ic.jpg: [Errno 2] No such file or directory: '/usr/share/mate-user-admin/face/ic.jpg'.
Deleted: /usr/share/mate-user-admin/face/Default.png
Could not delete /usr/share/mate-user-admin/face/Default.png: [Errno 2] No such file or directory: '/usr/share/mate-user-admin/face/Default.png'.
Deleted: /usr/share/mate-user-admin/face/mountain.jpg
Could not delete /usr/share/mate-user-admin/face/mountain.jpg: [Errno 2] No such file or directory: '/usr/share/mate-user-admin/face/mountain.jpg'.
Deleted: /usr/share/mate-user-admin/face/plane.jpg
Could not delete /usr/share/mate-user-admin/face/plane.jpg: [Errno 2] No such file or directory: '/usr/share/mate-user-admin/face/plane.jpg'.
Deleted: /usr/share/mate-user-admin/face/headphones.jpg
Could not delete /usr/share/mate-user-admin/face/headphones.jpg: [Errno 2] No such file or directory: '/usr/share/mate-user-admin/face/headphones.jpg'.
Deleted: /usr/share/icons/hicolor/16x16/apps/user-admin.png
Could not delete /usr/share/icons/hicolor/16x16/apps/user-admin.png: [Errno 2] No such file or directory: '/usr/share/icons/hicolor/16x16/apps/user-admin.png'.
Deleted: /usr/share/icons/hicolor/24x24/apps/user-admin.png
Could not delete /usr/share/icons/hicolor/24x24/apps/user-admin.png: [Errno 2] No such file or directory: '/usr/share/icons/hicolor/24x24/apps/user-admin.png'.
Deleted: /usr/share/icons/hicolor/22x22/apps/user-admin.png
Could not delete /usr/share/icons/hicolor/22x22/apps/user-admin.png: [Errno 2] No such file or directory: '/usr/share/icons/hicolor/22x22/apps/user-admin.png'.
Deleted: /usr/share/icons/hicolor/48x48/apps/user-admin.png
Could not delete /usr/share/icons/hicolor/48x48/apps/user-admin.png: [Errno 2] No such file or directory: '/usr/share/icons/hicolor/48x48/apps/user-admin.png'.
Deleted: /usr/share/icons/hicolor/32x32/apps/user-admin.png
Could not delete /usr/share/icons/hicolor/32x32/apps/user-admin.png: [Errno 2] No such file or directory: '/usr/share/icons/hicolor/32x32/apps/user-admin.png'.
Deleted: /usr/share/mate-user-admin/icon/user-admin.png
Could not delete /usr/share/mate-user-admin/icon/user-admin.png: [Errno 2] No such file or directory: '/usr/share/mate-user-admin/icon/user-admin.png'.
Deleted: /usr/bin/user-admin
Deleted: /usr/share/applications/mate-user-admin.desktop
Deleted: /usr/share/mate-user-admin/icon
Deleted: /usr/share/mate-user-admin/face
Deleted: /usr/share/mate-user-admin

Uninstall finished.

Deleted: 27
Failed: 22

Remember that files created by custom scripts have not been removed.

Of cause uninstallation works fine an the dirs are empty.
Looks like that meson or ninja checks for a file which is already uninstalled.

Version update

@raveit65 Sorry to disturb you again. The user-admin version has been updated to 1.6.0. This update has a lot of changes. group-service has also been updated.

mate-user-admin Switch Bug

Expected behaviour
The automatic logon appears like a normal switch

Actual behaviour
The switch looks stretched and enlarged

Steps to reproduce the behaviour
run mate-user-admin

MATE general version
Mate 1.26.0

Package version
Can't find the way to find it.

Linux Distribution
Ubuntu Mate (Kinetic Kudu) 22.10

Do not add user to audio group in MATE User Manager

Hi, I experienced a very strange issue with audio sometimes not working after switching user sessions and it turns out this was due to the user being in the audio group as described by Pipewire developers: https://gitlab.freedesktop.org/pipewire/pipewire/-/issues/2107#note_1462133

If I'm understanding correctly, users should, in general, not be added to the audio group?

From the perspective of PipeWire/PulseAudio. Yes

Can you please ensure that when a new user is created in MATE User Manager, that the user is not added to the audio group? I just tested by creating a standard user and it was added to the audio group.

PID file is not deleted when leaving the application

Steps to reproduce
1- Launch the application
2- Exit the application
3- The file /tmp/mate-user-admin.pid still exists

Why is this a problem?
Because is you "swtich user", the other user won't be able to use the application as the PID file exists already and will be owned by another user.

user-admin does not install

../data/meson.build:30:5: ERROR: Function does not take positional arguments.

A full log can be found at /home/matheus/.cache/paru/clone/group-service/src/group-service-1.3.0/builddir/meson-logs/meson-log.txt
==> ERROR: A failure occurred in build().
Aborting...
error: failed to build 'group-service-1.3.0-1':
==> Making package: user-admin 1.6.0-1 (dom 06 fev 2022 19:31:26)
==> Retrieving sources...
-> Found 1.6.0.tar.gz
==> Validating source files with sha256sums...
1.6.0.tar.gz ... Passed
-==> Making package: user-admin 1.6.0-1 (dom 06 fev 2022 19:31:27)
==> Checking runtime dependencies...
==> Missing dependencies:
-> group-service
==> Checking buildtime dependencies...
==> ERROR: Could not resolve all dependencies.
error: failed to build 'user-admin-1.6.0-1':
error: packages failed to build: group-service-1.3.0-1 user-admin-1.6.0-1

unlock/lock icons are inverted.

The lock/unlock icons should show the current state. So in the 'unlock' button the icon must be the locked padlock (to show that it is currently locked) and then when unlocked, the 'lock' button should display the unlocked padlock.

Window title (and other little things).

Window title is currently 'Mate User Manage'. I think it's missing an 'r', like 'MATE User Manager', although it could also be just 'User Manager'.

I think also that it should use the 'system-users' icon - which is present in maybe all icon themes and so follows the look chosen for the desktop - both for the application icon and the desktop file.

Not working in Arch?

So I managed to install the AUR package, but I am unable to do stuff like automatic login for MATE when the same exact software works as expected in Ubuntu MATE.

How am I being dumb now, beyond expecting something for Ubuntu MATE to work for Arch?

Polkit authentication window is not translated

Polkit window is in english while user-admin is in french

Cannot build user-admin 1.5.0: build error in /src/user-admin.c:86:5 and vala 0.44.7+

I tried to update user admin PKGBUILD on AUR, but it crashes while building.

Error log:

../src/user-admin.c:86:5: error: 'ConfigGroups' undeclared (first use in this function); did you mean 'onfigGroups'?
   86 |     ConfigGroups = g_key_file_get_groups(Kconfig, &Length);
      |     ^~~~~~~~~~~~
      |     onfigGroups
../src/user-admin.c:86:5: note: each undeclared identifier is reported only once for each function it appears in
[6/15] Compiling C object 'src/25a6634@@mate-user-admin@exe/user-base.c.o'.
ninja: build stopped: subcommand failed.
==> ERROR: A failure occurred in build().
    Aborting...

Vala version:

fred@fredo-arch-mate ~ % valac --version
Vala 0.44.7

no languages with fedora 30

For some reason user-admin doesn't find any language in fedora 30.

Issue doensn't exists in fedora 29, so i assume that something with languages was changed with f30 or a needed package is missing.
How can i debug it?

Make desktop file 'desktop agnostic'.

mate-user-desktop can work fine for other DEs like Xfce and LXDE, so mate-user-admin.desktop can be more neutral. For example:

Change name to 'User Manager'.
Add XFCE and LXDE to OnlyShowIn key.

Below is a sample, with corrected Comment key (and with added pt_BR entries):

[Desktop Entry]
Name=User Manager
Name[pt_BR]=Gestor de Usuários
Name[ca]=Gestor d'usuaris
Name[zh_CN]=用户管理
Comment=Manage user accounts
Comment[pt_BR]=Gerenciar contas de usuários
Comment[ca]=Gestioneu els usuaris
Comment[zh_CN]=管理用户权限、语言、密码、登录名称、头像。
Categories=GTK;Settings;System;Utility;
Keywords=Configuration;Utility;
OnlyShowIn=MATE;XFCE;LXDE;
Exec=mate-user-admin
Icon=system-users
Terminal=false
Type=Application
X-Desktop-File-Install-Version=0.23

Note: icon name here is changed, I'll open another issue for this suggestion.

Characters with accents aren't displayed properly éèàçùî ...

(mate-user-admin:1986): Gtk-WARNING **: 20:28:30.434: Invalid input string

(mate-user-admin:1986): Gtk-WARNING **: 20:28:30.434: Invalid input string

(mate-user-admin:1986): Gtk-WARNING **: 20:28:30.436: Invalid input string

(mate-user-admin:1986): Gtk-WARNING **: 20:28:30.436: Failed to set text '<span foreground='black'weight='light'font_desc='12'>Veuillez s\xe9lectionner l'utilisateur \xe0 ajouter au nouveau groupe</span>' from markup due to error parsing markup: Erreur � la ligne 1, caract�re 125�: Codage UTF-8 non valide dans le nom ? ��Veuillez s\xe9lectionner l'utilisateur \xe0 ajouter au nouveau groupe�� n?est pas valide

(mate-user-admin:1986): Pango-WARNING **: 20:28:30.447: Invalid UTF-8 string passed to pango_layout_set_text()

(mate-user-admin:1986): Pango-WARNING **: 20:28:30.447: Invalid UTF-8 string passed to pango_layout_set_text()

Double authentication prompt for adding a new user

Launch mate-user-admin
Click on the Unlock button -> Authentication prompt
Type the password
Click on Add user
Fill in the form (login, user name, ...)
Click on confirm -> Authentication prompt -> NOT OK

This 2nd authentication prompt is not necessary since user was already asked for admin password to unlock the application in point 2 -> 3.
Also this is inconstant with the Remove user functionality:

Launch mate-user-admin
Click on the Unlock button -> Authentication prompt
Type the password
Select a user
Click on Remove user
Click yes on the confirmation message -> Not asked a 2nd time for authentication -> OK

Feature Request: Implement support for setting default groups

In my opinion, most end users which decide to utilize user-admin as a replacement for gnome-system-tools are likely to not be technically adept enough to know which specific groups should be set by default for a new user. Their usecase is likely centered around creating another "standard" user (without specified admin group(s)) or an administrative-type user (with the admin_group from group-service, most likely).

I'd like to request a compile-time configuration flag (either in this repo or group-service, I'm happy to file a request over there too) to set default groups in which new users should be set.

This would be especially useful since most end users are not likely to know what specific groups their own account has been set up with, for example on Solus you could expect groups such as:

audio
cdrom
fuse
lpadmin
plugdev
scanner
users
video

With the administrative account being in the sudo group. This could ideally be set with a flag such as -Ddefault_user_groups=audio,cdrom,fuse,etc... either in user-admin or group-service.

Global test feedback

First of all, I want to thank you for the great work. 👍
Here is my feedback, I hope it will help you making this app ever better !

The very first time I launched the application There was an error message to get the user language and indeed the language field in the GUI was blank (actually the language is always blank when I create a new user with adduer).
Whenever something is changed, the authentication window pops up. It would be more convenient imho to let the user set anything he wants and prompts for authentication when the user clicks on an "Apply" or "Save" button. Or better there should be an "Unlock" button in the title bar to make it consistent with what you have done for the groups.
The language list is way too long and unfortunately pressing a key doesn't jump to the languages starting with the letter corresponding to the key pressed (ie: F should jump to the first language starting with a F).
Or alternatively it would be great to only display the main languages and have a sub-menu with all the variants (i.e: English -> English (Canada), ..., English (Hong Kong), ..., English (Zimbabwe))
The login is not displayed (just the name). It would be nice to display it somewhere
When the group window is resized (height), it adds empty space below the "Close" button instead of expanding the group list (in the switch tab) although there is a scrollbar.

Default language problem

Hello. I've done a fresh install of the latest version of Mate, Version 22.10 (Kinetic Kudu) 64-bit. The default language is Spanish, and as a secondary I have added Catalan. My problem is that the user administration program has remained in Catalan and I am not able to change it. From preferences, personal, language support, I haven't been able to make it change, not even after uninstalling Catalan... It's not something really problematic, I'm bilingual, but it annoys me when something doesn't quite work. Clarify that it is the only program that has been "stuck" in Catalan. The rest is in Spanish.

Greetings.

Please synchronize translations before tagging next release

At least languages that are > 75% completion

https://www.transifex.com/mate/MATE/mate-user-admin/

[Feature Request] Manage groups

In the gnome-system-tools users-admin, there is a "manage groups" button which I haven't seen on the screenshots. I would be nice to have a similar feature.

Some systems have stricter regex for valid usernames

On Debian and Ubuntu, uppercase letters and the dot symbol '.' are not valid User Name characters. So in some cases the User Name will pass the check but user creation will still fail.

user-admin/src/user-admin.c

Lines 290 to 295 in 094986c

 if (! ((*c >= 'a' && *c <= 'z') || 

 (*c >= 'A' && *c <= 'Z') || 

 (*c >= '0' && *c <= '9') || 

 (*c == '_') || (*c == '.') || 

 (*c == '-' && c != UserName))) 

 valid = FALSE;

In Ubuntu 22.04 /etc/adduser.conf has #NAME_REGEX="^[a-z][-a-z0-9_]*\$"

mate-user-admin package for Debian and Ubuntu is needed

Thank you for this great application.

At present time it compiles normally on latest Ubuntu MATE 22.04 LTS by using below commands:

sudo apt-get install meson cmake pkg-config libgtk-3-dev libpwquality-dev libaccountsservice-dev libmate-desktop-dev git

cd ~/Downloads
git clone https://github.com/zhuyaliang/group-service
cd group-service/
meson build -Dprefix=/usr #meson build -Dprefix=/usr/local
ninja -C build
sudo ninja -C build install

cd ~/Downloads
git clone https://github.com/zhuyaliang/user-admin
cd user-admin/
meson build -Dprefix=/usr #meson build -Dprefix=/usr/local
ninja -C build
sudo ninja -C build install

It runs but does not have an icon in MATE Control Center, see

But it would be better if someone create special debian folder with all necessary files to ease package creation for Debian and Ubuntu. Thus two deb-packages (along with zhuyaliang/group-service#4) will exist and users will be happy to use your tool.

Change user language does not work

I changed my user language then I did log off and log in again, but it didn't make any difference, everything is still in English.

According to what I found on ArchLinux wiki, there should be a ~/.config/locale.conf file but I can't find it.

Edit a user, change the language (let's say french), apply the change.
Log off and log in with the user that was just edited, the session language is not in french
Check if ~/.config/locale.conf exists -> no
Check the language of the user in user-admin -> It's set to french.

Can't enable Auto-login

There is a crash report created on similar issue oin Fedora bugzilla: https://bugzilla.redhat.com/show_bug.cgi?id=2222441

The error is caused by crash of accounts service daemon

some warnings in terminal with 1.6.0

[rave@mother ~]$ LANG=C
[rave@mother ~]$ mate-user-admin 
(mate-user-admin:120575): GLib-GObject-WARNING **: 18:34:59.639: invalid unclassed pointer in cast to 'UserGroupWindow'
(mate-user-admin:120575): Gtk-CRITICAL **: 18:34:59.639: gtk_widget_set_sensitive: assertion 'GTK_IS_WIDGET (widget)' failed
(mate-user-admin:120575): Gtk-CRITICAL **: 18:34:59.639: gtk_widget_set_sensitive: assertion 'GTK_IS_WIDGET (widget)' failed
(mate-user-admin:120575): Gtk-CRITICAL **: 18:34:59.639: gtk_widget_set_sensitive: assertion 'GTK_IS_WIDGET (widget)' failed
(mate-user-admin:120575): Gtk-CRITICAL **: 18:34:59.639: gtk_widget_set_sensitive: assertion 'GTK_IS_WIDGET (widget)' failed
(mate-user-admin:120575): Gtk-CRITICAL **: 18:34:59.639: gtk_widget_set_sensitive: assertion 'GTK_IS_WIDGET (widget)' failed
(mate-user-admin:120575): Gtk-CRITICAL **: 18:34:59.639: gtk_widget_set_sensitive: assertion 'GTK_IS_WIDGET (widget)' failed
(mate-user-admin:120575): GLib-GObject-WARNING **: 18:34:59.639: invalid unclassed pointer in cast to 'GtkWidget'
(mate-user-admin:120575): Gtk-CRITICAL **: 18:34:59.639: gtk_widget_set_tooltip_markup: assertion 'GTK_IS_WIDGET (widget)' failed
(mate-user-admin:120575): GLib-GObject-WARNING **: 18:34:59.639: invalid unclassed pointer in cast to 'UserGroupWindow'
(mate-user-admin:120575): Gtk-CRITICAL **: 18:34:59.639: gtk_widget_set_sensitive: assertion 'GTK_IS_WIDGET (widget)' failed
(mate-user-admin:120575): Gtk-CRITICAL **: 18:34:59.639: gtk_widget_set_sensitive: assertion 'GTK_IS_WIDGET (widget)' failed
(mate-user-admin:120575): Gtk-CRITICAL **: 18:34:59.639: gtk_widget_set_sensitive: assertion 'GTK_IS_WIDGET (widget)' failed
(mate-user-admin:120575): Gtk-CRITICAL **: 18:34:59.639: gtk_widget_set_sensitive: assertion 'GTK_IS_WIDGET (widget)' failed
(mate-user-admin:120575): Gtk-CRITICAL **: 18:34:59.639: gtk_widget_set_sensitive: assertion 'GTK_IS_WIDGET (widget)' failed
(mate-user-admin:120575): Gtk-CRITICAL **: 18:34:59.639: gtk_widget_set_sensitive: assertion 'GTK_IS_WIDGET (widget)' failed
(mate-user-admin:120575): GLib-GObject-WARNING **: 18:34:59.639: invalid unclassed pointer in cast to 'GtkWidget'
(mate-user-admin:120575): Gtk-CRITICAL **: 18:34:59.639: gtk_widget_set_tooltip_markup: assertion 'GTK_IS_WIDGET (widget)' failed
(mate-user-admin:120575): GLib-GObject-WARNING **: 18:34:59.639: invalid unclassed pointer in cast to 'UserGroupWindow'
(mate-user-admin:120575): Gtk-CRITICAL **: 18:34:59.639: gtk_widget_set_sensitive: assertion 'GTK_IS_WIDGET (widget)' failed
(mate-user-admin:120575): Gtk-CRITICAL **: 18:34:59.639: gtk_widget_set_sensitive: assertion 'GTK_IS_WIDGET (widget)' failed
(mate-user-admin:120575): Gtk-CRITICAL **: 18:34:59.639: gtk_widget_set_sensitive: assertion 'GTK_IS_WIDGET (widget)' failed
(mate-user-admin:120575): Gtk-CRITICAL **: 18:34:59.639: gtk_widget_set_sensitive: assertion 'GTK_IS_WIDGET (widget)' failed
(mate-user-admin:120575): Gtk-CRITICAL **: 18:34:59.639: gtk_widget_set_sensitive: assertion 'GTK_IS_WIDGET (widget)' failed
(mate-user-admin:120575): Gtk-CRITICAL **: 18:34:59.639: gtk_widget_set_sensitive: assertion 'GTK_IS_WIDGET (widget)' failed
(mate-user-admin:120575): GLib-GObject-WARNING **: 18:34:59.639: invalid unclassed pointer in cast to 'GtkWidget'
(mate-user-admin:120575): Gtk-CRITICAL **: 18:34:59.639: gtk_widget_set_tooltip_markup: assertion 'GTK_IS_WIDGET (widget)' failed

Steps to reproduce:

start mate-user-admin from terminal
unlock dialog
open group-dialog
look in all tabs of group-dialog (not sure it this is needed for reproducing)
close group-dialog
lock mate-user-admin dialog
Wondering about warnings in terminal :)

I don't know if this is an new or an already existing issue. I stumbled about during testing new release.
Any way, i will update all fedora branches with new releases.

Problems with loading user lists

Loading the user list is an async call.
Calling act_user_manager_list_users directly after act_user_manager_get_default may be wrong

This patch fix this problem
fix-usrlist-is-empty.patch.gz

build failure with gcc10

User-admin failed to build during fedora rawhide (32) mass rebuild because of new gcc 10.
https://koji.fedoraproject.org/koji/taskinfo?taskID=41318895
https://koji.fedoraproject.org/koji/getfile?taskID=41320529&volume=DEFAULT&name=build.log&offset=-4000

o:/builddir/build/BUILD/user-admin-1.5.1/x86_64-redhat-linux-gnu/../src/user.h:131: multiple definition of `gnCurrentUserIndex'; src/25a6634@@mate-user-admin@exe/main.c.o:/builddir/build/BUILD/user-admin-1.5.1/x86_64-redhat-linux-gnu/../src/user.h:131: first defined here
/usr/bin/ld: src/25a6634@@mate-user-admin@exe/user-group.c.o:/builddir/build/BUILD/user-admin-1.5.1/x86_64-redhat-linux-gnu/../src/user.h:132: multiple definition of `WindowLogin'; src/25a6634@@mate-user-admin@exe/main.c.o:/builddir/build/BUILD/user-admin-1.5.1/x86_64-redhat-linux-gnu/../src/user.h:132: first defined here
/usr/bin/ld: src/25a6634@@mate-user-admin@exe/user-group.c.o:/builddir/build/BUILD/user-admin-1.5.1/x86_64-redhat-linux-gnu/../src/user.h:131: multiple definition of `gnCurrentUserIndex'; src/25a6634@@mate-user-admin@exe/main.c.o:/builddir/build/BUILD/user-admin-1.5.1/x86_64-redhat-linux-gnu/../src/user.h:131: first defined here
/usr/bin/ld: src/25a6634@@mate-user-admin@exe/user-group.c.o:/builddir/build/BUILD/user-admin-1.5.1/x86_64-redhat-linux-gnu/../src/user-share.h:30: multiple definition of `Change'; src/25a6634@@mate-user-admin@exe/main.c.o:/builddir/build/BUILD/user-admin-1.5.1/x86_64-redhat-linux-gnu/../src/user-share.h:30: first defined here
/usr/bin/ld: src/25a6634@@mate-user-admin@exe/user-history.c.o:/builddir/build/BUILD/user-admin-1.5.1/x86_64-redhat-linux-gnu/../src/user.h:131: multiple definition of `gnCurrentUserIndex'; src/25a6634@@mate-user-admin@exe/main.c.o:/builddir/build/BUILD/user-admin-1.5.1/x86_64-redhat-linux-gnu/../src/user.h:131: first defined here
/usr/bin/ld: src/25a6634@@mate-user-admin@exe/user-history.c.o:/builddir/build/BUILD/user-admin-1.5.1/x86_64-redhat-linux-gnu/../src/user-share.h:30: multiple definition of `Change'; src/25a6634@@mate-user-admin@exe/main.c.o:/builddir/build/BUILD/user-admin-1.5.1/x86_64-redhat-linux-gnu/../src/user-share.h:30: first defined here
/usr/bin/ld: src/25a6634@@mate-user-admin@exe/user-history.c.o:/builddir/build/BUILD/user-admin-1.5.1/x86_64-redhat-linux-gnu/../src/user.h:132: multiple definition of `WindowLogin'; src/25a6634@@mate-user-admin@exe/main.c.o:/builddir/build/BUILD/user-admin-1.5.1/x86_64-redhat-linux-gnu/../src/user.h:132: first defined here
/usr/bin/ld: src/25a6634@@mate-user-admin@exe/user-language.c.o:/builddir/build/BUILD/user-admin-1.5.1/x86_64-redhat-linux-gnu/../src/user-share.h:30: multiple definition of `Change'; src/25a6634@@mate-user-admin@exe/main.c.o:/builddir/build/BUILD/user-admin-1.5.1/x86_64-redhat-linux-gnu/../src/user-share.h:30: first defined here
/usr/bin/ld: src/25a6634@@mate-user-admin@exe/user-language.c.o:/builddir/build/BUILD/user-admin-1.5.1/x86_64-redhat-linux-gnu/../src/user.h:132: multiple definition of `WindowLogin'; src/25a6634@@mate-user-admin@exe/main.c.o:/builddir/build/BUILD/user-admin-1.5.1/x86_64-redhat-linux-gnu/../src/user.h:132: first defined here
/usr/bin/ld: src/25a6634@@mate-user-admin@exe/user-language.c.o:/builddir/build/BUILD/user-admin-1.5.1/x86_64-redhat-linux-gnu/../src/user.h:131: multiple definition of `gnCurrentUserIndex'; src/25a6634@@mate-user-admin@exe/main.c.o:/builddir/build/BUILD/user-admin-1.5.1/x86_64-redhat-linux-gnu/../src/user.h:131: first defined here
collect2: error: ld returned 1 exit status
ninja: build stopped: subcommand failed.
RPM build errors:
error: Bad exit status from /var/tmp/rpm-tmp.rzVVFT (%build)
    Bad exit status from /var/tmp/rpm-tmp.rzVVFT (%build)
Child return code was: 1
EXCEPTION: [Error()]
Traceback (most recent call last):
  File "/usr/lib/python3.7/site-packages/mockbuild/trace_decorator.py", line 95, in trace
    result = func(*args, **kw)
  File "/usr/lib/python3.7/site-packages/mockbuild/util.py", line 746, in do_with_status
    raise exception.Error("Command failed: \n # %s\n%s" % (command, output), child.returncode)
mockbuild.exception.Error: Command failed: 
 # bash --login -c /usr/bin/rpmbuild -bb --target x86_64 --nodeps /builddir/build/SPECS/mate-user-admin.spec

More infos you will find here
https://gcc.gnu.org/gcc-10/porting_to.html#common

PS: I hope everything is fine with you and your family in your country.

user picture

When a user changes his picture via the "About me" application, it's saved in ~/.face this picture is then used in different places like on the lock screen for example.

When I change the picture from "MATE User Manager", it is saved somewhere else ~/.face is unchanged and this updated picture is visible only in "MATE User Manager" and nowhere else !?

Changing user locale does not work

I changed the language from a second user (let's call it user2) from English (United States) to French (Belgium) then I did switch to user2 and everything is still in english instead of french.

If I type locale in a terminal everything is still in en_US.UTF-8 while I expected fr_BE.UFT8

user2@testbox ~ $ locale
LANG=en_US.UTF-8
LC_CTYPE="en_US.UTF-8"
LC_NUMERIC="en_US.UTF-8"
LC_TIME="en_US.UTF-8"
LC_COLLATE="en_US.UTF-8"
LC_MONETARY="en_US.UTF-8"
LC_MESSAGES="en_US.UTF-8"
LC_PAPER="en_US.UTF-8"
LC_NAME="en_US.UTF-8"
LC_ADDRESS="en_US.UTF-8"
LC_TELEPHONE="en_US.UTF-8"
LC_MEASUREMENT="en_US.UTF-8"
LC_IDENTIFICATION="en_US.UTF-8"
LC_ALL=

group dialog suggestions

First i wanna say that you did a great job again.
I found some small issues.

when i had create a new group, the new group isn't visible in switch-groups tab.
I need to close/reopen the group-dialow window to see the new group in switch-groups tab.
see

For what is the return button good?
Clicking the button gives me a segfault.

[rave@mother ~]$ mate-user-admin 
Segmentation fault (core dumped)

A suggestions/feature request
Can we have a dialog window with normal window decoration?
Or a gsettings key to switch between headerbar and metacity decoration?
You only need to move the unlock button from headerbar.

Whether the camera extraction function can be added to the selection of user's Avatar

When local users change their avatars, the camera function is added.

	if (! ((c >= 'a' && c <= 'z') \|\|
	(c >= 'A' && c <= 'Z') \|\|
	(c >= '0' && c <= '9') \|\|
	(c == '_') \|\| (c == '.') \|\|
	(*c == '-' && c != UserName)))
	valid = FALSE;