weird uninstall warnings about user-admin HOT 21 CLOSED

@raveit65
I found this to be a problem with the “Ninja” tool. I tested several other projects and found that this problem occurs when you install a directory. If you install a single file, it doesn't occur. I changed the way I install it, and it's okay to uninstall now.

from user-admin.

Cool, good to know that ninja specific peculiarity.

I am happy to test your first release if a download is available at github.
I'd like to include it to fedora linux distro.

PS: you don't need to copy images with code snippets here in github posts.
Choose to edit my first post here and see how i did format (html) the terminal output ;)

from user-admin.

Choose to edit my first port here and see how i did format (html) the terminal output ;)

Thank you for reminding me.
I launched the 1.0.0 version.

from user-admin.

@raveit65
What is the result of the 1.0.0 version test? Did you find any problems?

from user-admin.

Installing the 1.0.0 by hand works fine.
Now i just started to create a mate-user-admin.spec file for creating a RPM for fedora.
During RPM building i got a few minimal warnings.

*** WARNING: ./usr/src/debug/mate-user-admin-1.0.0-1.fc28.x86_64/src/main.c is executable but has empty or no shebang, removing executable bit

The execute bit should be remove.
And i use desktop-file-install command in spec file during the build process of the RPM.

desktop-file-install                               \
  --delete-original                                \
  --dir $RPM_BUILD_ROOT%{_datadir}/applications    \
$RPM_BUILD_ROOT%{_datadir}/applications/mate-user-admin.desktop

This command gives me this warning.

+ desktop-file-install --delete-original --dir /home/rave/rpmbuild/BUILDROOT/mate-user-admin-1.0.0-1.fc28.x86_64/usr/share/applications /home/rave/rpmbuild/BUILDROOT/mate-user-admin-1.0.0-1.fc28.x86_64/usr/share/applications/mate-user-admin.desktop
/home/rave/rpmbuild/BUILDROOT/mate-user-admin-1.0.0-1.fc28.x86_64/usr/share/applications/mate-user-admin.desktop: warning: value "????" for key "Comment[zh_CN]" in group "Desktop Entry" looks redundant with value "????" of key "Name[zh_CN]"

But i don't understand what's wrong here :)

Btw. Maybe you like to rename /usr/bin/user-admin to /usr/bin/mate-user-admin ?
I result naming is consistent.

And i will use mate-user-admin for fedora as package/project name if you agree.

from user-admin.

When i build the rpm with mock (fedora server build tool) i get a minimal compiler warning.

[2/10] cc -Isrc/src@@user-admin@exe -Isrc -I../src -I. -I../ -I/usr/include/gtk-3.0 -I/usr/include/pango-1.0 -I/usr/include/glib-2.0 -I/usr/lib64/glib-2.0/include -I/usr/include/fribidi -I/usr/include/cairo -I/usr/include/pixman-1 -I/usr/include/freetype2 -I/usr/include/libpng16 -I/usr/include/uuid -I/usr/include/harfbuzz -I/usr/include/gdk-pixbuf-2.0 -I/usr/include/gio-unix-2.0/ -I/usr/include/libdrm -I/usr/include/atk-1.0 -I/usr/include/at-spi2-atk/2.0 -I/usr/include/at-spi-2.0 -I/usr/include/dbus-1.0 -I/usr/lib64/dbus-1.0/include -I/usr/include/accountsservice-1.0 -I/usr/include/mate-desktop-2.0 -I/usr/include/startup-notification-1.0 -I/usr/include/dconf -I/builddir/build/BUILD/mate-user-admin-1.0.0/x86_64-redhat-linux-gnu -fdiagnostics-color=always -pipe -D_FILE_OFFSET_BITS=64 -std=gnu11 -DHAVE_CONFIG_H -fstack-protector-strong -Waggregate-return -Warray-bounds -Wcast-align -Wclobbered -Wdeclaration-after-statement -Wempty-body -Wextra -Wformat=2 -Wformat-nonliteral -Wformat-security -Wformat-signedness -Wignored-qualifiers -Wimplicit-function-declaration -Winit-self -Winline -Wmissing-declarations -Wmissing-format-attribute -Wmissing-include-dirs -Wmissing-noreturn -Wmissing-parameter-type -Wmissing-prototypes -Wnested-externs -Wno-discarded-qualifiers -Wno-missing-field-initializers -Wno-strict-aliasing -Wno-suggest-attribute=format -Wno-unused-parameter -Wold-style-definition -Woverride-init -Wpacked -Wpointer-arith -Wredundant-decls -Wreturn-type -Wshadow -Wsign-compare -Wstrict-aliasing -Wstrict-prototypes -Wswitch-default -Wtype-limits -Wundef -Wuninitialized -Wunused-but-set-variable -Wwrite-strings -O2 -g -Wall -Werror=format-security -Wp,-D_FORTIFY_SOURCE=2 -Wp,-D_GLIBCXX_ASSERTIONS -fexceptions -fstack-protector-strong -grecord-gcc-switches -specs=/usr/lib/rpm/redhat/redhat-hardened-cc1 -specs=/usr/lib/rpm/redhat/redhat-annobin-cc1 -m64 -mtune=generic -fasynchronous-unwind-tables -fstack-clash-protection -fcf-protection -pthread  -MD -MQ 'src/src@@user-admin@exe/main.c.o' -MF 'src/src@@user-admin@exe/main.c.o.d' -o 'src/src@@user-admin@exe/main.c.o' -c ../src/main.c
../src/main.c: In function 'RecordPid':
../src/main.c:90:5: warning: ignoring return value of 'write', declared with attribute warn_unused_result [-Wunused-result]
     write(fd,WriteBuf,strlen(WriteBuf));
     ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

Beside from that the package doesn't generate any other build warning :)
Good work....

from user-admin.

And what do you think about to add a COPYING file with a licence?
See https://www.gnu.org/licenses/licenses.en.html
or
https://www.gnu.org/licenses/licenses.zh-cn.html

from user-admin.

@raveit65
I launched the 1.0.1 version.I added the license and removed the compile warning.Rename "user-admin" to "mate-user-admin"

And i will use mate-user-admin for fedora as package/project name if you agree.

Yes I agree with you.
`

from user-admin.

I added new language API from mate-desktop to fedora builds, in result i can start in a week with a review request for user-admin in fedora.
https://src.fedoraproject.org/cgit/rpms/mate-desktop.git/commit/?h=f28
Edit:
Btw. I will do a pull request for german translation first :)

from user-admin.

Btw. i tested auto-login with gdm desktop-manager. It works like a charm with gdm.

from user-admin.

@raveit65
I added automatic login patches to lightdm, but they didn't accept it. You can take a look
https://gitlab.freedesktop.org/accountsservice/accountsservice/issues/52

from user-admin.

So, they want to make their own implementation,.....good.

from user-admin.

@raveit65
When user-admin is available in "Fedora", please tell me, I will test.

from user-admin.

yeah, i will do.
Can you tag a new release with latest changes please?
Than i can submit a review request for fedora.

from user-admin.

@raveit65
The 1.1.0 version is ready.

from user-admin.

All done, mate-user-admin is available for fedora-rawhide.
An will be in updates-testing repo available for f29/f28/27 in 1 or 2 days.
https://bodhi.fedoraproject.org/updates/FEDORA-2018-595262b52d
https://bodhi.fedoraproject.org/updates/FEDORA-2018-b573289c5b
https://bodhi.fedoraproject.org/updates/FEDORA-2018-2b89b81349
Thanks again for making it possible.

from user-admin.

user-admin is now available in all fedora stable branches.

from user-admin.

I missed the 1.2.1 release, but i am just building it for fedora.
Maybe you can ping me next time if you make a new release, please?

from user-admin.

@raveit65 Okay, I'll let you know when I update next. If group-service is OK, I'm going to add group management in the next versio。

from user-admin.

@raveit65 @yetist
User admin I added two new function。

• group manager
• View login history

Group management requires group-service installation.
https://github.com/zhuyaliang/group-service
Please let me know if there are any problems or suggestions during the test.

from user-admin.

Works nice, i will open a new report for sugestions.

from user-admin.