yuhui / launchext-youtube-playback Goto Github PK

• Enable YouTube IFrame API on YouTube players with enablejsapi and origin parameters.
• Work with all of YouTube IFrame API's public events: Player Ready, Player State Changed, Playback Rate Changed, Playback Quality Changed, Player Error.
• Allow user to specify selector for selecting YouTube players to track.

Describe the solution you'd like
Allow "Video Playing" event to be tracked as video started, resumed or replayed.

Describe the bug
On IE11, the extension is not able to setup the players for the (iframe) elements, as an error is thrown: TypeError: Object doesn't support property or method 'forEach'

This is due to the nodeList type does nnot have a forEach method on IE.

To Reproduce
Use the extension on IE11

Expected behavior
It should work on IE11.

Desktop (please complete the following information):

• OS: Windows
• Browser: Internet Explorer
• Version: 11.1139.18362.0

Hi,

Great Launch extension (swoon)!

I have an issue though in that many of our site's YouTube videos have dynamically loaded iframe src attribute and the video plays tracking is failing due to this YouTube constructor issue mentioned here:
https://stackoverflow.com/a/47415537

I was wondering if you could update the extension to fail more gracefully in this case? e.g. as suggested in the Stack Overflow, set it to 0 or something when player.getCurrentTime() is undefined?

Thanks in advance,
Julia

Describe the bug
A clear and concise description of what the bug is.

To Reproduce
Steps to reproduce the behavior:

1. Go to 'site and drag video from start to 25%, 50% or 75% completion'
2. Check if the video milestone is tracked or not.

Expected behavior
A clear and concise description of what you expected to happen.

Screenshots
If applicable, add screenshots to help explain your problem.

Desktop (please complete the following information):

• OS: [e.g. Windows]
• Browser [e.g. Chrome, Safari]
• Version [e.g. 22]

Smartphone (please complete the following information):

• Device: [e.g. iPhone6]
• OS: [e.g. iOS8.1]
• Browser [e.g. stock browser, Safari]
• Version [e.g. 22]

Additional context
Add any other context about the problem here.

I am getting this error when triggering the rules of YouTube video play, pause, milestones and stop events
Uncaught TypeError: e.getCurrentTime is not a function
How to resolve this issue?

Describe the solution you'd like
Allow for milestone tracking based on seconds or percentages of video, at regular intervals or fixed thresholds.

Describe the bug
If the user is on a slow network connection, the YouTube IFrame may not be enabled properly on players.

To Reproduce
Steps to reproduce the behavior:

1. Throttle the browser network to simulate a slow network, e.g. "Slow 3G".
2. Track playback.

Expected behavior
Playback tracking should happen reliably all of the time.

Describe the bug
When an iframe is constructed, added and removed from the page dynamically, it seems to create a loop with triggering milestone events. This seems to happen if the action is performed quickly.

To Reproduce
Steps to reproduce the behavior:

1. Using launch, setup a custom event rule to check for the existence of the iframe added to the page, then trigger() once one is found.
2. Setup an action inside this rule using this extension to Enable video playback tracking with any player selected and Load Youtube Iframe API checked.

Here is an example of adding a video dynamically: https://codepen.io/l-triple-o/pen/podPQYN.

Expected behavior
Opening and closing the video does not continue to trigger Video Milestone event from extension.

Desktop

• OS: MAC
• Browser : Chrome
• Version : Latest