Giter Club home page Giter Club logo

Comments (4)

yuhui avatar yuhui commented on June 24, 2024

@L-Triple-O just to be clear, are you saying that when the same video is added-and-removed from a web page constantly, then each time during playback, the milestones get tracked? i.e.

Page loads
Add video to page
Play video
Milestone 1 reached --> track
Milestone 2 reached --> track
Remove video from page
Add the same video back to the page
Play video
Milestone 1 reached --> track
Milestone 2 reached --> track
Remove video from page
etc...

from launchext-youtube-playback.

L-Triple-O avatar L-Triple-O commented on June 24, 2024

Hi @yuhui ,
No. I'd actually expect what you've described.
What I'm seeing is the video being removed, but the milestones are still being tracked when there isn't an iframe video on the page anymore. I've updated your explanation a little. This also happens after a few times of adding/removing the video.
ex: It works on the 1st time but not the 5th.

Page loads
Click play button
Add iframe video to page
Video autoplays
Milestone 1 reached --> track
Milestone 2 reached --> track
Remove video from page( iframe removed.)
Click play button.
Add the same video iframe back to the page
Video autoplays
Milestone 1 reached --> track
Milestone 2 reached --> track
Remove video from page (iframe removed)
Milestone 2 continues in a loop, being fired and still tracking over and over.

from launchext-youtube-playback.

yuhui avatar yuhui commented on June 24, 2024

@L-Triple-O alright, I understand the problem now. Currently, my extension doesn't handle unloading of videos. So when that action occurs, the tracking setup still persists, resulting in the loop that you're experiencing. I'll have to update my extension to handle video unloading. In the meantime, unfortunately, I don't believe there is a workaround aside from forcing a page reload when unloading videos (which might not be desirable for you).

from launchext-youtube-playback.

L-Triple-O avatar L-Triple-O commented on June 24, 2024

@yuhui thanks for noting the issue and the insight on no real workaround for it. You're right, forcing a page reload isn't really an option. It's a great extension and I hope with this update we can move back to using it!

from launchext-youtube-playback.

Related Issues (12)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.