yjack0000 / document-center-be Goto Github PK

1. The pass and reject api should not be a post. I can literally just change the status into "asdasd" with the request.
   
2. @yui0303 found numerous bugs in the api.

可以幫我改成先 scan 在 test 嗎～
如果可以了話麻煩看一下 snyk 是不是會在有太嚴重的 dependency 問題時中斷 CI，不然無限放過也蠻怪的。
還有 test 和 scan 的結果最好能存起來，像是作業那樣。

swagger docs use input as Bearer

But we use cookie like this in cookie

So Bearer is fake, if you want to log in jus need to manally call /api/auth/github

And also, we are missing logout functionality that mention in #7

I think the reason is server misunderstand al as uuid and try to parse or validate it. Maybe just send and error for it instead of let it be an unhandled error.

• Error Test Cases

  1. Auth
  2. Review
  3. Document

• Problem Snapshot

• Have tried but not work
  Example:
  1. from 'src/helper/helper.service';
     Change to relative path '../helper/helper.service';
  2. Or add following snippet in tsconfig.ts

"paths": {
 "src/*": [
 "src/*"
 ]
 }

• Preliminary hypothesis: jest's problem

1. User Name Undefined. Might caused by parser
2. Fetching superuser data with cookie on local got error (unauthorized)

I have multiple documents but got total = 1

• Deleted Document won't appear in review
• [ ] But while assign an deleted document to user, it will still complete the transfer event and send mail to reviewer.

Curl did not carry the cookie when http/https request in default. But still can fetch the data.

Reproduce

1. Direct use curl in terminal
2. Test the following api

/api/users : Can get the users directly
/api/documents/me: {"statusCode":500,"message":"Internal server error"}. Perhaps server got the empty user
/api/comments: {"data":[],"page":1,"limit":10,"total":0}

Not rushing, but the position of the Minio is running into business logic.

In frontend we have to block the normal user from accessing superuser's page. Therefore, in the middleware we might need and api to check user's privilege on the system.

@grace0950 @CTHua How do you guys think?

Should append review log instead of overwrite it.

In order to enhance the usability and clarity of our frontend display, it is proposed that all APIs currently returning a userId should be modified to return a nested object containing both userId and username. This change will facilitate better integration and usability on the frontend by providing more context to the user data being displayed.

Can ref from #6

It seems the parser has some problem. Need to handle the First name or the Last name is/are empty.

Btw, should we handle the order of the chinese name?

@grace0950 @CTHua @yui0303 For the sake of development convenience, the cookies are currently accessible on the client side. Please change them to httpOnly going forward. Additionally, if we need to handle cookies in future development, we can set up a proxy in next.js.

Reference: Rewriting to an external URL

There are more detailed explain:

owner should be

"owner": {
    "id": "aaaa",
     "name": "aaaa"
}

user also should be

"user": {
    "id": "aaaa",
     "name": "aaaa"
}

Get /api/reviews/{documentId}should sorted by updated time

It seems the parser has some problem. Need to handle the First name or the Last name is/are empty.

Btw, should we handle the order of the chinese name?

Deleting the document occurs errror when status of the document is review.
BTW, there is no error if the documents are edit. (I forgot the senario of the pass. I think it is well.)

This is the log from the Argo