Hi,

I'm using Laravel 5.8, Nova 2.0 and already in the dev-laravel-5.8 branch.

In my ProductSet model, there is a hasMany relation to ProductPrices. It works fine when loading all the prices, however when I save I get an error below:

No query results for model [App\Models\ProductSet]

I've been working on implementing this in a new project I'm working on and so far it's been great! However, I'm running in an issue when trying to add a nested form which uses a BelongsTo field.

The specific error I'm getting is happening happening within the index function of laravel/nova/src/Http/Controllers/AssociatableController.php, specifically at line 23. As far as I can tell, the $field variable is returning null because the Nova isn't able to find the resource.

I've been digging around a bit and I believe the issue is being cause by an incorrectly formatted API call to the /nova-api/RESOURCE/associatable endpoint. When I load the resource through a nested form, it tries to call the API at /nova-api/admission-referral-informations/associatable/nested:referralInformation[county] (which throws a 500 error), but when I load the resource as a standard Nova relationship field, it calls the API at /nova-api/admission-referral-informations/associatable/county (which works).

So basically the nested form uses nested:referralInformation[county] in the URL, when it should actually just be using county. I'll keep digging around to see if I can fix it on my own, but please let me know if you have a better idea of what's going on/if you need more info.

Thanks!

Hi, first of all great package! I was wondering is there a posibility for nesting a second time? like
NestedForm::make('Posts.Tags'), and the tags to appear below each post?

Cheers

When the model is updated in the same request as it is created, for example when using Events and having queue_driver = sync.

This comes from the fact that fillAttributeFromRequest is ran more than twice. (First time aattaching a ::saved event, second after the model is savedand thereforeremoveUntouched` is also ran twice.

You can replicate this by attaching the following code to a model used in a nestedform:

    protected static function boot()
    {
        parent::boot();
        static::saved(function($model) {
            $model->update(['created_at' => now()]);
        });
    }

After install the package, I have problems with add the NestedFormTrait to App\Nova\Resource class.

When a the form has invalid data I see in the console that errors have been returned.
Errors on the regular fields are shown but the errors on the NestedForms aren't shown.

I'm running Nova v1.3.2 and Nova Nested Form v2.0.2

Hello,
I use your package to manage accounts and companies (so I'm able to create a company from a account and link the company to the account). Since I've upgraded to laravel 5.8, I experience this error :

Method Illuminate\Database\Query\Builder::getData does not exist.

when adding a new company (the nested form) to the account (the ressource).

I've got a notes model that uses MorphMany so I can add notes to multiple resources. In Nova I've hidden the notes resource from the sidebar (because it doesn't make sense to make a note without going to the resource you intend to make a note for), so all note management is done via MorphMany fields.

When attempting to create a new resource (for example, details of an item we've purchased), I can't add a note to the resource using the NestedForm field, because:

errors: {notes[notable_type]: ["The notable type field is required."]} (notable being the morphTo relation in my model, so notable_type would be something like App\PurchasedItem). If I remove the note, I can save the new asset just fine.

If I create a new note using Laravel's MorphMany field (that is, view the details of a PurchasedItem, click the button to create a note, and add one), the note adds fine, but I can't edit the resource. Trying to do so gives me this toast error:

Call to member function buildMorphableQuery() on null

Any clues regarding this?

Morning mate,
as for this one
I'm not able to see the validation error messages when I try to create the model without respecting the rules.

Resource:
NestedForm::make('HasManyRelation')->rules('required', 'min:1')->open(true)

Error in console:
{"message":"The given data was invalid.","errors":{"hasmanyrelation":["The hasmanyrelation field is required."]}}

The foreign key value is not setup on save new item or on update(add new item), i have tested with HasMany Nova field, but it's not working with NetstedForm field
Resource

Model

Error on save / update

To improve usability. My users are very difficult to press the extra buttons.

Hello,

First of all nice package!
I was wondering if conditional nested forms will be implemented soon? It's something that I really need because I have a model (Animal Status) with a morphTo relationship (to Reserved, Adopted etc.) and it would be nice if the user could select and create the morphTo relation inside the Animal Status resource.

First of all kudos to you for this plugin, it definitely does the work and helped me a lot! 🎉

While making some tests I noticed that when I delete a Model from the index its children aren't deleted as well.
I was thinking about adding a method to actually "bind" the children to the parent model and create a weak relation.

E.g. NestedForm::make('Children')->weakRealtion()

Doing so would allow us to delete all the children of a model upon deletion

What you think about this @yassipad ?

I have the following user story:

A member can have zero or many memberships. When creating a new member 99% of the time they will only ever get assigned one membership.

It would be amazing if for a nested form field:

• We could choose expanded or collapsed by default
• We could choose the number of rows to display
• Minimum number of rows allowed
• Max number of rows allowed
• Disable the add more button (globally or also if we hit the maximum number of rows after clicking add)
• If the number of rows is restricted (e.g. shows 1 and always only 1 row) but isn't filled in it is ignored when creating the model. (Would be useful if you want to add it later but don't want to make the user click delete button)

If you collapse a row and there are validation errors there is not a useful message to the user.

When the nested form has an Image field, although we can see the field and select an image, it doesn't get uploaded nor the file path saved into the database.

Any ideas?

Hi , I am getting the message:
"Call to undefined method Illuminate\Database\Eloquent\Relations\BelongsTo::getForeignKey()"

this happens after updating to nova 2.0 .

this my code :

use Yassi\NestedForm\NestedForm;

NestedForm::make('All Prices', 'prices', ServicesPrices::class)
                ->min(1)
                ->open(true)
                ->heading('price for : {{index}} - {{price}} $')
                ->separator('-'),

any advice ?

I have email validation on the parent. If I click create and get validation areas on the nested form then when I click create again it will fail to say the email address is taken. We should check all validation errors before creating

I have a nested form on Member that creates a Membership. If I create a membership directly and set the BelongTo to a Member the dropdown takes a while to load. If I remove the nested form it loads instantly. I attached a video to show you what I mean

https://www.dropbox.com/s/fr5b43eovh06whv/Untitled2.mov?dl=0

I want to delete some row, but always delete last row instead. Look at my ss below (before delete)

This is ss after delete,,

I have something similar to this setup with a Customer, Account, and User resources.

Customer:

// ...
 NestedForm::make('Accounts')
                ->hideWhenUpdating()
                ->open(true)
                ->heading('{{index}} Account')
// ... 

Account:

// ...
NestedForm::make('Users')
                ->hideWhenUpdating()
                ->heading('{{index}} User')
// ...

Customer is a oneToMany relationship with Accounts and Accounts is a ManyToMany relationship with Users. I'm able to create all three in the Customer form and the Account is associated with the Customer. But the User is not associated with the Account. Is this setup possible?

Also UI bug (maybe?), when I add a new user which has an index of 1.1, the form is collapsed no matter what I set for NestedForm::make('Users')->open()

Hi, i am having trouble with the translations.

Let's say my resource is "Post". Which key should i add to my /resources/lang/en/assets.php

Thanks!

The problem is:
we creating parent model with children resources, children resource has belongsTo to parent model to better navigation in admin panel, so with nested field we must choose parent model in nested field while creating parent model, obviously it's not created yet and we cant create child nested model. In case if we didn't select parent model it shows error because it's required if we have belongsTo relation in resource.

it works only if we remove belongsTo from children model to parent, i think need to hide it in nested field

I know this package is to create related resources, but you could make it be possible to attach an already created resource.

Hi,

I'm using Laravel 5.8 (so also the 5.8 branch of this package). It seems like I cannot get this nova package to work.

This is my question model, including the nested answer model:

Every time on validation I get:

This is my Nova/Question

<?php

namespace App\Nova;

use Laravel\Nova\Fields\ID;
use Illuminate\Http\Request;
use Laravel\Nova\Fields\Text;
use Laravel\Nova\Fields\BelongsTo;
use Laravel\Nova\Fields\HasMany;
use Laravel\Nova\Fields\Select;
use Jackabox\DuplicateField\DuplicateField;
use Yassi\NestedForm\NestedForm;

class Question extends Resource
{
    /**
     * The model the resource corresponds to.
     *
     * @var string
     */
    public static $model = 'App\Question';

    /**
     * The single value that should be used to represent the resource when being displayed.
     *
     * @var string
     */
    public static $title = 'title';

    /**
     * The columns that should be searched.
     *
     * @var array
     */
    public static $search = [
        'id', 'title', 'description', 'own_web_id',
    ];

    /**
     * Get the fields displayed by the resource.
     *
     * @param \Illuminate\Http\Request $request
     *
     * @return array
     */
    public function fields(Request $request)
    {
        return [
            ID::make()->sortable(),

            Select::make('type')->options([
                '0' => 'Multiple choice',
                '1' => 'Open',
            ])
            ->displayUsingLabels()
            ->sortable()
            ->rules('required'),

            Select::make('status')->options([
                '0' => 'Not really in use yet',
            ])
            ->displayUsingLabels()
            ->sortable()
            ->rules('required'),

            Text::make('title')
            ->sortable()
            ->rules('required', 'max:255'),

            Text::make('description')
            ->rules('required', 'max:255')
            ->hideFromIndex(),

            Text::make('thank_you')
            ->rules('required', 'max:255')
            ->hideFromIndex(),

            Text::make('own_web_id')
            ->onlyOnIndex(),

            BelongsTo::make('Campaign')
            ->rules('required'),

            BelongsTo::make('Follow up', 'follow_up_question', 'App\Nova\Question')
            ->searchable()
            ->nullable(),

            HasMany::make('Answers'),

            DuplicateField::make('Duplicate')
            ->withMeta([
                'resource' => 'questions', // resource url
                'model' => 'App\Question', // model path
                'id' => $this->id, // id of record
                'relations' => [] // an array of any relations to load (nullable).
            ]),

            NestedForm::make('Answers'),
        ];
    }

    /**
     * Get the cards available for the request.
     *
     * @param \Illuminate\Http\Request $request
     *
     * @return array
     */
    public function cards(Request $request)
    {
        return [];
    }

    /**
     * Get the filters available for the resource.
     *
     * @param \Illuminate\Http\Request $request
     *
     * @return array
     */
    public function filters(Request $request)
    {
        return [];
    }

    /**
     * Get the lenses available for the resource.
     *
     * @param \Illuminate\Http\Request $request
     *
     * @return array
     */
    public function lenses(Request $request)
    {
        return [];
    }

    /**
     * Get the actions available for the resource.
     *
     * @param \Illuminate\Http\Request $request
     *
     * @return array
     */
    public function actions(Request $request)
    {
        return [];
    }
}

So how am I able to ignore the required fields from the parent?

Not sure when this started happening, but when updating related items that have a "Trix" field type, upon saving they are getting overwritten with values like this: "79497f58-f13b-4ca5-9e98-a32be3bb3aa9"
Looks like it might have something to do with the fact that Trix fields do something with attaching files, but I can't tell why this is happening exactly.

This isn't an issue but a recommended feature. It would be very useful to add draggable sorting to nested fields. Then, if a relationship weight field exists on the nested field, it is set to the index order.

For example, if a location has many users, and users are shown nested as:

1. Jane
2. John
   then the index 1 would be stored for Jane in a user.location_weight field (if exists) and 2 would be stored for John. Thanks

from user form, I like to nest the profiles form(nested), able to view the form but not saving the data. no response seen.

But bill is not saving

Hey! I have one question. I know that by default laravel nova has ability to update fields by catching events emitted by Nova.$emit('field.attribute-value', 'random-value') but i wonder is there a way to communicate with your nested component. I mean i want to have a template which fetches data from server and then populate it in the creation form. Fill all properties and relationships? can my custom field fill relationships in your component?

Thanks in advance! Have a great day

Am I doing something wrong? When I submit, I get a error reponse (below), but the fields mapped for customer_credentials are actually belonging to customer and in telescope I can see the following exception but also a valid query that doesn't create the entry:

Exception

Type | Yassi\NestedForm\Exceptions\NestedValidationException
-- | --
Location | /home/vagrant/laravel/vendor/yassi/nova-nested-form/src/Traits/FillsSubAttributes.php:253

Query

insert into
  `customers` (
    `name`,
    `enabled`,
    `email`,
    `updated_at`,
    `created_at`
  )
values
  ("customer", 0, "name", "2019-04-04 12:45:10", "2019-04-04 12:45:10")

class Customer extends Model
{
    public function customer_credentials()
    {
        return $this->hasOne(CustomerCredentials::class);
    }
}

class CustomerCredentials extends Model
{
    public function customer() {
        return $this->belongsTo(Customer::class);
    }
}

class Customer extends Resource
{
    public function fields(Request $request)
    {
        return [
            ID::make('ID')
                ->rules('required')
                ->onlyOnDetail()
                ->sortable()
            ,
            Text::make('Name')
                ->rules('required')
                ->sortable()
            ,
            Text::make('Email')
                ->rules('required')
                ->sortable()
            ,
            NestedForm::make('Credentials', 'customer_credentials', CustomerCredentials::class)
                ->open(true)
        ];
    }

{
	"messages": "The given data was invalid.",
	"errors": {
		"customer_credentials[name]": ["The name field is required."],
		"customer_credentials[enabled]": ["The enabled field is required."],
		"customer_credentials[email]": ["The email field is required."]
	}
}

Changing the hasOne to belongsTo doesn't make a difference.

EDIT: I am also using yassi/nova-nested-form:dev-laravel-5.8

When creating a new resource relationship on a 'belongs-to-field' the BelongsToId property is not set. Resulting in always having to select the correct relation. Is this expected behavior?

Very useful to have a possibility disable to delete item like as \Yassi\NestedForm\Traits\CanBeCollapsed::open option.

After upgrade to Laravel 5.8 and Nova 2.0, I get this error on creating a resource.

Hey I am trying to restrict the user to add at least 1 record of the nested form type.. but when i use it it just saves the model? min(1) is what i am trying. is this the right way to do it?

It would be very convenient to have such an opportunity.

Example:

class File extends Resource {

    public function fields(Request $request) {
        return [
            NestedForm::make('Fileable')->types([
                User::class,
            ])
        ];
    }

class File extends Model {

    public function fileable() {
        return $this->morphTo();
    }

class CreateFilesTable extends Migration {

    public function up() {
        Schema::create('files', function (Blueprint $table) {
            $table->bigIncrements('id');
            $table->morphs('fileable');
            $table->timestamps();
        });
    }

Does this package support Many to Many Relations?

when i add nested form like

NestedForm::make('Orders')

i see just 404 in devtools:

Request URL: http://host.test/nova-api/offers?search=&filters=&orderBy=&orderByDirection=desc&perPage=25&trashed=&page=1&viaResource=&viaResourceId=&viaRelationship=&relationshipType=
Request Method: GET
Status Code: 404 Not Found

if i remove nested form the url above works as it should be.

If trying to create the parent resource and the nested resource:

It will fail at creation, (I think because the parent object is not created yet)

I have used the documented afterFill callback

->afterFill(function ($request, $model, $attribute, $requestAttribute, $touched) {
    $touched->each(function ($model) {
        if ($model->wasRecentlyCreated) {
            // do something
        }
    });
})

it says: Call to a member function each() on array
I'm using Laravel 5.8 and nova 2.0.3

Seems $touched attribute is an array instead of being a collection.

I was playing around the html/css. Do you think this is a little better? I wasn't a huge fan of not using the primary color or the small size on the button.

As soon as you add a membership the notice no relationships would disappear. I just think it would be useful to have a header as the small button might be confusing to some users.

Unfortunately it's not working with the package NovaDependencyContainer.

I use that dependency-container to show certain attributes, when something is selected in the form. But when I use NestedForms and I select something in the select-box, nothing happens.

Is there a workaround? Would be great to use both in the same Nova model.

Hello @yassipad - and thank you for your hard work!:)

I'm attempting to use this to - obviously - create some relationships on the fly.

However, the relationships i'm trying to use need to be using different fields (like davidpiesse/nova-toggle for example which toggles on/off based on a previously selected values);

Now after having a look at what your package is doing -- do you think there's anyway i could make this work ?

I realise you're adding a 'nested' ID and and more attributes -- but get i can your input on this ?

Nova 2.0.1

            NestedForm::make('Files')
                ->min(1)
                ->max(1)
                ->open(true)
                ->rules('required'),

If I click Create button without add new file - validation messages don't shows.

Backend work correct:

Status Code: 422 Unprocessable Entity

{"message":"The given data was invalid.","errors":{"files":["The files field is required."]}}

But if I click Add new a File - validation message displayed:

Originally posted by @jasonaranda in #21 (comment)

When i press update nothing happen.
What can i do in this case?

Hey there. I seem to be unable to delete any nested item when editing a resource. It disappears, but as soon as I update the resource, it comes back.

If I am in the detail view and try to delete it through the nova relationship list it works as expected. Anyone experiencing the same?

This is the code in my nova resource (Solution). SolutionHighlights has a BelongsTo relationship with Solution.

NestedForm::make('SolutionHighlights')
                ->open(true)
                ->heading('{{index}}. {{title}}'),