wooandrew / boomerang Goto Github PK
View Code? Open in Web Editor NEWProject Boomerang is an open-source, yet-to-be-titled video game project collaboration started by four college dudes.
Home Page: https://wooandrew.dev/boomerang
License: Other
Project Boomerang is an open-source, yet-to-be-titled video game project collaboration started by four college dudes.
Home Page: https://wooandrew.dev/boomerang
License: Other
12/04/2020 - Code review for commit 6473eaa
Commit: 6473eaa
Branch: object
Assignee: Porter Squires (Developer)
Contact: [email protected]
Reviewer: Andrew Woo (Project Manager, Developer)
Contact: [email protected]
REQ - Required changes: these changes are required.
REC - Recommended changes: these changes are recommended to follow best practice
REQ
➡️ Line 1: missing copyright header.boomerang/root/engine/units/unit.hpp
Line 1 in 6473eaa
REQ
➡️ Line 3-22: missing license declaration.boomerang/root/engine/units/unit.hpp
Lines 3 to 22 in 6473eaa
REC
➡️ Line 1-3: organize includes in order (standard library, dependency, boomerang)boomerang/root/engine/units/unit.hpp
Lines 1 to 3 in 6473eaa
REC
➡️ Line 5-6: change header guards to follow convention (BOOMERANG_ENGINE_UNIT_UNIT)boomerang/root/engine/units/unit.hpp
Lines 5 to 6 in 6473eaa
REC
➡️ Line 11: use pascal case for class names.boomerang/root/engine/units/unit.hpp
Line 11 in 6473eaa
REQ
➡️ Line 16, 44: undefined reference to class Texture (#include "../graphics/texture.hpp"
).boomerang/root/engine/units/unit.hpp
Line 16 in 6473eaa
boomerang/root/engine/units/unit.hpp
Line 44 in 6473eaa
REQ
➡️ Line 19, 43, 48: missing std scope for vector.boomerang/root/engine/units/unit.hpp
Line 19 in 6473eaa
boomerang/root/engine/units/unit.hpp
Line 43 in 6473eaa
boomerang/root/engine/units/unit.hpp
Line 48 in 6473eaa
REC
➡️ Line 27, 33-34: inconsistent spacing (tabs instead of 4 spaces).boomerang/root/engine/units/unit.hpp
Line 27 in 6473eaa
boomerang/root/engine/units/unit.hpp
Lines 33 to 34 in 6473eaa
REQ
➡️ Line 34-35: make Update(), Display() virtual for overloading/inheritanceboomerang/root/engine/units/unit.hpp
Lines 34 to 35 in 6473eaa
REQ
➡️ Line 39 (affects line 16, 22): make position glm::vec3 for render layeringboomerang/root/engine/units/unit.hpp
Line 39 in 6473eaa
REQ
➡️ Line 43: undefined reference to class Vertex (#include "../graphics/vertex.hpp"
).boomerang/root/engine/units/unit.hpp
Line 43 in 6473eaa
REQ
➡️ Line 45: undefined reference to class unitDisplay (#include "unitDisplay.hpp"
).boomerang/root/engine/units/unit.hpp
Line 45 in 6473eaa
REQ
➡️ Line 46: undefined reference to class unitManipulator (#include "unitManipulator.hpp"
).boomerang/root/engine/units/unit.hpp
Line 46 in 6473eaa
REQ
➡️ Line 49: syntax error.boomerang/root/engine/units/unit.hpp
Line 49 in 6473eaa
REQ
➡️ Line 1: incorrect copyright header. (engine/engine.cpp -> engine/unit/unit.cpp)boomerang/root/engine/units/unit.cpp
Line 1 in 6473eaa
REC
➡️ Line 22-27: organize includes in order (standard library, dependency, boomerang)boomerang/root/engine/units/unit.cpp
Lines 22 to 27 in 6473eaa
Remove file and integrate directly into unit class as virtual function.
Remove file and integrate directly into unit class as virtual function.
Objects
)A declarative, efficient, and flexible JavaScript library for building user interfaces.
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
An Open Source Machine Learning Framework for Everyone
The Web framework for perfectionists with deadlines.
A PHP framework for web artisans
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
Some thing interesting about web. New door for the world.
A server is a program made to process requests and deliver data to clients.
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
Some thing interesting about visualization, use data art
Some thing interesting about game, make everyone happy.
We are working to build community through open source technology. NB: members must have two-factor auth.
Open source projects and samples from Microsoft.
Google ❤️ Open Source for everyone.
Alibaba Open Source for everyone
Data-Driven Documents codes.
China tencent open source team.