Code review: 6473eaa

Hi there 👋

I'm Andrew.

B.S Computer Science, Georgia Institute of Technology, class of '24

	#include <memory>

	#ifndef BOOMERANG_ENGINE_UNIT
	#define BOOMERANG_ENGINE_UNIT
	// For now, this unit represents a quad object that can hold other units as children
	// To do: update the unit to holds a vector of vertices to outline the unit and replace size
	namespace Boomerang::Core::Units {

	class unit {

	public:

	// Constructor
	unit(glm::vec2 _position, glm::vec2 _size, glm::vec4 color, std::shared_ptr<Texture> _texture);

	// Getters
	std::shared_ptr<vector<unit>> GetChildren();
	std::shared_ptr<unit> GetParent();
	bool GetVisible();
	glm::vec2 GetPosition();

	*/
	#include "unit.hpp"
	#include <GLM/glm/glm.hpp>
	#include "../graphics/texture.hpp"
	#include <vector>
	#include <memory>

	// Functions
	void Update();

	void Update();
	void Display();

wooandrew / boomerang Goto Github PK

boomerang's Introduction

Hi there 👋

boomerang's People

Contributors

Watchers

Forkers

boomerang's Issues

REQ - Required changes: these changes are required. REC - Recommended changes: these changes are recommended to follow best practice

REQ ➡️ Line 1: missing copyright header.

REQ ➡️ Line 3-22: missing license declaration.

REC ➡️ Line 1-3: organize includes in order (standard library, dependency, boomerang)

REC ➡️ Line 5-6: change header guards to follow convention (BOOMERANG_ENGINE_UNIT_UNIT)

REC ➡️ Line 11: use pascal case for class names.

REQ ➡️ Line 16, 44: undefined reference to class Texture (#include "../graphics/texture.hpp").

REQ ➡️ Line 19, 43, 48: missing std scope for vector.

REC ➡️ Line 27, 33-34: inconsistent spacing (tabs instead of 4 spaces).

REQ ➡️ Line 34-35: make Update(), Display() virtual for overloading/inheritance

REQ ➡️ Line 39 (affects line 16, 22): make position glm::vec3 for render layering

REQ ➡️ Line 43: undefined reference to class Vertex (#include "../graphics/vertex.hpp").

REQ ➡️ Line 45: undefined reference to class unitDisplay (#include "unitDisplay.hpp").

REQ ➡️ Line 46: undefined reference to class unitManipulator (#include "unitManipulator.hpp").

REQ ➡️ Line 49: syntax error.

REQ ➡️ Line 1: incorrect copyright header. (engine/engine.cpp -> engine/unit/unit.cpp)

REC ➡️ Line 22-27: organize includes in order (standard library, dependency, boomerang)

Other

Recommend Projects

Recommend Topics

Recommend Org

`REQ - Required changes: these changes are required.`
`REC - Recommended changes: these changes are recommended to follow best practice`

`REQ` ➡️ Line 1: missing copyright header.

`REQ` ➡️ Line 3-22: missing license declaration.

`REC` ➡️ Line 1-3: organize includes in order (standard library, dependency, boomerang)

`REC` ➡️ Line 5-6: change header guards to follow convention (BOOMERANG_ENGINE_UNIT_UNIT)

`REC` ➡️ Line 11: use pascal case for class names.

`REQ` ➡️ Line 16, 44: undefined reference to class Texture (`#include "../graphics/texture.hpp"`).

`REQ` ➡️ Line 19, 43, 48: missing std scope for vector.

`REC` ➡️ Line 27, 33-34: inconsistent spacing (tabs instead of 4 spaces).

`REQ` ➡️ Line 34-35: make Update(), Display() virtual for overloading/inheritance

`REQ` ➡️ Line 39 (affects line 16, 22): make position glm::vec3 for render layering

`REQ` ➡️ Line 43: undefined reference to class Vertex (`#include "../graphics/vertex.hpp"`).

`REQ` ➡️ Line 45: undefined reference to class unitDisplay (`#include "unitDisplay.hpp"`).

`REQ` ➡️ Line 46: undefined reference to class unitManipulator (`#include "unitManipulator.hpp"`).

`REQ` ➡️ Line 49: syntax error.

`REQ` ➡️ Line 1: incorrect copyright header. (engine/engine.cpp -> engine/unit/unit.cpp)

`REC` ➡️ Line 22-27: organize includes in order (standard library, dependency, boomerang)