Giter Club home page Giter Club logo

Comments (1)

domenic avatar domenic commented on July 27, 2024

This algorithm is suffering from the problem of trying to bridge the JS and web conventions. We can definitely do better.

But stepping back, there's a bit of a mess in general. "run a classic script" has the following callers:

My proposal:

  • "run a classic script" should behave entirely according to web conventions. I.e., it should return or throw, and should never return completion records (in either success or failure cases).

  • "run a classic script" should only throw if rethrow errors is set.

I think this would work better with what callers expect.

Concretely, I think the changes are then:

  • Step 7.3.3. should return null instead of evaluationStatus.
  • Step 9 should return evaluationStatus.[[Value]] instead of evaluationStatus.
  • Step 10 should return null.
  • "evaluate a javascript: URL" should be updated to use web conventions instead of getting a completion record.

If this makes sense to you, a PR implementing it would be welcome.

from html.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.