Comments (3)
Yes, this looks like a bug to me, maybe based on misunderstanding when the "ever populated" value gets set. /cc @noamr to confirm, since he added that assert.
I think the intent was something like, "assert that we're going to a new entry which we haven't visited previously". But, as you note, "ever populated" gets set before "apply the history step" is called, even for "new" entries (i.e. the push/replace cases).
I think probably the best fix here is to remove the asserts related to ever populated (which would mean no asserts for "traverse").
from html.
I'm also confused why the check that the target entry's document is not ever populated in general..
We set ever_populated to true in populate_session_history_entry_document
step 6.7.1 when the document is non-null, and then call into the completion steps. Which in the case of navigate a navigable
step 20.9.1 will be to finalize a cross document navigation. Which in turn applies the push/replace history step, and enqueues a global task to the navigation and traversal task source of the active window to do step 12.5 of apply the history step.
So... In all cases(?) we will populate the session history entry document before ever checking the navigation type, and we will always have populated the target entry?
Unless I'm completely misreading :)
from html.
Good catch, SGTM
from html.
Related Issues (20)
- `html` end tag omission HOT 3
- Upcoming WHATNOT meeting on 2/8/2024 HOT 2
- Should dir=auto with no strong characters inherit directionality from parent or be ltr? HOT 10
- Navigation: DocumentState request referrer is not set for about:srcdoc
- `<callout>` element for callouts/alerts/admonitions HOT 35
- Proposal: HTML Attribute to state non-consent when scraping for training datasets HOT 1
- Can a task throw exceptions? HOT 2
- "run a classic script" returns completion records and throws HOT 1
- Session history step of top level navigable when child navigables traverse history HOT 1
- Should there be an opt-out for declarative shadow roots having `clonable=true`? HOT 27
- Should `<a target="_blank">` and `window.open` consume the transient activation? HOT 2
- `<img sizes="auto, 100px" loading="eager">`: `auto` equates to `100wv` but should ideally be ignored
- Constrain OffscreenCanvas with a placeholder canvas element HOT 8
- A way to run code before the next frame HOT 8
- New attribute for avoiding to autocapitalize text input fields HOT 1
- Autocomplete attribute value to indicate form input is third-party data
- Improve API of `insertAdjacent*()` methods HOT 2
- Why does popover hide when the popover attribute changed HOT 4
- Read-only state for buttons? HOT 6
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from html.