facts cannot be cased as described about rspec-puppet-facts HOT 7 CLOSED

Thanks for reporting this! Could you send us a PR to fix the docs?

from rspec-puppet-facts.

Hah, you assume I've found a solution yet. 🙁 That would be nice, still looking.

from rspec-puppet-facts.

You would need to use os_facts[:osfamily] instead of facts[:osfamily] since that's what you've called the facts variable in on_supported_os.each do |os, os_facts|. Notice that the example actually calls the facts variable facts, not os_facts:

  on_supported_os.each do |os, facts|
    context "on #{os}" do
...
      # If you need to specify any operating system specific tests
      case facts[:osfamily]

Also note that let definitions are only available within an example, e.g. it { ... } and not example groups, e.g. context .... So facts[:osfamily] would work for you within an it block, but not within a context block.

I have run into this confusion myself as the Puppet Development Kit spec templates use os_facts while the examples in this documentation use facts, e.g. https://github.com/puppetlabs/pdk-templates/blob/2b3320584b8d6ceb9027b441582bb4e16c3d6350/object_templates/class_spec.erb#L4 and https://github.com/puppetlabs/pdk-templates/blob/2b3320584b8d6ceb9027b441582bb4e16c3d6350/object_templates/defined_type_spec.erb#L9. Would it make sense to update this documentation to match the PDK templates?

from rspec-puppet-facts.

Perhaps it would be better to update PDK's templates to use facts as that makes more sense than their implementation using os_facts

from rspec-puppet-facts.

No, in this case it's the rspec-puppet-facts documentation that is wrong. The facts local variable is actually a memoised helper expected to be created by let(:facts) as standard practice in rspec-puppet. The docs for rspec-puppet-facts set up a rather confusing situation where one of the facts values ends up shadowed, which while it technically works it should not be encouraged.

on_supported_os.each do |os, facts| # <-- facts hash added to scope
  let(:facts) do # <-- facts hash now shadowed by the memoised facts helper
    facts # <-- Want to guess what this value will be at a specific time of evaluation?
  end

from rspec-puppet-facts.

@rodjek you seem to know what's going on with this, could you send a PR to the docs?

from rspec-puppet-facts.

@towo rodjek/rspec-puppet#774 (comment) describes correct syntax.

from rspec-puppet-facts.