The change done in <a class="issue-link js-issue-link" data-error-text="Failed to load

<a class="user-mention notranslate" data-hovercard-type="user" data-hovercard-url="/us

I see three options fixing this: Change <code c

I see the same in <a href="https://travis-ci.org/puppetlabs/cisco_ios/jobs/445535959#L

<a class="user-mention notranslate" data-hovercard-type="user" data-hovercard-url="/us

Alright then, opened up <a class="issue-link js-issue-link" data-error-text="Failed to

PR #72 breaks Puppet 6 about rspec-puppet-facts HOT 5 CLOSED

voxpupuli commented on July 17, 2024

PR #72 breaks Puppet 6

from rspec-puppet-facts.

Comments (5)

baurmatt commented on July 17, 2024

@mcanevet Could you please elaborate why the originally implemented version was good enough for Puppet 6? From my understanding, if Puppet.features.augeas? doesn't require Augeas to be present.

from rspec-puppet-facts.

baurmatt commented on July 17, 2024

I see three options fixing this:

Change rescue => e to rescue LoadError => e
This still throws Failed to retrieve Augeas version: cannot load such file -- augeas warnings, which aren't really nice.
Revert 5156ec4 - it worked for us with with Puppet 6.0.0
Add the augeas gem as a dependency for this gem.

from rspec-puppet-facts.

DavidS commented on July 17, 2024

I see the same in https://travis-ci.org/puppetlabs/cisco_ios/jobs/445535959#L933-L942 :

An error occurred while loading ./spec/classes/proxy_spec.rb.
Failure/Error:
    on_supported_os(proxy_os).each do |os, os_facts|
      context "on #{os}" do
        let(:facts) { os_facts }
  
        it { is_expected.to compile }
      end
    end
LoadError:
  cannot load such file -- augeas
# ./vendor/bundle/ruby/2.4.0/gems/rspec-puppet-2.7.1/lib/rspec-puppet/monkey_patches.rb:350:in `require'
# ./vendor/bundle/ruby/2.4.0/gems/rspec-puppet-2.7.1/lib/rspec-puppet/monkey_patches.rb:350:in `require'
# ./vendor/bundle/ruby/2.4.0/gems/rspec-puppet-facts-1.9.1/lib/rspec-puppet-facts.rb:220:in `common_facts'
# ./vendor/bundle/ruby/2.4.0/gems/rspec-puppet-facts-1.9.1/lib/rspec-puppet-facts.rb:134:in `block in on_supported_os'
# ./vendor/bundle/ruby/2.4.0/gems/rspec-puppet-facts-1.9.1/lib/rspec-puppet-facts.rb:117:in `map'
# ./vendor/bundle/ruby/2.4.0/gems/rspec-puppet-facts-1.9.1/lib/rspec-puppet-facts.rb:117:in `on_supported_os'
# ./spec/classes/proxy_spec.rb:4:in `block in <top (required)>'
# ./spec/classes/proxy_spec.rb:3:in `<top (required)>'

from rspec-puppet-facts.

DavidS commented on July 17, 2024

@baurmatt the issue seems to be that Puppet.features.augeas? now always returns false, even if augeas is present in the bundle. You first option, rescuing the LoadError seems to be the way to go then.

from rspec-puppet-facts.

baurmatt commented on July 17, 2024

Alright then, opened up #74 for the fix.

from rspec-puppet-facts.

Recommend Projects