Comments (3)
alexjfisher
commented on July 17, 2024
Looks like the regex in while db.empty? && version !~ /\d+\.0($|\.\d+)/ should handle this, but assumes the full version is being used. ie 3.9.0 not just 3.9. The spec tests for facterversion suggest a version number without the revision part should work though.
from rspec-puppet-facts.
alexjfisher
commented on July 17, 2024
Correction: the regex assumes a full version or a version with just MAJOR.MINOR. It does not cover the case where the version returned by down_facter_version is incomplete though.
from rspec-puppet-facts.
alexjfisher
commented on July 17, 2024
/\d+\.0($|\.\d+)/ also needs to be anchored or it matches 3.9.0 as 9.0
from rspec-puppet-facts.
Related Issues (20)
- More docs changes needed HOT 1
- Overriding structured facts HOT 3
- Memoizing facts HOT 3
- remove json as a dependency HOT 2
- Cut a new release HOT 1
- Reduce calls to FacterDB
- Allow modules to export custom fact values HOT 1
- Push 2.0.1 git tag to Github HOT 1
- Fail tests when no facts are found in facterdb
- "add_custom_fact" creates String-Facts instead of Symbol-Facts HOT 1
- release notes for 3.0.0
- Cut a new release to support windows server 2016 HOT 5
- facterversion filter fails with windows and facter version 3.x HOT 2
- File resource is trying to load Windows provider on a non-Windows computer HOT 2
- AIX hardware model should not be x86_64 HOT 2
- PR #72 breaks Puppet 6 HOT 5
- Specify required_ruby_version
- facts cannot be cased as described HOT 7
- Commit 21442e7 looks to introduce hard to debug behavior HOT 5
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from rspec-puppet-facts.