vitormesquita / malert Goto Github PK

Would you implement sender to be passed to the button actionBlock?

Hello,

There's an issue with custom view height when application "Supported interface orientations" is set to portrait but the device is in landscape orientation.

Looks like the issue is following code block of Malert constrains extension (Malert+Constraints.swift):

if UIDevice.current.orientation.isLandscape {
         let topContraint = malertView.topAnchor.constraint(equalTo: visibleView.topAnchor, constant: 16)
         topContraint.priority = UILayoutPriority(900)
         malertConstraints.append(topContraint)

         let bottomConstraint = malertView.bottomAnchor.constraint(equalTo: visibleView.bottomAnchor, constant: -16)
         bottomConstraint.priority = UILayoutPriority(900)
         malertConstraints.append(bottomConstraint)
}

Above if condition doesn't sufficiently checks if landscape orientation is enabled for the application.
I suggest to change above condition statement to:

if UIDevice.current.orientation.isLandscape && supportedInterfaceOrientations.contains(.landscape) {
    ...
}

This way the issue can be avoided by following extension:

extension Malert {
	public override var supportedInterfaceOrientations: UIInterfaceOrientationMask {
		return .portrait
	}
}

Kindly note that this is just something I came up with on the fly to patch this issue so please feel free to implement a better solution if necessary.

Thank you!

I couldn't see any example of this, since we can customize views and put in malert, can we do this ?

Add a gestureRecognizer out of alert to close the UIView

Please, give us some gifs showing what you've done.

CocoaPods and Carthage are awesome tools and make our life really easier, but there are some devs who still don't know how to use them.

It would be cool to add the Manual installation guide in your README.md. You can take a look at my iOS Readme Template to see how you can do it.

When I click on UIView the keyboard is not closing

How to know Malert has dismised either on tapToDismiss or added button action.
I need to perform some actions when Malert dismiss.

how to dismiss malert?

This is portrait orientation

And this is landscape orientation

Anyone can help to fix this #

MalertAction how to prevent it auto dismiss , we dont want it auto dismiss when click the action. We want to validation first and dismiss manually

I am trying to display a tableview in an Malert prompt and it doesn't work. Is UITableView supported?

I have a following issue when my app goes to landscape mode. Do you have any suggestions?

I would like alert to be a fixed width instead of going almost entire width of the screen.
Thanks