vhf / resrc Goto Github PK

On a list, add a link via the "add" button, validate, add another one, the tags field still contains the tags selected for the first link.

Hi,

Here are some suggestions that I think would help future contributors.

README.md should enumerate dependencies required for the project (e.g. postgresql was missing on my PC).

If there is a release version and a devel version, the two installation sequences should be described. Also, mentioning python manage.py before syncdb and related commands would be appreciated.

I was not able to get a running version until I installed dependencies described in requirements_dev.txt with pip. This is not mentioned in README.md.

Steps To Reproduce

1. go to http://resrc.io
2. Click on Login link
3. click directly on Login button without entering user-name and password
4. Observe error message

Actual Result

• Error message is displayed as "Form Invalid"

Expected Result

• Error message should be displayed as "Please enter username and password"

It might be interesting and/or practical to display publicly where from an "external list" comes. However, some users might want to keep this info private (e.g. hosting a list as a text file on some server, not wanting people to know this page or server exist).

Also, rename List.url to List.source_url, less ambiguous.

When i try to edit my account :

Request Method: POST
Request URL: http://192.168.0.10:8000/user/account

Traceback:
File "/home/alex/Programmation/github/resenv/local/lib/python2.7/site-packages/django/core/handlers/base.py" in get_response

1.                     response = callback(request, _callback_args, *_callback_kwargs)
   

   File "/home/alex/Programmation/github/resenv/local/lib/python2.7/site-packages/django/contrib/auth/decorators.py" in _wrapped_view

2.             return view_func(request, _args, *_kwargs)
   

   File "/home/alex/Programmation/github/resenv/resrc/resrc/userprofile/views.py" in settings_account

3.     if form.is_valid():
   

   File "/home/alex/Programmation/github/resenv/local/lib/python2.7/site-packages/django/forms/forms.py" in is_valid

4.     return self.is_bound and not bool(self.errors)
   

   File "/home/alex/Programmation/github/resenv/local/lib/python2.7/site-packages/django/forms/forms.py" in _get_errors

5.         self.full_clean()
   

   File "/home/alex/Programmation/github/resenv/local/lib/python2.7/site-packages/django/forms/forms.py" in full_clean

6.     self._clean_fields()
   

   File "/home/alex/Programmation/github/resenv/local/lib/python2.7/site-packages/django/forms/forms.py" in _clean_fields

7.         value = field.widget.value_from_datadict(self.data, self.files, self.add_prefix(name))
   

   File "/home/alex/Programmation/github/resenv/local/lib/python2.7/site-packages/django/forms/widgets.py" in value_from_datadict

8.     return data.get(name, None)
   

   File "/home/alex/Programmation/github/resenv/local/lib/python2.7/site-packages/django/utils/functional.py" in inner

9.     return func(self._wrapped, *args)
   

Exception Type: AttributeError at /user/account
Exception Value: 'User' object has no attribute 'get'

When arriving on home for the first time, an inexperienced user confronts the quite big yellow panel which does disturbs reading. ON my configuration, real content only begins in the second half of the page. Allowing unregistered users to discard this panel may help keep them.

Steps To Reproduce

1. hit url http://resrc.io
2. navigate to register page
3. enter email as abc@gmail
4. and click on Register button and observe

Actual Result

• Error message is not been displayed for incorrect email id format abc@gmail

Expected Result

• Only correct format email id's should be accepted [email protected] i.e. which contains @ and dot included in it
• Error messages should be displayed for incorrect format of email id's

Probably a reset link by mail.

One should be able to edit his own links.

When editing a list, content displayed and stored contains only repr() of values instead of strings.

First, congratulations on the project. Great idea!
Why do not you include a feature to differentiate checked links and non-checked links?
For example:
In the 'Unix' (http://resrc.io/tag/tag/unix/) tag: I've scoured the entire tutorial -> "UNIX Tutorial for Beginners." It would be interesting to do something that highlight this.
For tags with few links that would be somewhat interesting, but for extended tags (eg Ruby, Javascript) that highlight what has been seen is extremely cool. Streamlines the process of searching for new knowledge.
PS. I knew the system a few days ago and I'm not 100% guarantee that this feature does not exist. At least I did not find anything that showed this difference between links.

Thanks for your understanding and patience.

Check all templates, see what JS and markup (e.g. modals) should not be loaded for anonymous users, put them in conditional statements.

• https://news.ycombinator.com/item?id=6107797
• https://news.ycombinator.com/item?id=5922791

Will only be solved when our audience reaches critical mass.

• User A imports his github list.
• Most of the links already are on reSRC, but some are not, e.g. http://a.io
• ATM reSRC adds next to http://a.io a link to add http://a.io through ajax and reload the list
• A should obviously be able to use this "add" link. But what about other users ?
• If other users are unable to use these "add" links, we'll have to find a way not to display it to them.
• If other users should be able to use these "add" links, which is the case (see commit below), then how can we make this secure ? As for now, changing a few parameters and posting to an URL adds link id X to list id Y. Quite dangerous.

Some CSS issue on logging page.

Sur un lien (link [show]-single), ajouter un bouton pour les utilisateurs connectés : edit tags.

Affiche une modale avec le titre et l'url en champs disabled et la liste des tags. Quand le formulaire est posté, les tags modifiés sont flanqués qqpart dans le BDD pour modération par un admin.

Modèle dans Tag : RevisedTag, FK_Link, TextField avec les tags CSV.

Faire la page de modération également.

Links to some of the lengthier titles are missing the parentheses. A couple of examples:

Top link: http://resrc.io/list/10/list-of-free-programming-books/#net-c--vb--nemerle--visual-studio

Anchor link: http://resrc.io/list/10/list-of-free-programming-books/#net-%28c%23--vb--nemerle--visual-studio%29

Top link: http://resrc.io/list/10/list-of-free-programming-books/#sql-implementation-agnostic

Anchor link: http://resrc.io/list/10/list-of-free-programming-books/#sql-%28implementation-agnostic%29

This is a regression introduced by ff78ae.

Edit: Ok, simple. I forgot the type attribute. Doing a quick PR. :)

Re-clicking the 'vote' button on links and lists should probably unvote them.

ItThe Or | And Switch seems too wide, and the text items "and" and "or" have no margin with the switch border, which results in aglobally akward display.

The issue appears both on home and search pages.

Would be great to have the possibility to share a search (like a search on a tag, ... etc) :)

• close window when link added
• fix it. Form is always invalid. :(

Hacker News Enhancement Suite displays an inspiring TL;DR.io implementation.

• Existing TL;DR should be displayed between Link and comments.
• In a list of links (e.g. user-managed lists, frontpage, search results, etc), links providing a TL;DR could be highlighted somehow (followed by a visual label ? or link title with a trailing star * ? ...)

I like the TL;DR displayed when hovering tldr button on HN frontpage, but I don't want to implement a similar feature because I'd prefer user to click through and visit a "single link" page, where tags and other infos are also displayed.

If we want it to be a prominent feature, we'd probably have to discuss it with tldr.io guys (they're french and friendly). (Seems to be a win-win. We get tldr, they get tldr from our willing users.)

One way to populate the DB prior to launch could be to dip into their links.

Maybe display the form to register/login in a modal window ?

When adding tags to a link, if a comma is added right after a word ("tag,") it will be discarded and the tag not saved (ie : it remains the tag currently edited). If I type "tag ," on the other hand, things work perfectly.

The add button next to a link in a list might deserve a left-margin, as for now it looks a bit akward :

Now

After

for example, by tags :
[tag selected]
similar tags [and / or]
links / lists associated to this/these tag(s)

When editing a "distant" list (i.e. a list which has a non-blank url field), one should be able to re-pull the list from URL.

Should be text, not default.

One user complained that he didn't knew why his account creation failed. Thing is, his chosen username already was taken.

We need to make it clear in this case.

mptt_comments.js is not loaded

same with feedback.js

• tab (ou enter) serait cool, pour pas avoir besoin d'utiliser les flèches
• pas de résultats, /search/... retourne un 404
• apparence des suggestions

• une info pour dire que c'est du markdown
• résumé de la syntaxe
• que les liens sont automatiquement transformés
• qu'est-ce que le champ 'URL' ?
• etc.

Labels for username and password don't select related fields when clicking them in the registration form. My browser is chromium running on Arch Linux. This is most probably due to having the login and registration forms on the same HTML page, which has led to duplicate HTML ids for these two fields.

Some pages are automatically displayed in the browser locale, it could be useful to allow links to have multiples language tags.

Moreover, some books are translated (for exemple Learn You A Haskell for great good) but translations do not live at the same URL, it could also be useful to allow multiple URL (one for each language) on a link, as comment and upvotes are not language-dependant.

In order to know which links are in which lists for freeform lists, we should, when parsing the markdown, add a ListLinks entry for each link.

Problem is, currently fixup() runs before list creation. Call stack :

• extensions.py l.53-57
• emarkdown.py l.54
• list/views.py l. 166

In the add interface, "space" creates the tag.
In the edit/suggest interface, it does nothing.

I guess behaviour should stay consistent throughout all the interfaces. And we need a way to add new tags containing spaces.

Adding a tag should trigger the display of similars tags.

Stupid bug.

Posting a comment is supposed to mean posting the form through ajax and getting its content back from a view with a stripped out template.

Instead, we get redirected to the full page containing the new comment alongside with all the page content.

Lost already 2h trying to get this work.

Initially, other bugs were caused by mptt_comment.js relying on $.bind and $.live, which have been deprecated since already jQuery 1.7.

Because of the #.

It tries to ajax load something like /tag/search/C#%25or%25 but the # is the anchor operator.

Fix : urlencode tags before passing them through ajax call