vexatos / circulararrays.jl Goto Github PK

Could we have a deleteat! for CircularVector?

See #2 (comment) by @yha and JuliaArrays/OffsetArrays.jl#87. This needs to be solved, but there currently isn't any good way to do that. Would probably have to create a hard dependency on OffsetArrays until this is fixed in Base, which is really ugly and I'd rather not do it.

This issue is used to trigger TagBot; feel free to unsubscribe.

If you haven't already, you should update your TagBot.yml to include issue comment triggers.
Please see this post on Discourse for instructions and more details.

I get an error when I try to use map on a circular array. It seems like this should work but perhaps I am missing something.

e.g. map(x -> x+1, CircularArray([1,2,3,4])) throws an error...

ERROR: MethodError: similar(::CircularVector{Int64, Vector{Int64}}, ::Type{Int64}, ::Tuple{Base.OneTo{Int64}}) is ambiguous. Candidates: ..............

reduce seems to work which slightly surprised me given the above
reduce(+, CircularArray([1,2,3,4]))
10

The CircularVector is missing a insert! method that allows insertion at a specific index.

What I would appreciate is a way to construct a matrix that is circular in the first dimension while restricted in the other dimension (i.e. should be able to throw BoundsError)

There are two ways to achieve this:

• To add a size property that hard caps the bounds. This would introduce a dependency related to infinite indexing (e.g. InfiniteArrays). This is more straightforward on the surface but are prone to infinite loops at broadcast-like operations.
• To add a dim property that specifies the circular dimensions. checkbounds needs to be overloaded.

This package is a dependency in Meshes.jl and we recently started having issues with a non-working resize! function. I think this is probably related to semantic versioning misunderstanding...

When you updated from 1.1 to 1.2 to 1.3 you adopted the following rule? https://semver.org/spec/v2.0.0.html#spec-item-7

Our tests are failing now downstream. Could you please double check and help fix the issues?

Also, I reiterate the importance of placing this package in an organization where multiple members can help maintain and double check these things before submitting disruptive new releases.

I am using this package in Meshes.jl to handle polygonal geometries that create loops. I wonder if you would be willing to migrate the package to the JuliaArrays organization for greater visibility and maintenance reasons? It is nice to have multiple people working on a fundamental package like this to make sure it is up-to-date and following all the latest tricks.

These all produce the same type: CircularArray{Float64, 2, Matrix{Float64}}

• CircularArray( zeros(2, 2) )
• CircularArray{Float64}( zeros(2, 2) )
• CircularArray{Float64, 2}( zeros(2, 2) )

However, CircularArray{Float64, 2, Matrix{Float64}}( zeros(2, 2) ) fails with MethodError: no method matching CircularArray{Float64, 2, Matrix{Float64}}(::Matrix{Float64})

This is a problem when creating a function that takes an AbstractArray, produces a new Vector that gets reshaped to the same size as the AbstractArray, then tries to return the same type as the original AbstractArray using convert, or by trying to call the constructor using typeofor by the function being parametric.

I think the missing constructor can be addressed by adding a constructor that is parametric on all three types? I don't know if it makes sense to have convert work in this context.

Operations on CircularArrays give usual Arrays instead:

julia> CircularArray(rand(3,3)) .+ 1
3×3 Matrix{Float64}:
 1.59308  1.58855  1.67183
 1.86402  1.33325  1.31673
 1.15693  1.32027  1.24405