Comments (7)
@Vexatos what do you think of this?
from circulararrays.jl.
I'm not sure about this. I'll think about it and just leave this issue open for now as a reminder. Thank you for choosing to use my package, though.
from circulararrays.jl.
I think it would be great. This package should get more attention, it's really useful
from circulararrays.jl.
@Vexatos did you have a chance to reconsider this? As you can see from the number of stars in the issue, the community would benefit from an increased list of maintainers to hot fix and release new patches.
from circulararrays.jl.
For now, I'd like to keep it to myself. For a small project like this, I prefer keeping full control over it, making sure the scope stays limited so that no unnecessary things are added, and not having to answer to anyone if I ever do decide to make changes. It also helps with keeping the code clean.
If I ever end up losing motivation to maintain it, I'll certainly accept the offer, as others are using the package now.
from circulararrays.jl.
@Vexatos the fact that there are 6 PRs opened, and you are the only person with write access is a bit concerning. It is fine to keep this package as a personal project, but we appreciate if you can signal that to the community.
We will fork the package if you prefer to keep CircularArrays.jl to yourself, and will maintain a separate package in JuliaArrays or another org where contributors can discuss alternative designs and new features. We are constantly bumping into design limitations with the current implementation, and cannot fix things quickly.
from circulararrays.jl.
I'll maintain my position that I'd like to keep this project to myself. I want to make sure this package remains generic and keeps compatibility with all custom array types I may encounter, and importantly, I need it to retain its high efficiency, which is best ensured through a small codebase. The package might not do everything you want it to do just yet, so I greatly appreciate any and all contributions to this package. However, some things you want are probably better suited for either a higher-level package based on this, or an entirely different implementation altogether.
I try to review pull requests whenever I have time. Recently, reviews had been scarce owing to me not having much free time. It is nice knowing that other people use this small package for their own work, but I will not mindlessly accept any and all features people would like to add to it. If the review process is not fast enough for you, or if there is something you want to have in the array type that I would not be comfortable having in my package, and that cannot be added in a higher-level package depending on this, there is nothing wrong with making your own implementation. I'm simply not a fan of small generic packages getting overloaded with barely related features over time, to the point where I wouldn't be able to use them for my own projects anymore.
from circulararrays.jl.
Related Issues (13)
- Implement deleteat! HOT 1
- map problem HOT 2
- Type consistency HOT 3
- Semantic versioning HOT 5
- No constructor for fully specified type HOT 1
- Fix Vararg warning HOT 1
- Missing `insert!` method HOT 1
- Missing push! implementation HOT 6
- Wrong fallback for Base.empty
- Arrays that are circular in certain dimensions HOT 2
- Type piracy with OffsetArrays HOT 1
- TagBot trigger issue HOT 8
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from circulararrays.jl.