Problem with Laravel 6 upgrade about oc-redirect-plugin HOT 6 CLOSED

I can confirm it works with the latest October CMS wip/laravel-6 branch. I took some time to test it myself. Feel free to run some tests on your side. This will be included in the next release.

from oc-redirect-plugin.

@bennothommo Could you look into the upgrade guide for league/csv so we can add it to our upgrade guide document?

from oc-redirect-plugin.

@adrenth awesome, thanks! You guys do great work on this plugin!

from oc-redirect-plugin.

The current build of october/rain requires league/csv: ~8.0. And therefore the redirect plugin depends on version 8.

Although it might conflict with the new developments. This warning is present in the code of the redirect plugin and needs to be taken care of when the L6 becomes public.

// WARNING: this is deprecated method in league/csv:8.0, when league/csv is upgraded to version 9 we should
// follow the instructions on this page: http://csv.thephpleague.com/upgrading/9.0/
$results = $reader->fetchAssoc(0);

from oc-redirect-plugin.

@adrenth are you guys able to do a simple method_exists() check around the removed methods to switch between the two? Even after L6 goes live I imagine there will still be a number of people staying on the last 5.5 version (just like when we switched from 5.1 to 5.5), and this would help the plugin work for L6 builds in the meantime without breaking 5.5 builds.

from oc-redirect-plugin.

Hi @LukeTowers, are you willing to help us test this? I have made some changes in develop branch (see 2748cbc). The plugin should support version 9 as of now. I wasn't able to test it myself.

from oc-redirect-plugin.