Redirects not working about oc-redirect-plugin HOT 6 CLOSED

Fixed in 2.5.7

from oc-redirect-plugin.

Looks like this is still an issue after running the october:up command as it clears the cache using the Cache facade Cache::flush() and it looks like the cache:cleared event doesn't get triggered when doing that. The cache:cleared event only gets dispatched when running the cache:clear command.

https://github.com/octobercms/october/blob/1.1/modules/system/classes/UpdateManager.php#L158
https://github.com/octobercms/october/blob/1.1/modules/system/helpers/Cache.php#L15-L19

from oc-redirect-plugin.

I thought I had it covered by just listen to a specific event... Will look for a better solution.

from oc-redirect-plugin.

Yeah, that's the first path I took when I was looking at making a fix for this issue as well which is why I landed on checking if the cache has the key before getting the rules. Not sure if there's a better way that you can think of that doesn't require checking the cache key exists every time.

from oc-redirect-plugin.

Something that could work is listening for the CommandFinished event and if the command name is october:up or winter:up then publish the redirects.

Event::listen(CommandFinished::class, static function (CommandFinished $commandFinished): void {
    if (in_array($commandFinished->command, ['october:up', 'winter:up'])) {
        /** @var PublishManagerInterface $publishManager */
        $publishManager = resolve(PublishManagerInterface::class);
        $publishManager->publish();
    }
});

from oc-redirect-plugin.

I'm sure that won't cover all the situations which can occur when the cache is empty/invalidated or emptied somewhere else. I did use your solution and I have added it to 2.5.8.

from oc-redirect-plugin.