valax321 / meshsprites Goto Github PK

In the project browser, prefabs with a MeshSprite render a preview of the object (as they have a MeshRenderer). The shape of the mesh is correct and updates as expected, but the preview mesh is untextured. Unsure if this is indicative of an issue or simply a feature that has not been added

When using the asset, the console is regularly filled with this message whenever OnValidate is called from an instance of MeshSprite:

SendMessage cannot be called during Awake, CheckConsistency, or OnValidate
UnityEngine.StackTraceUtility:ExtractStackTrace ()
Valax321.MeshSprites.MeshSprite:GenerateMeshForSprite (UnityEngine.MeshFilter,UnityEngine.Sprite) (at Assets/Plugins/MeshSprites-1.0.0/Runtime/MeshSprite.cs:184)
Valax321.MeshSprites.MeshSprite:OnValidate () (at Assets/Plugins/MeshSprites-1.0.0/Runtime/MeshSprite.cs:124)
UnityEditor.EditorApplication:Internal_CallUpdateFunctions ()

Upon doing some research, it seems this error is caused by editing certain fields in OnValidate that trigger behaviour when edited - in this case the sharedMesh of the object's MeshFilter.

This may be due to the MeshFilter triggering some behaviour on its corresponding MeshRenderer, using SendMessage as the medium.

According to Unity, SendMessage related behaviour may fail if done from within OnValidate, so this may be a fundamental issue that underlies other issues such as #1, #3 and #4

When using CTRL-D to duplicate a GameObject with a MeshSprite component, the clone functions fine but the Mesh Filter in the original is now missing, and will stay missing (even through Undos) until one of its fields are changed (presumably calling OnValidate?)

In the project browser, when a prefab with an attached MeshSprite is selected but not yet opened, the preview in the project browser will rapidly refresh and flicker as the console is filled with the following warning:

SendMessage cannot be called during Awake, CheckConsistency, or OnValidate
UnityEngine.StackTraceUtility:ExtractStackTrace ()
Valax321.MeshSprites.MeshSprite:GenerateMeshForSprite (UnityEngine.MeshFilter,UnityEngine.Sprite) (at Assets/Plugins/MeshSprites-1.0.0/Runtime/MeshSprite.cs:184)
Valax321.MeshSprites.MeshSprite:OnValidate () (at Assets/Plugins/MeshSprites-1.0.0/Runtime/MeshSprite.cs:124)
UnityEditor.EditorApplication:Internal_CallUpdateFunction

This occurs with enough frequency that the engine slows down, and clicking elsewhere to deselect the prefab takes several seconds to register.
OnValidate seems to be called very rapidly (potentially every editor tick) while a prefab is selected - I'm not sure if this is regular behaviour, or because the MeshSprite script is causing the loop directly.

Potentially related to #3