Giter Club home page Giter Club logo

Comments (5)

vaeth avatar vaeth commented on June 12, 2024

It works both, and it is unclear what is more future-safe. I guess when in doubt, http is more compatible (if users change from wget to something else).

from squashmount.

8573 avatar 8573 commented on June 12, 2024

Thanks for your response.

I guess when in doubt, http is more compatible (if users change from wget to something else).

What something else would users change to that wouldn’t support HTTPS? The only utility comparable to wget I can think of is curl, which also supports HTTPS (and indeed often works better in that regard, in my experience); and I don’t see that an alternative that doesn’t support so common a protocol as HTTPS would be worth changing to — and many ebuilds in the Portage tree already use SRC_URIs pointing to GitHub tarballs via HTTPS.

I suppose the Manifest already provides an integrity check, but I don’t see that another layer would hurt.

(I hope I don’t seem like I’m demanding that you change the protocol. And, this seems like a good utility; thanks for it.)

from squashmount.

vaeth avatar vaeth commented on June 12, 2024

What something else would users change

There are several "parallel fetchers" or user-written scripts out there; I also suppose that neither curl nor wget support https if compiled with USE=-ssl.

However, this question is not really related.

There seems to be a misunderstanding: Using https in SRC_URI is not more secure (when you use wget with USE=ssl which is the only case I tested): github will redirect then anyway to a https address. So the only thing that would change if I would put https into the SRC_URI is that one redirection is saved. But it would have the disadvantage that it would take github the (current or future) possibility to fallback/use some other redirection.

from squashmount.

vaeth avatar vaeth commented on June 12, 2024

Although the main vulnerability remains DNS, there is of course an additional MITM attack vector when relying on correct https redirection. After thinking it over, I think it is worth to avoid this attack scenario at the possible cost of compatibility/future-safety. I changed all ebuilds and references in all my github projects correspondingly. Closing as fixed

from squashmount.

8573 avatar 8573 commented on June 12, 2024

Okay, thanks!

from squashmount.

Related Issues (12)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.