Here's the Weekly Digest for tunnckoCoreLabs/dush:

ISSUES

Last week, no issues were created.

PULL REQUESTS

Last week, no pull requests were created, updated or merged.

COMMITS

Last week there were no commits.

CONTRIBUTORS

Last week there were no contributors.

STARGAZERS

Last week there were no stargazers.

RELEASES

Last week there were no releases.

That's all for last week, please 👀 Watch and ⭐ Star the repository tunnckoCoreLabs/dush to receive next weekly updates. 😃

You can also view all Weekly Digests by clicking here.

Your Weekly Digest bot. 📆

Since .all is pretty common. Maybe ._all or why not ._allEvents - with or without dash.

Here's the Weekly Digest for tunnckoCoreLabs/dush:

ISSUES

Last week, no issues were created.

PULL REQUESTS

Last week, no pull requests were created, updated or merged.

COMMITS

Last week there were no commits.

CONTRIBUTORS

Last week there were no contributors.

STARGAZERS

Last week there were no stargazers.

RELEASES

Last week there were no releases.

That's all for last week, please 👀 Watch and ⭐ Star the repository tunnckoCoreLabs/dush to receive next weekly updates. 😃

You can also view all Weekly Digests by clicking here.

Your Weekly Digest bot. 📆

• bump devDeps
• boilerplate stuff

Which will be used to extend the returned object. Inheritance.

For example

var app = dush({
  foo: 'bar'
})

console.log(app.foo) // => 'bar'
console.log(app.on) // => function

I haven't investigated to precisely determine the mechanism of the bug, but the behavior i saw was that binding the same handler to the same event with once multiple times would remove the wrong handler after firing.

so for example, you have an object which provides a token: myObject.getToken(), but my object is instantiated by an asynchronous process, you might write code like:

let tokenPromise = ()=>{
  if(myObject) {
    return new Promise((resolve) => {
        resolve(myObject.getToken())
    })
  }
  return new Promise((resolve)=>{
      emitter.once('MY_OBJECT_CREATED', ()=>{
        resolve(myObject.getToken())
      })
  })
}

multiple calls to tokenPromise results in the wrong handlers being unbound by once, i believe to confusion around the value of 'fn' within the once() method.

this seems to resolve the issue:

    once: function once (name, handler) {
      function fn (a, b, c) {
        app.off(name, this);
        handler(a, b, c);
      }

      return app.on(name, fn.bind(fn))
    }

Test case:

const emitter = dush()

const handler1 = () => { console.log('a') }
const handler2 = () => { console.log('a') }

emitter.on('a', handler1)
emitter.on('a', handler2)
emitter.off('a', handler1)

What is expected?

handler2 should not be removed

What is actually happening?

handler2 is removed because the lib uses fn.toString() to identify a function and source code of both functions looks the same

Here's the Weekly Digest for tunnckoCoreLabs/dush:

ISSUES

Last week, no issues were created.

PULL REQUESTS

Last week, no pull requests were created, updated or merged.

COMMITS

Last week there were no commits.

CONTRIBUTORS

Last week there were no contributors.

STARGAZERS

Last week there were no stargazers.

RELEASES

Last week there were no releases.

That's all for last week, please 👀 Watch and ⭐ Star the repository tunnckoCoreLabs/dush to receive next weekly updates. 😃

You can also view all Weekly Digests by clicking here.

Your Weekly Digest bot. 📆

In the README.md file, all the handlers are described as strings , when they are functions indeed.

Here's the Weekly Digest for tunnckoCoreLabs/dush:

ISSUES

Last week, no issues were created.

PULL REQUESTS

Last week, no pull requests were created, updated or merged.

COMMITS

Last week there were no commits.

CONTRIBUTORS

Last week there were no contributors.

STARGAZERS

Last week there were no stargazers.

RELEASES

Last week there were no releases.

That's all for last week, please 👀 Watch and ⭐ Star the repository tunnckoCoreLabs/dush to receive next weekly updates. 😃

You can also view all Weekly Digests by clicking here.

Your Weekly Digest bot. 📆

But we support any number of any type of value to be emitted.

Because it will trigger listeners twice. See this reddit thread comment.

const emitter = dush()

emitter.on('*', (name, a, b, c) => {
  console.log('args', name, a, b, c)
  // => args foo 1 2 3
  // => args 4 5 6 undefined
  // => args * 4 5 6
})

emitter.emit('foo', 1, 2, 3)
emitter.emit('*', 4, 5, 6)

Reproduction code: https://jsfiddle.net/Lfozrhdw/

The issue is in line https://github.com/tunnckoCore/dush/blob/master/src/index.js#L146

Should be fn.__sourceString = fn.toString()

Here's the Weekly Digest for tunnckoCoreLabs/dush:

ISSUES

Last week, no issues were created.

PULL REQUESTS

Last week, no pull requests were created, updated or merged.

COMMITS

Last week there were no commits.

CONTRIBUTORS

Last week there were no contributors.

STARGAZERS

Last week there were no stargazers.

RELEASES

Last week there were no releases.

That's all for last week, please 👀 Watch and ⭐ Star the repository tunnckoCoreLabs/dush to receive next weekly updates. 😃

You can also view all Weekly Digests by clicking here.

Your Weekly Digest bot. 📆

This doesn't seem to work as expected:

const emitter = dush()
const hello = () => console.log("You shouldn't see this.")
emitter.once('test', hello)
emitter.off('test', hello)
emitter.emit('test')

Like that

const dush = () => {
  // ... code
}

const app = dush()
app.dush = dush

export default app

so we can just

const { on, off, once, emit, use } = require('dush')

or get the singleton

const { dush } = require('dush')