Comments (10)
My solution stores a reference to the original handler in the wrapper rather than a string.
I was using this before ;d
But anyway I'm not hard about that, so PR is welcome.
(Oh, I should definitely update the repo boilerplate and stuff (oh god, there's no automatic publish and release here?! so it's really old of haha) ;d But if you are okey with that, great!)
from dush.
@boli-duality I did not expect to receive notifications from this repo ^^. The project is most likely dead, not updated for 7 years. I would advise you to simply find another event emitter. mitt is fine.
from dush.
Hi !
I stumbled on this issue as well,
@tunnckoCore would you be interested in a PR for this one ?
from dush.
That's "known bug", based on how I decided (which is pretty weird and tricky hack) to do the off
-ing. It is string based. And if both functions are the same well then yea.
I definitely don't remember why I chose that hack, instead of doing it with few other possible ways.
from dush.
I made some tests and if you remove the string based comparaison and replace it with reference based comparaison, it seems to be ok.
I'm guessing you went with string based because the "off" function was not able to find the wrapped version of the handler. My solution stores a reference to the original handler in the wrapper rather than a string. It's actually very little change and every test is still passing (even losing a couple bytes in the final bundle).
Any other reason you used string based comparaison that i'm not thinking of ?
I have a PR almost ready !
from dush.
Hi, sorry to bother. I ran into the same problem. Is there any news about a fix release?
from dush.
There's #42 but conflicts should be resolved so I can merge.
from dush.
Any news on this @tunnckoCore ?
from dush.
@kouts, sorry, not for now. I can come back in few days and look into an update. I'm switching and upgrading machines now.
from dush.
@kouts, sorry, not for now. I can come back in few days and look into an update. I'm switching and upgrading machines now.
Hi, just wanna check if there is a update going on. thanks in advanced!
from dush.
Related Issues (18)
- Test ticket from Code Climate
- Rename `.all` to something more hidden HOT 2
- Merge returned from plugin with `app`
- david-dm badge / and update
- Listener added through .once is not removed after event execution HOT 1
- Allow passing single argument to `dush()` HOT 1
- Error in documentation HOT 1
- Weekly Digest (8 February, 2019 - 15 February, 2019)
- Weekly Digest (10 February, 2019 - 17 February, 2019)
- Weekly Digest (17 February, 2019 - 24 February, 2019)
- Disallow emitting wildcard
- Weekly Digest (24 February, 2019 - 3 March, 2019)
- Weekly Digest (3 March, 2019 - 10 March, 2019)
- Should we expose separate methods on default export? HOT 1
- binding the same handler to the same event with once() can have unexpected results HOT 14
- .off() is not working properly for listeners added by .once() HOT 2
- .once calls handler with just only 3 arguments
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from dush.