Giter Club home page Giter Club logo

hidingnavigationbar's Introduction

tristanhimmelman

hidingnavigationbar's People

Contributors

annotunzdy avatar asaake avatar danieleggert avatar felipowsky avatar iosdevzone avatar jeffaburt avatar joshwalker avatar kawamurakazushi avatar readmecritic avatar rsrbk avatar sotozaki avatar tristanhimmelman avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

hidingnavigationbar's Issues

NavigationBar ignores existing contentInsets

HidingNavigationBar works perfectly apart from this one point.

Before implementing:

img_0372x

After implementing:

img_0373x

The navigation hiding functionality works fine but I am losing my initial contentInset values.

tableView.contentInset = UIEdgeInsets(top: 8, left: 0, bottom: 0, right: 0)

Would be a great improvement.

I've used a hack in the meantime:

    private func updateContentInsets() {
        let navBarBottomY = navBarController.view.frame.origin.y + navBarController.view.frame.size.height + 8

Crash on "Remove Gesture when deinit"

Hello,

I updated the pod to latest version and I got this crash on deinit func. It wasn't occur earlier version and I examined the relaese notes.

I saw there is a method added, on v.2.0.0
Commits on Mar 22, 2017 @ANNotunzdY "Remove Gesture when deinit" c0d38c5

deinit {
		NotificationCenter.default.removeObserver(self)
		if let panGesture = panGesture {
			scrollView.removeGestureRecognizer(panGesture)
		}
	}

"Fatal error: Attempted to read an unowned reference but the object was already deallocated"

Could you check please?
Thank you.

memory leak?

i added one line to line 101:

print("HidingNavigationBarManager deinit")

but the string wont be printed

Problem in the extension View

Hello this is a great library. I have used this on my project. In my view controller i have a collectionView and above the collectionView there is the extensionView and above that there is navigationBar, in the collectionView there is textview in every cell. now when i am trying to show the keyboard, and want to hide the keyboard the extensionView is coming down and there is seeing a black space between the extensionView and Navigation bar. Some one please help me in this matter.

Strong Reference Cycle

Calling HidingNavigationBarManager(viewController: self, scrollView: scrollView) on the view controller does not allow that view controller to deallocate when needed.

Extended View mispositioned

Whenever I create an extended view on table view controller, it appears on the middle of the screen. Any suggestion? I saw that sample code uses a ui table view, and not controller. It its possible to add extended view to ui table view controller?
Thanks

Apply for UIWebview

It seem not working with UIwebview?

I looking for Navbar will hide when scrolling a UIWebview. Can you please give me any ideal.

Thank sir so much!

Sticky header view

Hi
can we make stickyExtensionView mode ?

Something like TLYShyNavBar

HidingNavigationBar Integration Issue

I have added the the library through CocoaPods and after that I have tried to add the variable of HidingNavigationBarManager but I'm getting this issue

Use of undeclalead type 'HidingNavigationBarManager'

Should I import something else?

Thanks.

Hide Status Bar

Hi, is it possible to hide the status bar along with the navigation bar at the same time? :)

Section header view below navigation bar after on appearance

Hi,

I have a UITableView in a UINavigationController. My tableView contains sections headers.

When I click on the cell, I push another viewController. I call

hidingNavBarManager?.viewWillDisappear(animated)

When the user goes back, the section header is hidden below the navigationBar, as if the tableView had not scrolled. Any idea how to scroll the tableview so the header section is not below the navigation bar on appearance?

Thanks

Nav title flickers when hiding

Repro steps:

Set the title of the nav bar, and scroll up slowly. The title flickers.

Nav bar sets the alpha of the bar whenever the nav bar size changes.

Constaints does not updated

I tried to hide navigation bar and tab bar, it's works but there is blank spot when navigation bar and tab bar is hidden.
Does anyone solved it ?

simulator screen shot aug 2 2016 10 20 44 am
simulator screen shot aug 2 2016 10 20 48 am

v0.3.0 does expose the `onForegroundAction` option

Hello,
I installed v0.3.0 and it does not have the onForegroundAction option. the source code doesn't have the line:

    //Options
    public var onForegroundAction = HidingNavigationForegroundAction.Default

Could it be the wrong version being pushed?

pod install log:

$ pod install
Updating local specs repositories

CocoaPods 1.1.0.beta.1 is available.
To update use: `gem install cocoapods --pre`
[!] This is a test version we'd love you to try.

For more information see http://blog.cocoapods.org
and the CHANGELOG for this version http://git.io/BaH8pQ.

Analyzing dependencies
Downloading dependencies
...
Installing HidingNavigationBar (0.3.0)
...
Generating Pods project
Integrating client project
Sending stats
Pod installation complete! There are 31 dependencies from the Podfile and 36 total pods installed.

can't run in Xcode7

the source code example can not run in Xcode7, by the way, how could I use HidingNavigationBar in the project write by OC ? thx!

Looks like a typo in HidingNavigationBarManager

On line 348:
let contentInset = UIEdgeInsets(top: top, left: scrollViewContentInset.top, bottom: scrollViewContentInset.left, right: scrollViewContentInset.right)

Looks like you're setting left to top and bottom to left. Is that intentional?

[iOS 11.2] UITabBarController and "contentInsetAdjustmentBehavior" issue

If you using HidingNavigationBarManager in controller witch is in array "viewControllers" of UITabBarController, you will have a huge white offset in the bottom of scroll.
https://drive.google.com/file/d/1vPbndd4bXcUN0zb4QD9KeM_uN0mA-_aF/view?usp=sharing
https://drive.google.com/file/d/1lucODLIBrHriOiUdSG75-KJZrMmXIVDp/view?usp=sharing

Reason of such offset is unreal bottom offset value. It's become bigger and bigger during you are scrolling.
https://drive.google.com/file/d/1umARWIkkudNcdngHQ7BssZnQxmspzD6L/view?usp=sharing

I found reason of this bug - this issues becomes visible when "scrollView.contentInsetAdjustmentBehavior" set to any other value than ".never". If you set "never", content of scrollView goes under tabBar and navigationBar - so it is bad solution. I opened source code if library and found 3 lines of code that do this bug.
https://drive.google.com/file/d/1OsRUSUOYalhKnRTextEqdrVhJ9VelNzx/view?usp=sharing
If you comment this 3 lines - there aren't huge white offset no more, in the top everything is great on iPhone X and traditional iPhones. Only issue - now there is 49 points of gap for tab bar.

So I see 2 solutions:

  1. Recalculate bottom offset same way like you do "top = adjustTopInset(top)".
  2. Show tab bar when you at the bottom of scroll view.

P.S. #1 Something strange is going on this piece of code:
https://drive.google.com/open?id=1qTWlhopf1DN2M3ByQXVd7PGZ-uoj3aQp

P.S. #2 My quick fix was add this code at "func handleScrolling()"
if scrollView.contentSize.height - scrollView.contentOffset.y < scrollView.frame.size.height {
UIView.animate(withDuration: 0.2, animations: {
_ = self.tabBarController?.expand()
})
}

Not working in iOS 11

When I installed Hide Navigation Bar in iOS 11 my whole app screen gone blank as soon as I removed the integration all screens are intact now.

HidingNavigationBarManager conflicts with refreshControl

If I use HidingNavigationBarManager on UICollectionView or UITableView with a refresh control, the HidingNavigationBarManager totally breaks the refresh control.

The refresh becomes jitty and is even sometimes hidden.

I am guessing this has to do with the fact that the HidingNavigationBarManager is doing stuff to the collectionView inset.

Maybe implement a listener to "kill" the HidingNavigationBarManager during refresh…

NOTE: I am implementing
self.hidingNavBarManager?.refreshControl = self.refreshControl

This happens on a UICollectionView with a custom layout. I haven't checked on a standard layout nor on a UITableView

The height of scroll view gets short when tabbar hides

Though it would be a little difficult to judge, as following gif when I scroll the table view, the height of the table view gets short somehow.

bug

I'm using swift 2.0 and xcode 7.1.
These are my codes.

let rect = UIScreen.mainScreen().bounds;
tableView.frame = CGRectMake(0, 0, rect.size.width, rect.size.height)
hidingNavBarManager = HidingNavigationBarManager(viewController: uiViewController, scrollView: tableView)
 if let tabBar = self.navigationController?.tabBarController?.tabBar {
          hidingNavBarManager?.manageBottomBar(tabBar)
          tabBar.barTintColor = UIColor(white: 230/255, alpha: 1)
 }

Hiding status bar expands navigation bar

How to reproduce in the demo project:
Add this to HidingNavViewController.swift:

func tableView(tableView: UITableView, didSelectRowAtIndexPath indexPath: NSIndexPath) {
UIApplication.sharedApplication() .setStatusBarHidden(true, withAnimation: UIStatusBarAnimation.Slide)
}

and then go to Hiding Nav Bar, scroll down a bit so that the bar collapses, and tap on a row.
The bar will then expand but without resetting the subviews' alpha values.

Is this a quick fix? I'm not very experienced in Swift.
Thank you!

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.