Comments (11)
In addition to status bar frame changes, the framework should also consider when the status bar becomes hidden and shown. The same notifications are thrown for showing / hiding the status bar, so it is possible to add all handling there.
from hidingnavigationbar.
Solution founded ! .. plz create a PullRequest
fileprivate func statusBarHeight() -> CGFloat {
if UIApplication.shared.isStatusBarHidden {
return 0
}
let statusBarSize = UIApplication.shared.statusBarFrame.size
let extendedStatusBarDifference = abs(viewController.view.bounds.height - (UIApplication.shared.delegate?.window??.frame.size.height ?? UIScreen.main.bounds.height))
return min(statusBarSize.width, statusBarSize.height) - extendedStatusBarDifference
}
from hidingnavigationbar.
To elaborate. The navigation bar juts out into the screen when the status bar is expanded.
from hidingnavigationbar.
If anybody has time to add this functionality I would happily accept a PR to support this. I currently do not have time to work on this
from hidingnavigationbar.
Unless I am misunderstanding the original post on this issue, I wouldn't consider this issue a request for additional functionality. The issue I am reporting is a bug.
Do you know what's causing the issue? If you can point me in the right direction, perhaps I could take a shot at it.
from hidingnavigationbar.
@btc this feature was never actually supported by the library which is why I don't call it a bug.
I believe the root of the issue is that the ViewController changes its frame and HidingNavigationBarManager
does not respond to this event. I would start in that class by monitoring the following events:
UIApplicationWillChangeStatusBarFrameNotification
UIApplicationDidChangeStatusBarFrameNotification
from hidingnavigationbar.
Thank you. I'll have a look at this and give it a shot.
from hidingnavigationbar.
What is the current status of this problem?
from hidingnavigationbar.
I use another library since I submitted this issue and didnt get response.
https://github.com/andreamazz/AMScrollingNavbar
from hidingnavigationbar.
Yes, I know this framework. I create my own at https://github.com/StefaniOSApps/AMScrollingNavbar - but it sucks - it use only tap gesture and too many bugs. I hope i can fix the other bugs at this framework. The current bug was fixed.
from hidingnavigationbar.
I want to upgrade this Framework to iOS 11.
https://github.com/StefaniOSApps/TLYShyNavBar
Any help is welcome. Many things are already working.
from hidingnavigationbar.
Related Issues (20)
- Hide Status Bar HOT 1
- Sticky header view
- nav bar shows when app goes back to foreground HOT 1
- Apply for UIWebview
- barbuttonItem short 1/2 height when push to uiviewController
- How can I know my navigation bar is hidden or not? HOT 1
- Looks like a typo in HidingNavigationBarManager
- Does work in iOS 11 HOT 3
- HidingNavTabViewController not wok
- Crash on "Remove Gesture when deinit" HOT 10
- [iOS 11.2] UITabBarController and "contentInsetAdjustmentBehavior" issue HOT 1
- I want to hide only extensionview instead of both navigation bar and extension view HOT 1
- Not working in iOS 11 HOT 2
- Problem in the extension View HOT 1
- Nav title flickers when hiding HOT 2
- large title still display error
- 'titleForHeaderInSection' and 'sectionIndexTitle' is disappeared on Grouped Style UITableView.
- Replace navigation bar with arbitrary view? HOT 1
- do you have any instructions of how to use it in SwiftUI?
- all what we have to do is the following instead of using a pod HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from hidingnavigationbar.