trinitytbc / core Goto Github PK

Text tables need to be ported:

• locales_broadcast_text
• locales_creature
• locales_creature_text
• locales_gameobject
• locales_item
• locales_gossip_menu_option
• locales_gossip_text
• locales_page_text
• locales_quest
• page_text_locale

Further fixes includes:

• Creature (Entry: 299) has no model defined in table creature_template, can't load.
• Fix db errors like "BroadcastText (Id: 23254) in table broadcast_text_locale does not exist. Skipped!"
• Fix invalid or non-existing item id in creature_equip_template, maybe data can be found in client DBC.
• Remove non-TBC content smart_scripts, such as scripts of non-existing creatures or gameobjects.

and db errors to fix:

• Unknown item (entry=40596) in creature_equip_template.itemEntry2 for entry = 37016 and id=1, forced to 0.
• GameObject (Entry: 190708 GoType: 8) have data0=1553 but SpellFocus (Id: 1553) not exist.
• GameObject (Entry: 176310 GoType: 15) have data0=967 but TaxiPath (Id: 967) not exist.
• Gameobject (Entry: 184912 GoType: 0) have data1=1804 but lock (Id: 1804) not found.
• Creature (Entry: 69) has non-existing PetSpellDataId (13060).
• Creature (Entry: 37496) has non-existing Spell1 (69350), set to 0.
• Unknown item (entry=50433) in creature_equip_template.itemEntry1 for entry = 80 and id=1, forced to 0.
• Creature (Entry: 69) has wrong spell 71764 defined in auras field in creature_template_addon.
• Creature (Entry: 22081) has invalid emote (468) defined in creature_template_addon.
• Creature (Entry: 25063) has invalid displayInfoId (28417) for mount defined in creature_template_addon
• Faction (faction.dbc) 1052 does not exist but is used in creature_onkill_reputation
• Table creature has creature (GUID: 52053) that have wrong spawn mask 3 including unsupported difficulty modes for map (Id: 249).
• Creature (GUID: 48316) has wrong spell 61574 defined in auras field in creature_addon.
• Creature (GUID: 68922) has invalid displayInfoId (28918) for mount defined in creature_addon
• Creature (GUID: 128172) has temporary aura (spell 30110) in auras field in creature_addon.
• Table creature_summon_groups has creature in group [Summoner ID: 33186, Summoner Type: 0, Group ID: 1] with non existing creature entry 33287, skipped.
• Table gameobject has gameobject (GUID: 6166 Entry: 181575) that has wrong spawn mask 3 including unsupported difficulty modes for map (Id: 533), skip
• Spawn data with ID (0,74212) not found, but is listed as a member of spawn group 2!
• Quest 415 has RewardNextQuest = 4294966981 but quest 4294966981 does not exist, quest chain will not work.
• Table creature_queststarter has creature entry (15350) for quest 8367, but npcflag does not include UNIT_NPC_FLAG_QUESTGIVER
• game_event_condition: game event id (135) is out of range compared to max event id in game_event.
• game_event_seasonal_questrelation: quest id (8971) does not exist in quest_template.
• Wrong skill id 777 in playercreateinfo_skills table, ignoring.
• Table 'creature_loot_template' entry 15690 item 187915: item entry not listed in item_template - skipped
• Table 'creature_loot_template' Entry 100001 does not exist but it is used by Creature 37642
• Table 'creature_loot_template' entry 15041 isn't creature entry and not referenced from loot, and then useless.
• Table 'gameobject_loot_template' Entry 26884 does not exist but it is used by Gameobject 113768
• Table 'gameobject_loot_template' entry 4984 isn't gameobject entry and not referenced from loot, and then useless.
• Table 'pickpocketing_loot_template' Entry 25760 does not exist but it is used by Creature 25760
• Table 'skinning_loot_template' Entry 100013 does not exist but it is used by Creature 4352
• Table 'skinning_loot_template' entry 1258 isn't creature skinning id and not referenced from loot, and then useless.
• Table trainer_spell references non-existing trainer (TrainerId: 221196) for SpellId 42296, ignoring
• Table (game_event_)npc_vendor have data for not creature template (Entry: 2404) without vendor flag, ignore
• Found waypoint_info data for empty path 1469
• CreatureTextMgr: Entry 26668, Group 0 in table creature_text has Sound 13857 but sound does not exist.
• Table quest_end_scripts has invalid gameobject (SpawnId: 17641) in SCRIPT_COMMAND_RESPAWN_GAMEOBJECT for script id 4119
• SystemMgr: DB table script_waypoint has waypoint for creature entry 2768, but creature does not have ScriptName defined and then useless.
• ScriptName 'npc_the_etymidian' exists in database, but no core script found!
• SmartAIMgr::LoadSmartAIFromDB: Creature guid (201800) does not exist, skipped loading.

Description:

Wolfs are never able to kill a Rabbit. The wolfs are attacking the Rabbit, but the rabbit will never die. It just keep running.

Expected behaviour:

Wolfs should kill a Rabbit with one bite.

Steps to reproduce the problem:

1. Create a human character
2. See wolfs attacking a Rabbit

rev. hash/commit:

85c2be4

Operating system and compiler: *

Description:

Player can see creature with stealth in any distance.

Steps to reproduce the problem:

1. .go 2850
2. check panthers around
3. you'll see panthers with stealth in any distance.

rev. hash/commit:

62e0cb9

Operating system and compiler:
Ubuntu

• Caster creature not release target if target died.
• Summons by creature disappear immediately after summoned.

Suggestion you could add the Eluna Engine system

https://github.com/ElunaLuaEngine/Eluna

https://github.com/ElunaLuaEngine/ElunaTrinityWotlk

test

Description:

Temp summon does not disappear visually for the player it just killed. It actually was unsummoned.
Untill player revive(e.g with .revive gm command), the temp summon disappears visually.

Expected behaviour:

The core should notifiy the client the temp summon unsummoned when player was killed by the summon.

Steps to reproduce the problem:

1. .go c id 16925
2. Let the creature kill you.
3. Gotcha

rev. hash/commit:

e4c1bf4

Operating system and compiler: Windows 10

Description:

When installing on Windows you get DB errors.

Current behaviour:

The first Error is that the core trys to install world_2019_01_30.sql. But the current release DB is named:
TTDB_full_world_19124_2019_12_22.7z
Have to change it in revision_data.h.in.cmake

The 2nd part after installing it, is database not loading correctly.

BroadcastText (Id: 23254) in table `broadcast_text_locale` does not exist. Skipped! 
[1305] FUNCTION world.ANY_VALUE does not exist
Unhandled MySQL errno 1305. Unexpected behaviour possible.
[1305] FUNCTION world.ANY_VALUE does not exist
Unhandled MySQL errno 1305. Unexpected behaviour possible.
Creature template (Entry: 6) does not exist but has a record in `creature_equip_template`

Getting these errors even if there is Data in the Database.

Expected behaviour:

No DB Errors

Steps to reproduce the problem:

rev. hash/commit:

CHANGEME Please put the git commit hash.

Operating system and compiler: Windows 64 Bit

Description:

Autoattack not immediately apply after Warrior Charge when only single weapon equiped. But it's fine with dual weapons equied(with main hand and off-hand weapon equiped).

Expected behaviour:

Autoattack should apply immediately after Warrior Charge in any weapon equipment state.

Steps to reproduce the problem:

1. create a Warrior character
2. .level 10, and learn Charge spell
3. Charge any mobs

rev. hash/commit:

https://github.com/TrinityTBC/core/commits/master

Operating system and compiler: Ubuntu

Description:

Player can loot quest gameobject even he does not have the quest related.

Expected behaviour:

Player should not be able to loot any quest gameobject if he haven't accpeted the quest yet.

Steps to reproduce the problem:

1. .go object 23566
2. loot the quest gameobject

rev. hash/commit:

3f1f760

Operating system and compiler: Windows